Cycles denoising; Firefly/Highlight processing leads to pixels with negative values, values of -1.#INDO #51767

New Issue

Adam Friesen · 2017-06-10T05:20:46+02:00

Adam Friesen commented

2017-06-10 05:20:46 +02:00

System Information
Win10 64 bit; 24 gigs RAM; third-gen i7 CPU; AMD 7xxx GPU (Crimson ReLive drivers)
CPU Rendering

Blender Version
Broken: Hash c73206a
Worked: Never

Short description of error
When the denoiser processes scenes containing firefly-prone materials and bright highlights, it can lead to results filled with black pixels (some with negative values, others with values of -1.#INDO). Increasing the samples helps to reduce the issue of fireflies going black, but not with highlights that are small and bright.

Exact steps for others to reproduce the error
Open the .blend file, render the scene, and examine the values of the many black pixels on top of Suzanne.

.blend
Denoise_artifacts.blend

**System Information** Win10 64 bit; 24 gigs RAM; third-gen i7 CPU; AMD 7xxx GPU (Crimson ReLive drivers) CPU Rendering **Blender Version** Broken: Hash c73206a Worked: Never **Short description of error** When the denoiser processes scenes containing firefly-prone materials and bright highlights, it can lead to results filled with black pixels (some with negative values, others with values of -1.#INDO). Increasing the samples helps to reduce the issue of fireflies going black, but not with highlights that are small and bright. **Exact steps for others to reproduce the error** Open the .blend file, render the scene, and examine the values of the many black pixels on top of Suzanne. **.blend** [Denoise_artifacts.blend](https://archive.blender.org/developer/F626594/Denoise_artifacts.blend)

Adam Friesen commented

2017-06-10 05:20:46 +02:00

Changed status to: 'Open'

Adam Friesen commented

2017-06-10 05:20:46 +02:00

Added subscriber: @Ace_Dragon

Adam Friesen changed title from ~~Cycles denoising; Firefly processing leads to pixels with negative values, values of -1.#INDO~~ to Cycles denoising; Firefly/Highlight processing leads to pixels with negative values, values of -1.#INDO

2017-06-10 05:36:03 +02:00

Steffen Dünner commented

2017-06-10 11:07:54 +02:00

Added subscriber: @SteffenD

Joel Godin commented

2017-06-10 16:38:42 +02:00

Added subscriber: @FloridaJo

Joel Godin commented

2017-06-10 16:38:42 +02:00

Same as #51681

Adam Friesen commented

2017-06-10 23:36:08 +02:00

Okay, there definitely is a major regression in overall quality due to one or both of these commits
https://lists.blender.org/pipermail/bf-blender-cvs/2017-June/097346.html
https://lists.blender.org/pipermail/bf-blender-cvs/2017-June/097384.html

Illustration

Before the commits (left image), fireflies just disappeared with no issue, highlight processing might've left a black pixel here and there, but their values were just slightly negative instead of INDO.
After the commits (right image), a number of fireflies and highlights now just go black instead of going away or being left alone. The quality issues that were resolved were surpassed greatly by the number that were introduced (and the regression affects every scene I might add, bright pixels aren't needed to trigger it).

Okay, there definitely is a major regression in overall quality due to one or both of these commits https://lists.blender.org/pipermail/bf-blender-cvs/2017-June/097346.html https://lists.blender.org/pipermail/bf-blender-cvs/2017-June/097384.html **Illustration** ![Denoise_regression.jpg](https://archive.blender.org/developer/F627124/Denoise_regression.jpg) Before the commits (left image), fireflies just disappeared with no issue, highlight processing might've left a black pixel here and there, but their values were just slightly negative instead of INDO. After the commits (right image), a number of fireflies and highlights now just go black instead of going away or being left alone. The quality issues that were resolved were surpassed greatly by the number that were introduced (and the regression affects every scene I might add, bright pixels aren't needed to trigger it).

Lukas Stockner commented

2017-06-11 02:03:05 +02:00

Added subscriber: @LukasStockner

Lukas Stockner commented

2017-06-11 02:03:05 +02:00

Changed status from 'Open' to: 'Archived'

Lukas Stockner closed this issue

2017-06-11 02:03:05 +02:00

Lukas Stockner self-assigned this 2017-06-11 02:03:05 +02:00

Lukas Stockner commented

2017-06-11 02:03:05 +02:00

Okay, this is somewhat improved with 558bea2. I'll look into better handling in the future, but we're really close to a release and fixing the underlying issues will be really tricky (if it's even possible)...

I'll close this for now, but I'll keep the file for further tests.

(Sorry for the copy-paste from other reports, these are all related issues).

Okay, this is somewhat improved with 558bea2. I'll look into better handling in the future, but we're really close to a release and fixing the underlying issues will be really tricky (if it's even possible)... I'll close this for now, but I'll keep the file for further tests. (Sorry for the copy-paste from other reports, these are all related issues).

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cycles denoising; Firefly/Highlight processing leads to pixels with negative values, values of -1.#INDO #51767