Greasepencil-object branch crashes on selecting bone in edit mode. #51923

New Issue

Thomas Downs · 2017-06-28T15:39:21+02:00

Thomas Downs commented

2017-06-28 15:39:21 +02:00

06/28/2017
System Information
Arch Linux
Nvidia 750ti

Blender Version
Broken: greasepencil-object branch b0b0e3872ec289f61349471f66a71146b13aa2d5

     commit: b8df9f653178f356565d5beb8d7a979b2405420d
     been broken for me all the commits for a week or so

Worked: about a couple weeks ago on the greasepencil-object branch, the blender2.8 branch works fine

Short description of error
Blender crashes when selecting a bone in edit mode.

Exact steps for others to reproduce the error
Start with default blend, add an armature, tab into edit mode, and then select a bone.

06/28/2017 **System Information** Arch Linux Nvidia 750ti **Blender Version** Broken: greasepencil-object branch b0b0e3872ec289f61349471f66a71146b13aa2d5 ``` commit: b8df9f653178f356565d5beb8d7a979b2405420d been broken for me all the commits for a week or so ``` Worked: about a couple weeks ago on the greasepencil-object branch, the blender2.8 branch works fine **Short description of error** Blender crashes when selecting a bone in edit mode. **Exact steps for others to reproduce the error** Start with default blend, add an armature, tab into edit mode, and then select a bone.

Thomas Downs commented

2017-06-28 15:39:21 +02:00

Changed status to: 'Open'

Thomas Downs commented

2017-06-28 15:39:21 +02:00

Added subscriber: @tnelsond

Antonio Vazquez self-assigned this 2017-06-28 15:51:03 +02:00

Antonio Vazquez commented

2017-06-28 16:10:24 +02:00

Added subscribers: @fclem, @dfelinto

Antonio Vazquez commented

2017-06-28 16:10:24 +02:00

It looks the problem is on DRW_framebuffer_init() in GPENCIL_engine_init() https://developer.blender.org/diffusion/B/browse/greasepencil-object/source/blender/draw/engines/gpencil/gpencil_engine.c;b8df9f653178f356565d5beb8d7a979b2405420d$62

The debug shows that all works perfect except if you create an armature, enter in edit mode and select the bone.

One weird thing is the DRW_viewport_size_get() returns 24 x 24 when it was returning the right value before select the bone.

@fclem @dfelinto Do you think this can be related to draw armature engine?

It looks the problem is on DRW_framebuffer_init() in GPENCIL_engine_init() https://developer.blender.org/diffusion/B/browse/greasepencil-object/source/blender/draw/engines/gpencil/gpencil_engine.c;b8df9f653178f356565d5beb8d7a979b2405420d$62 The debug shows that all works perfect except if you create an armature, enter in edit mode and select the bone. One weird thing is the DRW_viewport_size_get() returns 24 x 24 when it was returning the right value before select the bone. @fclem @dfelinto Do you think this can be related to draw armature engine?

Clément Foucault commented

2017-06-28 16:22:16 +02:00

Added subscriber: @ideasman42

Clément Foucault commented

2017-06-28 16:22:16 +02:00

It's related to the selection loop that set the viewport to 24px².
Maybe @ideasman42 could help you on this.

It's related to the selection loop that set the viewport to 24px². Maybe @ideasman42 could help you on this.

Antonio Vazquez removed their assignment 2017-09-19 16:48:05 +02:00

Campbell Barton was assigned by Antonio Vazquez

2017-09-19 16:48:05 +02:00

Antonio Vazquez commented

2017-09-19 16:48:05 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2017-09-19 16:48:05 +02:00

Campbell, do you have any update about this?

Campbell Barton commented

2017-09-20 06:46:02 +02:00

Other engines check DRW_state_is_fbo() before initializing FBO's.

However I'm not sure if it makes sense to support this case,
In the short term it's simplest not to use grease pencil engine when DRW_state_is_select is set.

Longer term we may want to support GL selection here - we may want solid filled grease pencil to be selectable, or just prevent things behind them from becoming selected.

Other engines check `DRW_state_is_fbo()` before initializing FBO's. However I'm not sure if it makes sense to support this case, In the short term it's simplest not to use grease pencil engine when `DRW_state_is_select` is set. Longer term we may want to support GL selection here - we may want solid filled grease pencil to be selectable, or just prevent things behind them from becoming selected.

Campbell Barton was unassigned by Antonio Vazquez

2017-09-20 10:25:30 +02:00

Antonio Vazquez self-assigned this 2017-09-20 10:25:30 +02:00

Antonio Vazquez commented

2017-09-20 10:25:31 +02:00

@ideasman42 Thanks for the DRW_state_is_fbo() trick.

I have added this check and the problem is solved, but as you said, in the long term to have the option to select a GP object selecting the strokes would be great.

@ideasman42 Thanks for the DRW_state_is_fbo() trick. I have added this check and the problem is solved, but as you said, in the long term to have the option to select a GP object selecting the strokes would be great.

Antonio Vazquez commented

2017-09-20 10:28:44 +02:00

Changed status from 'Open' to: 'Resolved'

Antonio Vazquez closed this issue

2017-09-20 10:28:44 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Greasepencil-object branch crashes on selecting bone in edit mode. #51923