Reverting the file while Cycles synchronizes crashes with the new depsgraph #51944

Closed
opened 2017-07-01 05:20:34 +02:00 by Lukas Stockner · 12 comments
Member

The title pretty much describes the problem:

  • Start Blender with the new depsgraph enabled
  • Open a file (that I can't share unfortunately, I'll try to reproduce in an open file)
  • Get the warning about disabled autorun
  • Start a render, Cycles will synchronize
  • While it does so, click the "reload trusted" button
  • Blender will crash

This is not a regression, I can also reproduce it in 2.78c. From what I can tell, the problem occurs when Cycles calls RE_engine_frame_set -> BKE_scene_update_for_newframe_ex -> DAG_ids_clear_recalc, which will then use the bmain (and therefore the scene) that was loaded during reverting instead of the one for which the render was started.

Specifically, in source/blender/blenkernel/intern/depsgraph.c:2910 scene->theDag is NULL and scene was allocated from the call to BKE_blendfile_read that came from the reverting.

I know that not having a file to reproduce isn't great, but I guess that reporting it as soon as possible is more important.

I suppose a reasonable fix would be to cancel all jobs when reverting, but maybe there's better approach, so I created this report to be safe.

The title pretty much describes the problem: - Start Blender with the new depsgraph enabled - Open a file (that I can't share unfortunately, I'll try to reproduce in an open file) - Get the warning about disabled autorun - Start a render, Cycles will synchronize - While it does so, click the "reload trusted" button - Blender will crash This is not a regression, I can also reproduce it in 2.78c. From what I can tell, the problem occurs when Cycles calls RE_engine_frame_set -> BKE_scene_update_for_newframe_ex -> DAG_ids_clear_recalc, which will then use the bmain (and therefore the scene) that was loaded during reverting instead of the one for which the render was started. Specifically, in source/blender/blenkernel/intern/depsgraph.c:2910 scene->theDag is NULL and scene was allocated from the call to BKE_blendfile_read that came from the reverting. I know that not having a file to reproduce isn't great, but I guess that reporting it as soon as possible is more important. I suppose a reasonable fix would be to cancel all jobs when reverting, but maybe there's better approach, so I created this report to be safe.
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'
Author
Member

Added subscriber: @LukasStockner

Added subscriber: @LukasStockner
Author
Member

Added subscriber: @Sergey

Added subscriber: @Sergey

Added subscriber: @VukGardasevic

Added subscriber: @VukGardasevic

@LukasStockner blender will crash when reloading scripts (F8) too while the render preview is active with the old depsgraph.

@LukasStockner blender will crash when reloading scripts (F8) too while the render preview is active with the old depsgraph.

Added subscriber: @bliblubli

Added subscriber: @bliblubli

At least on windows, there is no crash. I tested on latest buildbot, VS2015, on victor scene, reverted during synchronization with new depsgraph ('using new depsgraph' was printed in console, so there is no typing error on my side). Maybe it's Linux-specific or random due to some threading issues?

At least on windows, there is no crash. I tested on latest buildbot, VS2015, on victor scene, reverted during synchronization with new depsgraph ('using new depsgraph' was printed in console, so there is no typing error on my side). Maybe it's Linux-specific or random due to some threading issues?

Added subscriber: @mont29

Added subscriber: @mont29

We need a file to reproduce that…

We need a file to reproduce that…

Added subscriber: @fablefox

Added subscriber: @fablefox

No reply over a week for a file to recreate crash. Closing for now.

No reply over a week for a file to recreate crash. Closing for now.

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Fable Fox self-assigned this 2017-07-12 11:25:47 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#51944
No description provided.