Event pass through for manipulators modal() callbacks. #52499

Closed
opened 2017-08-23 04:29:17 +02:00 by stephen leger · 5 comments
Member

Hi,
After IRC talk about modals, i try to expose the issue here for the records.

Actually,
some addons use transform.translate as snap provider.
There is also an attempt to allow on screen navigation while running transform modals.

Current modals does not allow events to bubble up in the stack
make it impossible to handle user interaction in caller when modals are stacked.

Archipack modal stack sample:


Manipulate modal
draw manipulators
___________________

User hover and drag an arrow handle


transform.translate
issue: events are stuck here
manipulate can't properly
handle interaction
hackaround :
callback in a draw handler
______________________________

Proposed solutions:

1 Being able to enforce PASS_THROUGH on transform.translate (any modal)
instead of RUNNING_MODAL.
Keep returning FINISHED as it.
So calling operator may properly handle events too.

This may also enable a native way to navigate on screen
even with modal running.

2 being able to add a handler like the draw one

with a callback done when modal get an event
Hi, After IRC talk about modals, i try to expose the issue here for the records. Actually, some addons use transform.translate as snap provider. There is also an attempt to allow on screen navigation while running transform modals. Current modals does not allow events to bubble up in the stack make it impossible to handle user interaction in caller when modals are stacked. Archipack modal stack sample: ___________________ | | | -- | | Manipulate modal | | draw manipulators | |___________________ | User hover and drag an arrow handle ______________________________ | | | -- | | transform.translate | | issue: events are stuck here| | manipulate can't properly | | handle interaction | | | | hackaround : | | callback in a draw handler | |______________________________| ``` ``` Proposed solutions: 1 Being able to enforce PASS_THROUGH on transform.translate (any modal) instead of RUNNING_MODAL. Keep returning FINISHED as it. So calling operator may properly handle events too. This may also enable a native way to navigate on screen even with modal running. 2 being able to add a handler like the draw one ``` with a callback done when modal get an event
Campbell Barton was assigned by stephen leger 2017-08-23 04:29:17 +02:00
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'
Author
Member

Added subscriber: @StephenLeger

Added subscriber: @StephenLeger
Campbell Barton changed title from Bubble up events on stacked modal operators. to Event pass through for manipulators modal() callbacks. 2017-08-23 13:08:12 +02:00

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

@StephenLeger - committed return {'RUNNING_MODAL', 'PASS_THROUGH'} for events you want to pass through to other operators, while keeping your manipulator running.

@StephenLeger - committed `return {'RUNNING_MODAL', 'PASS_THROUGH'}` for events you want to pass through to other operators, while keeping your manipulator running.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#52499
No description provided.