Motion Trails addon disables undo when it has an error #52524

Closed
opened 2017-08-24 12:54:06 +02:00 by ¿? · 6 comments

addons_contrib\ animation_motion_trail.py
In line 297-298

context.user_preferences.edit.use_global_undo = False```
It logs the undo option from userprefs, then disables it. 

**Problem:** when the addon runs into an error (popup message) sometimes, it does not re-enable Global Undo, so if someone is unaware that this even disables it, they wouldn't be able to undo and wouldn't know why.

The addon is *broken/not in development* and while it works correctly in some situations, it has a tendency to run into errors, stopping  it's use where you have to disable it then re-enable to start using again. 

***My* Solution:** comment one or both of the lines out to stop the addon from disabling Global Undo (until someone decides to start working on it again).
addons_contrib\ animation_motion_trail.py In line 297-298 ```global_undo = context.user_preferences.edit.use_global_undo context.user_preferences.edit.use_global_undo = False``` It logs the undo option from userprefs, then disables it. **Problem:** when the addon runs into an error (popup message) sometimes, it does not re-enable Global Undo, so if someone is unaware that this even disables it, they wouldn't be able to undo and wouldn't know why. The addon is *broken/not in development* and while it works correctly in some situations, it has a tendency to run into errors, stopping it's use where you have to disable it then re-enable to start using again. ***My* Solution:** comment one or both of the lines out to stop the addon from disabling Global Undo (until someone decides to start working on it again).
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @Ebone

Added subscriber: @Ebone

This issue was referenced by blender/blender-addons-contrib@fbae0b16d4

This issue was referenced by blender/blender-addons-contrib@fbae0b16d4ef65a987c8ac287959a6bc020ba84b

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Added subscriber: @VukGardasevic

Added subscriber: @VukGardasevic

The crash in the function setting the undo state should now recover it if it crashes.

The crash in the function setting the undo state should now recover it if it crashes.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#52524
No description provided.