Depsgraph ownership: scene layer inconsistencies #52765

New Issue

Dalai Felinto · 2017-09-15T16:10:27+02:00

Dalai Felinto commented

2017-09-15 16:10:27 +02:00

Short description of error
Right some parts of Blender follow the workspace render layer, while others follow the scene active render layer.

Detailed description of error
We should create depsgraph based on per-scene_layer basis, meaning, we should replace build_scene with build_scene_layer. But it's not trivial for until we change ownership of depsgraph to be per-scene_layer (with some workspace or window involved into the key) or something like this.

**Short description of error** Right some parts of Blender follow the workspace render layer, while others follow the scene active render layer. **Detailed description of error** We should create depsgraph based on per-scene_layer basis, meaning, we should replace *build_scene* with *build_scene_layer*. But it's not trivial for until we change ownership of depsgraph to be per-scene_layer (with some workspace or window involved into the key) or something like this.

Dalai Felinto commented

2017-09-15 16:10:27 +02:00

Changed status to: 'Open'

Dalai Felinto commented

2017-09-15 16:10:27 +02:00

Added subscriber: @dfelinto

Sergey Sharybin was assigned by Dalai Felinto

2017-09-15 16:11:33 +02:00

Dalai Felinto commented

2017-09-15 16:11:33 +02:00

Added subscriber: @Sergey

Dalai Felinto commented

2017-09-15 16:11:33 +02:00

Suggested workaround by @Sergey:

You might add temporary workaround and rebuild depsgraph when one changes scene layer, but that's not how final design should work.

Perhaps if you add some api to get depsgraph for a given context or layer it will all be localized. Something like: if requested scene layer != requested scene layer then rebuild depsgraph. Otherwise return scene->depsgraph. Later in it'll be one place where we would need to replace that with real hash lookup or so.

If you go that route, please make it so argument list is complete from the log term point of view. As in, so we wouldn't need to go over everywhere changing arguments we pass there.

Suggested workaround by @Sergey: > You might add temporary workaround and rebuild depsgraph when one changes scene layer, but that's not how final design should work. > > Perhaps if you add some api to get depsgraph for a given context or layer it will all be localized. Something like: if requested scene layer != requested scene layer then rebuild depsgraph. Otherwise return scene->depsgraph. Later in it'll be one place where we would need to replace that with real hash lookup or so. > > If you go that route, please make it so argument list is complete from the log term point of view. As in, so we wouldn't need to go over everywhere changing arguments we pass there.

Dalai Felinto commented

2017-09-15 16:37:14 +02:00

Some extra directions for depsgraph ownership:

workspace + render layer defines a despsgraph.
technically it is workspace + scene + render layer
when workspace has "use_scene_settings" on it uses the render layer from the scene, but since it's a settings in the workspace level, it is still one depsgraph for this workspace.
Render (F12) defines a depsgraph
Local view (/) will define a depsgraph, or re-use the workspace depsgraph with some bitflag visibility system (like we had in 2.7)

Some extra directions for depsgraph ownership: * `workspace + render layer` defines a despsgraph. * technically it is workspace + scene + render layer * when workspace has "use_scene_settings" on it uses the render layer from the scene, but since it's a settings in the workspace level, it is still one depsgraph for this workspace. * Render (F12) defines a depsgraph * Local view (/) will define a depsgraph, or re-use the workspace depsgraph with some bitflag visibility system (like we had in 2.7)

Jonathan Williamson commented

2017-10-31 16:44:15 +01:00

Added subscriber: @JonathanWilliamson