Multiple CNTRL Z replaces properties in driver #52965

Open
opened 2017-09-30 23:37:58 +02:00 by Serge Lyatin · 6 comments

System Information
Win7 64bit

Blender Version
Broken: 2.79

Short description of error
I was copying drivers from one object to another and hiding (H) those with already pasted driver. At some point I wanted to unhide previous object, so used undo instead of ALT H to bring back only one object. After object was revealed, I do not re-copy driver just paste what was already in memory. I make three undo's (just the step before copying driver), so I didn't expect this will corrupt driver's data. Would be better to make "paste" not happen, rather than changing it.

Original driver
untitled.png
Pasted driver after some undo's
untitled1.png

Exact steps for others to reproduce the error

  1. Copy driver from texture slot of left cube
  2. Hide left cube in viewport
  3. Paste driver in texture slot of right cube
  4. Pres CTRL Z three times until left cube will appear back
  5. Then repeat pasting driver from stage 3 -> driver's properties have been replaced by another
    Paste_driver.blend
**System Information** Win7 64bit **Blender Version** Broken: 2.79 **Short description of error** I was copying drivers from one object to another and hiding (H) those with already pasted driver. At some point I wanted to unhide previous object, so used undo instead of ALT H to bring back only one object. After object was revealed, I do not re-copy driver just paste what was already in memory. I make three undo's (just the step before copying driver), so I didn't expect this will corrupt driver's data. Would be better to make "paste" not happen, rather than changing it. *Original driver* ![untitled.png](https://archive.blender.org/developer/F919244/untitled.png) *Pasted driver after some undo's* ![untitled1.png](https://archive.blender.org/developer/F919245/untitled1.png) **Exact steps for others to reproduce the error** 1. Copy driver from texture slot of left cube 2. Hide left cube in viewport 3. Paste driver in texture slot of right cube 4. Pres CTRL Z three times until left cube will appear back 5. Then repeat pasting driver from stage 3 -> driver's properties have been replaced by another [Paste_driver.blend](https://archive.blender.org/developer/F919248/Paste_driver.blend)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @SergeL

Added subscriber: @SergeL
Member

Added subscriber: @JoshuaLeung

Added subscriber: @JoshuaLeung
Joshua Leung self-assigned this 2017-10-01 05:59:02 +02:00
Member

I've been suspecting that something like this may happen at some point (thought it turns out I was looking in the wrong place last time I checked, when investigating some of the Grease Pencil copy-paste crashes).

The problem is that Copy-Paste buffer stores pointers to the "old" (i.e. pre-undo) datablocks, with these pointers not getting updated to the new copies of those datablocks after each undo/redo step (i.e. since undo steps effectively reload the file from memory, invalidiating all old pointers). Currently there aren't any hooks in the undo code to perform this sort of remapping for copy/paste buffers.

I've been suspecting that something like this may happen at some point (thought it turns out I was looking in the wrong place last time I checked, when investigating some of the Grease Pencil copy-paste crashes). The problem is that Copy-Paste buffer stores pointers to the "old" (i.e. pre-undo) datablocks, with these pointers not getting updated to the new copies of those datablocks after each undo/redo step (i.e. since undo steps effectively reload the file from memory, invalidiating all old pointers). Currently there aren't any hooks in the undo code to perform this sort of remapping for copy/paste buffers.
Joshua Leung was unassigned by Dalai Felinto 2019-12-23 16:36:29 +01:00

Added subscriber: @dr.sybren

Added subscriber: @dr.sybren

Marking as Known Issue, since copy/pasting driver variables across undo steps apparently isn't supported at the moment. This should be fixed at some point, though.

Marking as Known Issue, since copy/pasting driver variables across undo steps apparently isn't supported at the moment. This should be fixed at some point, though.
Philipp Oeser removed the
Interest
Animation & Rigging
label 2023-02-09 14:36:44 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#52965
No description provided.