Blender 2.8: workspace list from user configuration is empty #53008

New Issue

Julian Eisel · 2017-10-05T18:34:47+02:00

Julian Eisel commented

2017-10-05 18:34:47 +02:00

Short description of error
List of workspaces in user configuration sometimes is empty. Should never be the case.
If no workspaces.blend is found in the user configuration itself (which must never have 0 workspaces), the bundled default one is used as fallback (should be in [build_dir]/[release_dir]/datafiles/).
The user who reported this did have the bundled workspace.blend in the right place, so this is not the cause.

Exact steps for others to reproduce the error

Launch Blender from command line
Press "+" button to add a new workspace
If appearing menu only contains "Duplicate Current", there's the bug.

Mainly leaving this here for myself.

**Short description of error** List of workspaces in user configuration sometimes is empty. Should never be the case. If no `workspaces.blend` is found in the user configuration itself (which must never have 0 workspaces), the bundled default one is used as fallback (should be in `[build_dir]/[release_dir]/datafiles/`). The user who reported this did have the bundled `workspace.blend` in the right place, so this is not the cause. **Exact steps for others to reproduce the error** * Launch Blender from command line * Press "+" button to add a new workspace * If appearing menu only contains "Duplicate Current", there's the bug. ---- Mainly leaving this here for myself.

Julian Eisel commented

2017-10-05 18:34:47 +02:00

Changed status to: 'Open'

Julian Eisel commented

2017-10-05 18:34:47 +02:00

Added subscriber: @JulianEisel

Julian Eisel self-assigned this 2017-10-05 18:34:57 +02:00

Julian Eisel commented

2017-10-05 18:37:22 +02:00

Added subscriber: @xan2622

Julian Eisel commented

2017-10-23 01:32:15 +02:00

Got it! Happens all the time when launching Blender from command line here. Still need to investigate but now I know how to recreate at least :)

Julian Eisel commented

2017-11-04 02:39:22 +01:00

Added subscribers: @Sergey, @ideasman42

Julian Eisel commented

2017-11-04 02:39:22 +01:00

So this only happens for dev builds executed from the build directory. It's caused by this loading a different release directory path for dev builds https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/appdir.c;33b5e8daff2cfe269bdb527cf0de6dd083b01daf$323-331.

I'd suggest this fix P554: Potential fix for #53008

diff --git a/source/creator/CMakeLists.txt b/source/creator/CMakeLists.txt
index 78257cb7d1e..dbcc2e06022 100644
--- a/source/creator/CMakeLists.txt
+++ b/source/creator/CMakeLists.txt
@@ -412,11 +412,17 @@ if(WITH_OPENCOLORIO)
        )
 endif()
 
-# Add default workspaces.blend to build (under [version]/datafiles
+# Add default workspaces.blend to build datafiles. Copy to two locations, so it works
+# for dev & regular builds (see weird dev-build exception in get_path_system()).
 install(
        FILES ${CMAKE_SOURCE_DIR}/release/datafiles/workspaces.blend
        DESTINATION ${TARGETDIR_VER}/datafiles
 )
+configure_file(
+       ${CMAKE_SOURCE_DIR}/release/datafiles/workspaces.blend
+       ${CMAKE_BINARY_DIR}/release/datafiles/workspaces.blend
+       COPYONLY
+)
 
 # helpful tip when using make
 if("${CMAKE_GENERATOR}" MATCHES ".*Makefiles.*")

The ugly thing is it actually copies the default workspaces.blend to two directories:

Once during CMake configuration. Copied into [build_dir]/release/datafiles.
Once during make install. Copied into [install_dir]/[version]/datafiles.
That said it should work fine with all cases.

Alternatively we could remove mentioned lines in appdir.c, although I don't know what it's currently used for. @ideasman42/@Sergey any opinion on that matter?

So this only happens for dev builds executed from the build directory. It's caused by this loading a different release directory path for dev builds https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/appdir.c;33b5e8daff2cfe269bdb527cf0de6dd083b01daf$323-331. I'd suggest this fix [P554: Potential fix for #53008](https://archive.blender.org/developer/P554.txt) ``` diff --git a/source/creator/CMakeLists.txt b/source/creator/CMakeLists.txt index 78257cb7d1e..dbcc2e06022 100644 --- a/source/creator/CMakeLists.txt +++ b/source/creator/CMakeLists.txt @@ -412,11 +412,17 @@ if(WITH_OPENCOLORIO) ) endif() -# Add default workspaces.blend to build (under [version]/datafiles +# Add default workspaces.blend to build datafiles. Copy to two locations, so it works +# for dev & regular builds (see weird dev-build exception in get_path_system()). install( FILES ${CMAKE_SOURCE_DIR}/release/datafiles/workspaces.blend DESTINATION ${TARGETDIR_VER}/datafiles ) +configure_file( + ${CMAKE_SOURCE_DIR}/release/datafiles/workspaces.blend + ${CMAKE_BINARY_DIR}/release/datafiles/workspaces.blend + COPYONLY +) # helpful tip when using make if("${CMAKE_GENERATOR}" MATCHES ".*Makefiles.*") ``` The ugly thing is it actually copies the default workspaces.blend to two directories: * Once during CMake configuration. Copied into `[build_dir]/release/datafiles`. * Once during `make install`. Copied into `[install_dir]/[version]/datafiles`. That said it should work fine with all cases. Alternatively we could remove mentioned lines in `appdir.c`, although I don't know what it's currently used for. @ideasman42/@Sergey any opinion on that matter?

Campbell Barton commented

2017-11-19 10:59:21 +01:00

I think it's simplest to do datatoc as startup.blend unless there is a good reason to make this work differently.

AFAICS no big changes are needed for this, just follow existing conventions.

Update, swapping CWD & EXE dirs is far simpler!

I think it's simplest to do datatoc as startup.blend unless there is a good reason to make this work differently. AFAICS no big changes are needed for this, just follow existing conventions. ---- Update, swapping CWD & EXE dirs is far simpler!

blender-admin commented

2017-11-19 12:24:12 +01:00

This issue was referenced by 3133d2d58c

This issue was referenced by 3133d2d58c391544a48342860120336e2a0f944e

Julian Eisel commented

2017-11-19 13:15:28 +01:00

Changed status from 'Open' to: 'Resolved'

Julian Eisel closed this issue

2017-11-19 13:15:28 +01:00

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#53008

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blender 2.8: workspace list from user configuration is empty #53008