Armature modifier on hidden objects #53251
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#53251
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Win 7, GeForce 970
Blender Version
Broken: 2.78c
Armature modifiers are still being calculated for hidden objects, resulting in degraded performance for animation previews of an armature driving multiple objects, even when not all modified objects are visible.
Exact steps for others to reproduce the error
With attached file, preview animation, and observe playback rate. Remove or disable armature modifiers on hidden clothing or hair items (under respective dummy holders): alternatively, delete hidden objects. Preview animation and observe playback rate again. On my system, playback rate increased from 5fps to 30fps
RPG_Sprite_sml.blend
Changed status to: 'Open'
Added subscriber: @cmallen-3
Added subscriber: @FloridaJo
Played at about 5 fps,
then deleted Dummy Hair and Dummy Clothing, no difference in playback.
That was with 2.79
The dummy objects aren't rigged. It's all the child objects parented to them that have armature modifiers applied. Were those deleted as well, or just the dummy objects?
Just dummy objects. That's what I thought you meant by "alternatively, delete hidden objects. "
Added subscriber: @lichtwerk
While it is very well possible that hidden objects need to be evaluated (think of something shrinkwrapped to a hidden deformed object - you would want the deformations to be evaluated), it doesnt have to be so (agree, it would make sense to skip evaluation in that case).
I set up a little testcase with 50 armature-deformed grids (making sure none of them is a dependency elsewhere) and get this:
Makes no difference if I use old or new dependency graph.
Note that evaluation gets properly skipped if stuff is on a hidden layer.
To me it seems there is really room for optimization here, but needs further investigation in the dependency graph
Added subscriber: @Sergey
At a quick glance at the code, dependency graph is only aware of layers, not object visibilities at all.
This is not limited to the Armature modifier, seems all modifiers evaluated (e.g. on frame change)
(Above difference in fps between visible vs. hidden is probably drawing code etc, not modifier evaluation).
So in that case, I would think this is a (somewhat known) limitation to the depsgraph?
In 2.8, object visibilities are moved to collections to my knowledge, not sure how much that will change things.
I would still suspect modifiers to be evaluated in a hidden collections on a layer, but maybe @Sergey can share his wisdom?
Is there something about evaluation-'untag' [in case its hidden and nothing else depends on it] up your sleeve?
Can we archive this as "by design" (and not a bug)?
Changed status from 'Open' to: 'Archived'
Depsgraph indeed only takes layers into account. This way it's cheap to see if some object from hidden layer affects something currently visible. In Blender 2.8 we are switching to collections visibility instead of object visibility. This part is still being worked on, so need some work to make depsgraph aware of that once rest of design is locked down.
So thanks for the report, but it's not a bug.