Page MenuHome

Outliner: Crash when deleting collections
Closed, ResolvedPublic

Description

SysInfo: Windows 10, GTX 1070
branch: blender2.8

When adding a collection to a ViewLayer, the collection shows up as part of the "Master Collection" and also at the root level in the outliner. If you shift+select the collection both at the root-level and in the "Master Collection" hierarchy, then click delete, Blender crashes.

Steps to reproduce:

  1. Open Blender 2.8 w/ the default startup file loaded.
  2. Change the active view layer to "Viewport" since "RenderLayer" doesn't have the master collection showing in outliner...
  3. Add a new collection to the view layer. NOTE: you should see the "New Collection" show up at the *root* level in the outliner (same level as "Master Collection") and also as a child of the "Master Collection" hierarchy.
  4. Shift+select to select the "New Collection" in both places it is available in the outliner (at root level and also within the "Master Collection" hierarchy.
  5. Click the 'x' button to delete the collection w/ it selected in both places and blender should crash.

*Note that this can also be accomplished by simply linking in the same collection multiple times in the same view-layer, shift+selecting the same collection at least twice, and then trying to delete it in the outliner.

Related Objects

Event Timeline

Danrae Pray (spockTheGray) renamed this task from Crash when deleting collections to OUTLINER: Crash when deleting collections.Nov 29 2017, 3:26 AM
Danrae Pray (spockTheGray) created this task.

@Julian Eisel (Severin) @Dalai Felinto (dfelinto) hey guys :) tagged you both in this one b.c. it's at a bug at a minimum, but not sure if there is some design work needed here too.

What "should" be the expected behavior when the user selects the same collection twice in the outliner and tries to delete it? Right now we try to delete the same collection twice in this case and that is easy to fix if we actually do want it to delete the collection... but I was wondering if we should even show the same collection twice in the outliner in the first place?

If so, I'm just curious (for my own understanding) what is the value of this for the end-user (maybe just a simple example use-case could clarify)?

Danrae Pray (spockTheGray) renamed this task from OUTLINER: Crash when deleting collections to Outliner: Crash when deleting collections.Nov 29 2017, 4:06 AM
Danrae Pray (spockTheGray) updated the task description. (Show Details)

The other thing that confuses me is that we can link the *same* collection multiple times in the same view-layer. This is another way this bug can be triggered, but again, does the user really benefit from linking in the same collection multiple times in a particular view-layer?

Dropped a diff here to fix the crash - just let me know if it needs more work. Cheers o/

Dalai Felinto (dfelinto) lowered the priority of this task from 90 to 50.Dec 1 2017, 7:22 PM