Improve Add Advanced Objects -> Easy Lattice #53477

New Issue

Jesse Yurkovich · 2017-12-05T23:10:04+01:00

Jesse Yurkovich commented

2017-12-05 23:10:04 +01:00

The attached patch does the following:
- Removes broken/unused code that would attempt to delete already added easy-lattices
- Allows the creation of multiple easy-lattices in the same scene AND for the same object (incl. support for multiple vertex groups)
- Add scale factor so the user can create lattices smaller/larger than the target mesh
- Add Catmull-Rom option
- Code style (variable naming, UI naming, return values, etc.)

The code that attempted to delete lattices added by the add-on did not really work, especially in the cases where the user has changed the name of the modifier etc. Additionally, all that code prevented the usage of the add-on more than once in a given scene and more than once on a given object. These changes addresses those problems and cleans up along the way.

It also adds another property, the scale factor, allowing the user to create a lattice that is smaller or larger than the target object.

Note: I couldn't find a way to actually create a git PR here. Is attaching a patch file the preferred mechanism?

easylattice.patch

The attached patch does the following: - Removes broken/unused code that would attempt to delete already added easy-lattices - Allows the creation of multiple easy-lattices in the same scene AND for the same object (incl. support for multiple vertex groups) - Add scale factor so the user can create lattices smaller/larger than the target mesh - Add Catmull-Rom option - Code style (variable naming, UI naming, return values, etc.) The code that attempted to delete lattices added by the add-on did not really work, especially in the cases where the user has changed the name of the modifier etc. Additionally, all that code prevented the usage of the add-on more than once in a given scene and more than once on a given object. These changes addresses those problems and cleans up along the way. It also adds another property, the scale factor, allowing the user to create a lattice that is smaller or larger than the target object. Note: I couldn't find a way to actually create a git PR here. Is attaching a patch file the preferred mechanism? [easylattice.patch](https://archive.blender.org/developer/F1311663/easylattice.patch)

Jesse Yurkovich commented

2017-12-05 23:10:04 +01:00

Changed status to: 'Open'

Jesse Yurkovich commented

2017-12-05 23:10:04 +01:00

Added subscriber: @deadpin

Ray molenkamp commented

2017-12-05 23:18:43 +01:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2017-12-05 23:18:43 +01:00

the preferred way is to post the diff here, https://developer.blender.org/differential/diff/create/ so we can easily see the changes.

Jesse Yurkovich commented

2017-12-05 23:39:07 +01:00

Added a diff here: https://developer.blender.org/differential/diff/9645/

Is that fine or should we close this one and go through the above process to also create the revision task along with it?

Added a diff here: https://developer.blender.org/differential/diff/9645/ Is that fine or should we close this one and go through the above process to also create the revision task along with it?

Vuk Gardašević commented

2017-12-06 04:56:28 +01:00

Added subscriber: @VukGardasevic