Outliner: misalignment of icons and lines #53831

New Issue

Pablo Vazquez · 2018-01-18T21:01:25+01:00

Pablo Vazquez commented

2018-01-18 21:01:25 +01:00

System Information
Ubuntu 17.04, NVIDIA GTX 980

Blender Version
Broken: 2.80.3 (but it has been broken since 2.80)
Worked: 2.79

Short description of error
The collapse icon and horizontal/vertical lines are shifted a few pixels. The collapse icon is shifted to the right, while the lines are shifted to the left.
Most noticeable with long trees, and with the UI at 2x.

Exact steps for others to reproduce the error
Open the Outliner in All Scenes mode (to easily compare against 2.79). Setting the UI at 2x makes it easier to see.

Note: I know we shouldn't report bugs in 2.8 yet but @dfelinto mentioned it's better to keep track of this.

**System Information** Ubuntu 17.04, NVIDIA GTX 980 **Blender Version** Broken: 2.80.3 (but it has been broken since 2.80) Worked: 2.79 **Short description of error** The collapse icon and horizontal/vertical lines are shifted a few pixels. The collapse icon is shifted to the right, while the lines are shifted to the left. Most noticeable with long trees, and with the UI at 2x. ![image.png](https://archive.blender.org/developer/F1882290/image.png) **Exact steps for others to reproduce the error** Open the Outliner in All Scenes mode (to easily compare against 2.79). Setting the UI at 2x makes it easier to see. Note: I know we shouldn't report bugs in 2.8 yet but @dfelinto mentioned it's better to keep track of this.

Pablo Vazquez commented

2018-01-18 21:01:25 +01:00

Added subscribers: @dfelinto, @pablovazquez

Philippe Schmid was assigned by Dalai Felinto

2018-01-18 21:28:44 +01:00

Philippe Schmid commented

2018-01-19 00:09:56 +01:00

I fixed the vertical line alignment. The patch for the (+) and (-) buttons comes soon.

What caused the default startx value to become outdated?

vertical_line_placement_patch_01.patch

I fixed the vertical line alignment. The patch for the (+) and (-) buttons comes soon. What caused the default startx value to become outdated? [vertical_line_placement_patch_01.patch](https://archive.blender.org/developer/F1884435/vertical_line_placement_patch_01.patch)

Pablo Vazquez commented

2018-01-19 00:16:25 +01:00

In #53831#480070, @Quetzal wrote:
I fixed the vertical line alignment. The patch for the (+) and (-) buttons comes soon.

Yay you found it!

What caused the default startx value to become outdated?

I'm not sure what could have caused it, but it's only in 2.8 branch, master is fine. The only thing I could think of is the OpenGL refactor. These lines are weird anyway. Always the same width, even when changing the UI size or when line width is set to 'thick' in the User Preferences > Interface.

> In #53831#480070, @Quetzal wrote: > I fixed the vertical line alignment. The patch for the (+) and (-) buttons comes soon. Yay you found it! > What caused the default startx value to become outdated? I'm not sure what could have caused it, but it's only in 2.8 branch, master is fine. The only thing I could think of is the OpenGL refactor. These lines are weird anyway. Always the same width, even when changing the UI size or when line width is set to 'thick' in the User Preferences > Interface.

Philippe Schmid commented

2018-01-19 09:02:17 +01:00

Ok, thanks!

This would fix the expand buttons being misplaced. However, it is removing a condition and I couldn't find what it is useful for (except doing this … wait. Is the shift intentional?).
So if it isn't, there's my patch ☺ But I just realized that it might be a wanted behaviour. (maybe adapt the comment to make it more explicit?)

vertical_line_placement_expand_icons_patch_01.patch

Ok, thanks! This would fix the expand buttons being misplaced. However, it is removing a condition and I couldn't find what it is useful for (except doing this … wait. Is the shift intentional?). So if it isn't, there's my patch ☺ But I just realized that it might be a wanted behaviour. (maybe adapt the comment to make it more explicit?) [vertical_line_placement_expand_icons_patch_01.patch](https://archive.blender.org/developer/F1890408/vertical_line_placement_expand_icons_patch_01.patch)

Dalai Felinto commented

2018-01-19 15:36:06 +01:00

@Quetzal this is still broken when upscaling the UI:
User Preferences > Interface > Display > Scale [change it to 2.0]

@Quetzal this is still broken when upscaling the UI: User Preferences > Interface > Display > Scale [change it to 2.0]

Dalai Felinto commented

2018-01-19 15:38:47 +01:00

Also a bit skeptical in the overall fix. Both patches are changing code that didn't change since master.

Philippe Schmid commented

2018-01-20 23:20:56 +01:00

I found a solution to the scale problem. Instead of a value of 9, it's half a x ui unit. Since it's quite the same, it felt like the same solution, but scale proof. (so no real progress in terms of the nature of the fix)

I thus digged more into it, and found that in master, the value is set to half a x ui unit - 1, and that the condition changing the expand icon's position has been removed too. So I started to make some research about when the default value could have been reset to the old '6' value, and the condition reintroduced (since it (the commit fixing both issues) was in the 2.8 log).

Actually, the merge that would have ported this change from master to 2.8 has discarded these two fixes.

This is the differential with the fixes reintroduced, concerning those graphical issues:

D3014

I got more into the details there.

I found a solution to the scale problem. Instead of a value of 9, it's half a x ui unit. Since it's quite the same, it felt like the same solution, but scale proof. (so no real progress in terms of the nature of the fix) I thus digged more into it, and found that in master, the value is set to half a x ui unit - 1, and that the condition changing the expand icon's position has been removed too. So I started to make some research about when the default value could have been reset to the old '6' value, and the condition reintroduced (since it (the commit fixing both issues) was in the 2.8 log). Actually, the merge that would have ported this change from master to 2.8 has discarded these two fixes. This is the differential with the fixes reintroduced, concerning those graphical issues: [D3014](https://archive.blender.org/developer/D3014) I got more into the details there.

Dalai Felinto commented

2018-01-22 15:11:56 +01:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2018-01-22 15:11:56 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Outliner: misalignment of icons and lines #53831