Preset name parsing issue in Property Editor --> Camera Tab --> Safe Areas Panel --> Camera Presets List #54029

New Issue

zdy · 2018-02-08T15:39:26+01:00

zdy commented

2018-02-08 15:39:26 +01:00

System Information
windows 10 pro and Quadro M4000M

Blender Version
Blender 2.79/2.78

Short description of error

Option Typo in Property Editor --> Camera Tab --> Safe Areas Panel --> Camera Presets List:

Item 3 in 16:9 should be 4:3 in 16:9.

Exact steps for others to reproduce the error
UI typo, no need of steps to reproduce it.

**System Information** windows 10 pro and Quadro M4000M **Blender Version** Blender 2.79/2.78 **Short description of error** Option Typo in `Property Editor --> Camera Tab --> Safe Areas Panel --> Camera Presets List`: Item `3 in 16:9` should be `4:3 in 16:9`. ![Snipaste_2018-02-09_15-07-44.png](https://archive.blender.org/developer/F2196446/Snipaste_2018-02-09_15-07-44.png) **Exact steps for others to reproduce the error** UI typo, no need of steps to reproduce it.

zdy commented

2018-02-08 15:39:26 +01:00

Added subscriber: @nge

Campbell Barton commented

2018-02-09 07:32:20 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2018-02-09 07:32:20 +01:00

Please state full name of menu item, and full name you propose.

zdy commented

2018-02-09 08:12:45 +01:00

Sorry, I should've pasted the screenshot.
Image Added!

Sorry, I should've pasted the screenshot. Image Added!

Campbell Barton commented

2018-02-09 09:07:05 +01:00

Seems this is a drawing glitch, it displays correctly here.

Pablo Vazquez commented

2018-02-09 11:52:56 +01:00

Added subscriber: @pablovazquez

Pablo Vazquez commented

2018-02-09 11:52:56 +01:00

Must be a glitch, it displays just fine here as well.

Tested in different interface sizes in 2.79 and 2.80.

Must be a glitch, it displays just fine here as well. Tested in different interface sizes in 2.79 and 2.80.

xueke pei commented

2018-02-09 12:15:14 +01:00

Added subscriber: @xuekepei

xueke pei commented

2018-02-09 12:15:14 +01:00

in non-english system this will display like this.

![image.png](https://archive.blender.org/developer/F2198117/image.png) in non-english system this will display like this.

Leroy commented

2018-02-09 12:26:00 +01:00

Added subscriber: @Leroy-Xie

Leroy commented

2018-02-09 12:26:00 +01:00

windows 10, 2.79

![image.png](https://archive.blender.org/developer/F2198209/image.png) windows 10, 2.79

zdy commented

2018-02-09 12:40:55 +01:00

I've confirmed this with several of my friends, with windows 7 and windows 10 platform, English and non-English version. It still display with 4: missing.

So, I guess it is a platform-related issue, and should be solved.

I've confirmed this with several of my friends, with windows 7 and windows 10 platform, English and non-English version. It still display with `4:` missing. So, I guess it is a platform-related issue, and should be solved.

Ray molenkamp commented

2018-02-09 16:24:40 +01:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2018-02-09 16:24:40 +01:00

I can confirm on windows

Vuk Gardašević commented

2018-02-09 16:51:51 +01:00

Added subscriber: @VukGardasevic

Vuk Gardašević commented

2018-02-09 16:51:51 +01:00

Also confirming on Windows.
Seems that the patterns of some single digit number_colon_ gets stripped completely. This doesn't occur if there are two digits before the "colon" pattern.

Note: seems that the Camera Presets (in scripts\presets\camera\)uses the digit__colon (the _ are doubled) pattern name. If this is an parsing limitation issue maybe should be added as a note somewhere.

Also confirming on Windows. Seems that the patterns of some **single digit number_colon_** gets stripped completely. This doesn't occur if there are two digits before the "_colon_" pattern. Note: seems that the Camera Presets (in `scripts\presets\camera\`)uses the **digit__colon** (the _ are doubled) pattern name. If this is an parsing limitation issue maybe should be added as a note somewhere.

Vuk Gardašević changed title from ~~Option Typo in `Property Editor --> Camera Tab --> Safe Areas Panel --> Camera Presets List`~~ to Preset name parsing issue in `Property Editor --> Camera Tab --> Safe Areas Panel --> Camera Presets List`

2018-02-09 16:53:28 +01:00

Vuk Gardašević commented

2018-02-09 18:18:55 +01:00

Issue is from this code in bpy.types.py :

            props = layout.operator(
                operator,
                text=display_name(filepath) if display_name else bpy.path.display_name(f),
                translate=False,
            )

Seems that the bpy.path.display_name(f) truncates the f variable like in the described issue. Since f is the file name (2_colon_4_something.py), it shows up like it does currently. Passing the filepath which is the full path to the preset seems to work.

Issue is from this code in bpy.types.py : ``` props = layout.operator( operator, text=display_name(filepath) if display_name else bpy.path.display_name(f), translate=False, ) ``` Seems that the `bpy.path.display_name(f)` truncates the f variable like in the described issue. Since f is the file name (`2_colon_4_something.py`), it shows up like it does currently. Passing the `filepath` which is the full path to the preset seems to work. ![issue_with_preset_path_names.py.png](https://archive.blender.org/developer/F2200607/issue_with_preset_path_names.py.png)

Ray molenkamp commented

2018-02-09 19:25:54 +01:00

looks like _clean_utf8 in path.py is taking out what it thinks is the drive letter..

Trey Bagley commented

2018-02-25 22:59:50 +01:00

Added subscriber: @treybagley

Trey Bagley commented

2018-02-25 22:59:50 +01:00

Hi! Just joined and this sounds like a good first project! I repro this on my machine. What direction do we want to fix this from? Should I change the filename from blender\release\scripts\presets\safe_areas\4_colon_3_in_16_colon_9.py to 4__colon__3__in__16__colon__9.py to match the formatting in scripts\preset\camera? Or do we want to change the parsing?

Hi! Just joined and this sounds like a good first project! I repro this on my machine. What direction do we want to fix this from? Should I change the filename from `blender\release\scripts\presets\safe_areas\4_colon_3_in_16_colon_9.py` to `4__colon__3__in__16__colon__9.py` to match the formatting in `scripts\preset\camera`? Or do we want to change the parsing?

Campbell Barton commented

2018-02-26 06:20:04 +01:00

Using double underscores should not be needed, somehow using a back-slash is messing up the logic here.

@VukGardasevic, Using "\scripts\presets\...." is not a valid test, since Python escapes those characters, if you want to test this use r"\scripts\presets\....".

Using double underscores should not be needed, somehow using a back-slash is messing up the logic here. @VukGardasevic, Using `"\scripts\presets\...."` is not a valid test, since Python escapes those characters, if you want to test this use `r"\scripts\presets\...."`.

Vuk Gardašević commented

2018-02-26 06:39:18 +01:00

Passing r to display name seems to work on windows with the regular "" path :)
The culprit seems to be the _clean_utf8(name) function and with name = _os.path.splitext(basename(name))- [x] call, and finally in the def basename(path) the call _os.path.basename(path_base) does trim the name.

>>> bpy.path.display_name("2_colon_4_something.py")

_clean_utf8 passed name parameter is 2:4 Something.Py
path_base in basename is 2:4 Something.Py
_os.path.basename(path_base) in basename is 4 Something.Py
_clean_utf8 _os.path.splitext name is 4 Something
'4 Something'

Sorry for the multiple edits. I've overlooked the basename function call.

Passing r to display name seems to work on windows with the regular "\" path :) The culprit seems to be the `_clean_utf8(name)` function and with *name = _os.path.splitext(basename(name))- [x] call*, and finally in the `def basename(path)` the call `_os.path.basename(path_base)` does trim the name. ``` >>> bpy.path.display_name("2_colon_4_something.py") _clean_utf8 passed name parameter is 2:4 Something.Py path_base in basename is 2:4 Something.Py _os.path.basename(path_base) in basename is 4 Something.Py _clean_utf8 _os.path.splitext name is 4 Something '4 Something' ``` Sorry for the multiple edits. I've overlooked the basename function call.

blender-admin commented

2018-02-26 09:05:01 +01:00

This issue was referenced by d416e56e70

This issue was referenced by d416e56e70cf08f0d9ce012df67dce2cb597589d

Campbell Barton commented

2018-02-26 09:08:03 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2018-02-26 09:08:03 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Preset name parsing issue in Property Editor --> Camera Tab --> Safe Areas Panel --> Camera Presets List #54029

Preset name parsing issue in `Property Editor --> Camera Tab --> Safe Areas Panel --> Camera Presets List` #54029