Port blendfile parsing code from BAM to BAT? #54127

New Issue

Sybren A. Stüvel · 2018-02-22T11:15:43+01:00

Sybren A. Stüvel commented

2018-02-22 11:15:43 +01:00

The Blendfile parsing code in BAM's blendfile.py works mostly fine, and should be ported to BAT.

Break into a few separate files.
Convert module-like classes to actual modules.
Instead of passing the BlendFileHeader object around all the time, which is then used to find the endianness index, which is then used to find the correct struct to parse data, for each field that needs to be read, take a more object-oriented approach and construct an object once that then just points to the correct struct.
Use pathlib.Path for concrete paths of files to access.
In general, use a more Pythonic approach.

One thing to note is that there currently seems to be a bug in write_string(), which truncates the string to the field length before encoding to UTF-8, rather than truncating the encoded bytes. Furthermore, it should avoid truncating in the middle of a character and producing invalid UTF-8.

The Blendfile parsing code in BAM's [blendfile.py](https://developer.blender.org/diffusion/BAM/browse/master/bam/blend/blendfile.py) works mostly fine, and should be ported to BAT. - Break into a few separate files. - Convert module-like classes to actual modules. - Instead of passing the `BlendFileHeader` object around all the time, which is then used to find the endianness index, which is then used to find the correct struct to parse data, for each field that needs to be read, take a more object-oriented approach and construct an object once that then just points to the correct struct. - Use `pathlib.Path` for concrete paths of files to access. - In general, use a more Pythonic approach. One thing to note is that there currently seems to be a bug in [write_string()](https://developer.blender.org/diffusion/BAM/browse/master/bam/blend/blendfile.py;7afb1fe606b9c9e9e735653ab61859ee8a62dc22$850), which truncates the string to the field length before encoding to UTF-8, rather than truncating the encoded bytes. Furthermore, it should avoid truncating in the middle of a character and producing invalid UTF-8.

Sybren A. Stüvel self-assigned this 2018-02-22 11:15:43 +01:00

Sybren A. Stüvel commented

2018-02-22 11:15:43 +01:00

Added subscribers: @dr.sybren, @fsiddi

Sybren A. Stüvel commented

2018-02-26 16:35:46 +01:00

Changed status from 'Open' to: 'Resolved'

Sybren A. Stüvel closed this issue

2018-02-26 16:35:46 +01:00

Sybren A. Stüvel commented

2018-02-26 16:35:46 +01:00

The blendfile parsing, and writing string properties, is all ported from BAM as of commit 127f357e49acc4c144d9c49c10f875ac91fc942e.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Port blendfile parsing code from BAM to BAT? #54127