Python scripts calling bpy.ops.paint.image_paint operates undo steps for "individual calls" rather than "all calls" during modal operation #54496

New Issue

Rob Hughes · 2018-04-02T20:03:14+02:00

Rob Hughes commented

2018-04-02 20:03:14 +02:00

System Information
5820K and GTX970
Windows 10

Blender Version
Latest daily build (but same problem in earlier ones too)

Short description of error
I have a modal operator which uses image_paint function.
After using it, if I do an undo, I would expect all paint operations during modal operation to be undone.
However every call to image_paint adds another item to the undo list which means I have to undo through every mouse move.
If I have moved the mouse more than (max undo items) then I can't get back to the position before I started the operator at all (making the undo pointless)

This doesn't seem to be the consistent with other modal operator. For example, in the docs https://docs.blender.org/api/blender_python_api_current/bpy.types.Operator.html the modal excecution example (with the addition of UNDO added to bl_options) moves a cube. Many changes can be made to the position of the cube during the modal operation. However one undo (correctly in my option) puts the cube back in the original place before the operator is run.

I did try using UNDO_GROUPED in my bl_options as well as UNDO - neither worked.

If I am doing something wrong or stupid in my code - sorry!

Exact steps for others to reproduce the error
Load the attached scene.
Press Run Script
Hover over cube.
Right click
Press space
Type in Simple Paint Operator to activate operator
Press mouse button to stop the operator
Try Undoing - it undo things one mouse move at a time

modal_paint.blend1

**System Information** 5820K and GTX970 Windows 10 **Blender Version** Latest daily build (but same problem in earlier ones too) **Short description of error** I have a modal operator which uses image_paint function. After using it, if I do an undo, I would expect all paint operations during modal operation to be undone. However every call to image_paint adds another item to the undo list which means I have to undo through every mouse move. If I have moved the mouse more than (max undo items) then I can't get back to the position before I started the operator at all (making the undo pointless) This doesn't seem to be the consistent with other modal operator. For example, in the docs [https://docs.blender.org/api/blender_python_api_current/bpy.types.Operator.html ](URL) the modal excecution example (with the addition of UNDO added to bl_options) moves a cube. Many changes can be made to the position of the cube during the modal operation. However one undo (correctly in my option) puts the cube back in the original place before the operator is run. I did try using UNDO_GROUPED in my bl_options as well as UNDO - neither worked. If I am doing something wrong or stupid in my code - sorry! **Exact steps for others to reproduce the error** Load the attached scene. Press Run Script Hover over cube. Right click Press space Type in Simple Paint Operator <return> to activate operator Press mouse button to stop the operator Try Undoing - it undo things one mouse move at a time [modal_paint.blend1](https://archive.blender.org/developer/F2576956/modal_paint.blend1)

Rob Hughes commented

2018-04-02 20:03:15 +02:00

Added subscriber: @RevDr

Rob Hughes changed title from ~~Undo with bpy.ops.paint.image_paint operates for individual calls rather than all calls~~ to Undo with bpy.ops.paint.image_paint operates for "individual calls" rather than "all calls" during modal operation

2018-04-02 20:03:55 +02:00

Campbell Barton was assigned by Aaron Carlisle

2018-04-03 20:54:33 +02:00

Campbell Barton changed title from ~~Undo with bpy.ops.paint.image_paint operates for "individual calls" rather than "all calls" during modal operation~~ to Python scripts calling bpy.ops.paint.image_paint operates undo steps for "individual calls" rather than "all calls" during modal operation

2019-01-31 06:55:06 +01:00

Sebastian Parborg commented

2019-02-11 16:42:46 +01:00

Added subscriber: @ZedDB

Sebastian Parborg commented

2019-02-11 16:42:46 +01:00

I can reproduce this on 2.8 too.

Campbell Barton was unassigned by Dalai Felinto

2019-12-23 16:36:17 +01:00

Dalai Felinto commented

2019-12-23 16:36:17 +01:00

Added subscriber: @ideasman42

Sybren A. Stüvel commented

2020-02-04 12:56:09 +01:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2020-02-04 12:56:09 +01:00

Latest daily build (but same problem in earlier ones too)

Please always report an exact version number.

I can't reproduce this as-is, when trying to paint Blender tells me "Missing Textures, detected!".

@ideasman42 Can you tell whether this is a bug or a known limitation? It looks like the latter to me.

> Latest daily build (but same problem in earlier ones too) Please always report an exact version number. I can't reproduce this as-is, when trying to paint Blender tells me "Missing Textures, detected!". @ideasman42 Can you tell whether this is a bug or a known limitation? It looks like the latter to me.

Rob Hughes commented

2020-02-04 14:13:30 +01:00

Hi,
That scene was originally made for 2.79 which causes the "missing textures, detected" error on latest version.

I have updated the scene to work on today's build :
2.83Alpha - Data 2020-02-04 11:40 Hash cd0a028624
and can confirm the issue still exists.

Updated scene file is attached.modal_paint_2.blend

Given it is no longer 2.79, the process to cause problem is now....

Load the attached scene.
Press Run Script
Hover over cube.
Press F3
Type in Simple Modal Operator to activate operator
Move mouse around to paint on cube
Press mouse button to stop the operator
Try Undoing - it undo things one mouse move at a time

Hi, That scene was originally made for 2.79 which causes the "missing textures, detected" error on latest version. I have updated the scene to work on today's build : 2.83Alpha - Data 2020-02-04 11:40 Hash cd0a02862404 and can confirm the issue still exists. Updated scene file is attached.[modal_paint_2.blend](https://archive.blender.org/developer/F8320747/modal_paint_2.blend) Given it is no longer 2.79, the process to cause problem is now.... Load the attached scene. Press Run Script Hover over cube. Press F3 Type in Simple Modal Operator <return> to activate operator Move mouse around to paint on cube Press mouse button to stop the operator Try Undoing - it undo things one mouse move at a time

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Python scripts calling bpy.ops.paint.image_paint operates undo steps for "individual calls" rather than "all calls" during modal operation #54496