FBX importer script lacks try/except handling (integer overflow for read-in values) #54586

New Issue

Phil Stopford · 2018-04-12T20:48:38+02:00

Phil Stopford commented

2018-04-12 20:48:38 +02:00

System Information
Windows 10 Pro, GTX 1060 6 GB

Blender Version
Broken: 2.79b

Short description of error
Some FBX files result in an error being reported by the script because values lie outside the expected integer range. Rather than clamping and moving on, the exporter instead simply fails to handle the situation.

I have a few of these FBX files from modo that cause this line to throw the error :

ma.specular_hardness = ma_spec_hardness * 5.10 + 1.0

It's unguarded, so the overflow (caused by extremely large positive/negative values) is an issue.

One option would be to handle the exception by forcing the value of hardness in case of problems.

I ran into this for scenes that cannot be easily shared. I'm looking to find a test case, but wanted to report this in the interim in case it's deemed trivial to fix without a repro case.

**System Information** Windows 10 Pro, GTX 1060 6 GB **Blender Version** Broken: 2.79b **Short description of error** Some FBX files result in an error being reported by the script because values lie outside the expected integer range. Rather than clamping and moving on, the exporter instead simply fails to handle the situation. I have a few of these FBX files from modo that cause this line to throw the error : ma.specular_hardness = ma_spec_hardness * 5.10 + 1.0 It's unguarded, so the overflow (caused by extremely large positive/negative values) is an issue. One option would be to handle the exception by forcing the value of hardness in case of problems. I ran into this for scenes that cannot be easily shared. I'm looking to find a test case, but wanted to report this in the interim in case it's deemed trivial to fix without a repro case.

Phil Stopford commented

2018-04-12 20:48:38 +02:00

Added subscriber: @phil.stopford

Bastien Montagne commented

2019-03-14 15:31:45 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2019-03-14 15:31:45 +01:00

Changed status from 'Open' to: 'Archived'

Bastien Montagne closed this issue

2019-03-14 15:31:45 +01:00

Bastien Montagne self-assigned this 2019-03-14 15:31:45 +01:00

Bastien Montagne commented

2019-03-14 15:31:45 +01:00

Thanks for the report, but that is not a Blender issue. Making FBX IO code resilient to invalid data would be a huge task, would make that (highly complex) add-on even more complex, and... Blender is not intended to be used as a repair tool for broken files from other formats.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

FBX importer script lacks try/except handling (integer overflow for read-in values) #54586