Assert when changing interface display scale #54864

New Issue

Dalai Felinto · 2018-04-27T20:40:41+02:00

Dalai Felinto commented

2018-04-27 20:40:41 +02:00

Blender Version
Broken: 5f6c45498c
Worked: 5f6c45498c^

Short description of error
Blender crashes when I change UI scale to 4.0.

Exact steps for others to reproduce the error

Factory startup
User Preferences (Ctrl+Alt+U)
Interface > Display > 4.0

BLI_assert failed: /home/dfelinto/src/blender/blender/source/blender/editors/screen/area.c:1433, area_calc_totrct(), at 'sa->totrct.ymin >= 0'

Full backtrace: P663

**Blender Version** Broken: 5f6c45498c Worked: 5f6c45498c^ **Short description of error** Blender crashes when I change UI scale to 4.0. **Exact steps for others to reproduce the error** * Factory startup * User Preferences (Ctrl+Alt+U) * Interface > Display > 4.0 ``` BLI_assert failed: /home/dfelinto/src/blender/blender/source/blender/editors/screen/area.c:1433, area_calc_totrct(), at 'sa->totrct.ymin >= 0' ``` Full backtrace: [P663](https://archive.blender.org/developer/P663.txt)

Dalai Felinto commented

2018-04-27 20:40:41 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2018-04-27 20:42:06 +02:00

Added subscriber: @JulianEisel
Removed subscriber: @dfelinto

Added subscriber: @JulianEisel Removed subscriber: @dfelinto

Julian Eisel was assigned by Dalai Felinto

2018-04-27 20:42:06 +02:00

Dalai Felinto commented

2018-04-27 20:42:06 +02:00

@JulianEisel this bug was introduced (or exposed?) in the top-bar merge. Could you take a look at it?

Dalai Felinto commented

2018-04-28 16:02:47 +02:00

In what I believe is a related note, if you use the following startup and userpref files you don't get a crash, however this is how the topbar action zones look like until you make them redraw in some way:

startup.blend

userpref.blend

In what I believe is a related note, if you use the following startup and userpref files you don't get a crash, however this is how the topbar action zones look like until you make them redraw in some way: [startup.blend](https://archive.blender.org/developer/F3087832/startup.blend) [userpref.blend](https://archive.blender.org/developer/F3087831/userpref.blend) ![glitch_ui.png](https://archive.blender.org/developer/F3087837/glitch_ui.png)

Dalai Felinto commented

2018-05-02 18:07:26 +02:00

The issue has to do with screen_vertices_scale. In this function we are setting sv->vec.y to a negative number for the lower edge.

The issue has to do with `screen_vertices_scale`. In this function we are setting `sv->vec.y` to a negative number for the lower edge.

Julian Eisel commented

2018-05-02 18:13:52 +02:00

Hmm, I'd say screen-verts must never have a negative coordinate, if so there's probably a bug. So the assert seems to be right. Would still have to check details though.

blender-admin commented

2018-05-02 18:22:09 +02:00

This issue was referenced by 965e6ed54f

This issue was referenced by 965e6ed54f058c21ae6096a5449fb3d1e5235821

Dalai Felinto commented

2018-05-02 18:27:29 +02:00

The thing is, top-bar commit introduced asserts in area_calc_totrct() that would fail even for master. Which although correct, led to a very unstable 2.8.
My proposal is the following "fix" P670 (basically removing the asserts).

The thing is, top-bar commit introduced asserts in `area_calc_totrct()` that would fail even for master. Which although correct, led to a very unstable 2.8. My proposal is the following "fix" [P670](https://archive.blender.org/developer/P670.txt) (basically removing the asserts).

Dalai Felinto commented

2018-05-02 18:33:53 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2018-05-02 18:33:53 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Assert when changing interface display scale #54864