DOF Number of blades wrong logic #55915

New Issue

Closed

opened 2018-07-11 14:45:39 +02:00 by Roel Koster · 5 comments

Roel Koster commented

2018-07-11 14:45:39 +02:00

Member

System Information
All platforms

Blender Version
Broken: Since dawn of time ;-)

Short description of error
Manually entering a value coming from 0, always reverts to 3

Exact steps for others to reproduce the error
Factory Defaults
Add Camera
Change Depth of Field Number of blades from default value 0 to 5
Observe Number of blades returns to 3
(when using the buttons on either side to increase the value from 0 to 5 it works, but who does that ;-)

My proposal is this:
DOFBlades.diff

Functionality:
Enter value manually or via mouse clicks: result cannot have other value than 0,3,4,5,6,...

Sidenote:
If a user decides to enter a wrong value (1 or 2) it depends on what the previous value was. If it was higher it will enter 3, if it was 0 it stays 0.

**System Information** All platforms **Blender Version** Broken: Since dawn of time ;-) **Short description of error** Manually entering a value coming from 0, always reverts to 3 **Exact steps for others to reproduce the error** Factory Defaults Add Camera Change Depth of Field Number of blades from default value 0 to 5 Observe Number of blades returns to 3 (when using the buttons on either side to increase the value from 0 to 5 it works, but who does that ;-) My proposal is this: [DOFBlades.diff](https://archive.blender.org/developer/F3913113/DOFBlades.diff) Functionality: Enter value manually or via mouse clicks: result cannot have other value than 0,3,4,5,6,... Sidenote: If a user decides to enter a wrong value (1 or 2) it depends on what the previous value was. If it was higher it will enter 3, if it was 0 it stays 0.

Roel Koster commented

2018-07-11 14:45:39 +02:00

Author

Member

Added subscriber: @kostex

Added subscriber: @kostex

Bastien Montagne commented

2018-07-11 14:52:18 +02:00

Owner

Added subscribers: @fclem, @mont29

Added subscribers: @fclem, @mont29

Clément Foucault was assigned by Bastien Montagne

2018-07-11 14:52:18 +02:00

Bastien Montagne commented

2018-07-11 14:52:18 +02:00

Owner

Patch looks good to me, assigning to @fclem since I think this is his area of code.

Patch looks good to me, assigning to @fclem since I think this is his area of code.

blender-admin commented

2018-07-11 18:33:35 +02:00

This issue was referenced by 78988e175a

This issue was referenced by 78988e175ae4904c043a6ca8499887b69c024c4f

Clément Foucault commented

2018-07-11 18:34:01 +02:00

Member

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Clément Foucault closed this issue

2018-07-11 18:34:01 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#55915

No description provided.