Improve MemFile Undo (for general use) #56163

New Issue

Campbell Barton · 2018-07-31T04:31:05+02:00

Campbell Barton commented

2018-07-31 04:31:05 +02:00

Motivation:

Resolve bugs where changes to data outside a 'mode' are ignored by the undo system.
Unify logic and reduce code duplication.

Description:

Currently we have a blend file based undo system (internally called 'MemFile').

We could use this almost everywhere (edit-modes for example), it would be sub-optimal at the moment.

This project would involve optimizing the case when only a limited set of data-blocks change - so we can skip writing all other data-blocks into the memfile.

It may also involve using better binary diffing for MemFile undo (as edit-modes currently use).

This would most likely not cover image painting and sculpting.

Estimated Time: possibly 2-4 weeks (hard to know).

**Motivation:** - Resolve bugs where changes to data outside a 'mode' are ignored by the undo system. - Unify logic and reduce code duplication. **Description:** Currently we have a blend file based undo system (internally called 'MemFile'). We could use this almost everywhere (edit-modes for example), it would be sub-optimal at the moment. This project would involve optimizing the case when only a limited set of data-blocks change - so we can skip writing all other data-blocks into the memfile. It may also involve using better binary diffing for `MemFile` undo (as edit-modes currently use). This would most likely not cover image painting and sculpting. **Estimated Time:** possibly 2-4 weeks *(hard to know)*.

Campbell Barton self-assigned this 2018-07-31 04:31:05 +02:00

Campbell Barton commented

2018-07-31 04:31:05 +02:00

Added subscribers: @ideasman42, @dfelinto, @mont29, @Sergey, @brecht

Germano Cavalcante commented

2020-11-24 13:36:08 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-11-24 13:36:08 +01:00

To keep track, here are some reports that I think are related:
Mesh Edit-Mode:
#63367 (Undo of operations on modifiers is inconsistent when object is in edit mode)
#71895 (Undo doesn't consider changes in nodetree when object is in edit and texture paint mode)
#75013 (Incorrect order in undo stack when switching between Object Mode and Edit Mode)
#75541 (Modifiers added in edit mode are undone out of order if you go back to object mode)
#80096 (Annotations cannot be undone if in edit mode-ish)
#63434 (Undoing the removal of a vertex group in edit mode changes other vertex groups and doesnt bring the removed vertex group back)
#50423 (Adding new hook while in Edit mode breaks when trying to undo/redo the operator)

Armature Edit-Mode
#82816 (Undo in Armature EditMode ignores changes to other IDs)

There are also problems involving sculpt-mode, palette in vertex paint mode, text editor and outliner but I'm not sure if they are related.

To keep track, here are some reports that I think are related: **Mesh Edit-Mode:** #63367 (Undo of operations on modifiers is inconsistent when object is in edit mode) #71895 (Undo doesn't consider changes in nodetree when object is in edit and texture paint mode) #75013 (Incorrect order in undo stack when switching between Object Mode and Edit Mode) #75541 (Modifiers added in edit mode are undone out of order if you go back to object mode) #80096 (Annotations cannot be undone if in edit mode-ish) #63434 (Undoing the removal of a vertex group in edit mode changes other vertex groups and doesnt bring the removed vertex group back) #50423 (Adding new hook while in Edit mode breaks when trying to undo/redo the operator) **Armature Edit-Mode** #82816 (Undo in Armature EditMode ignores changes to other IDs) There are also problems involving sculpt-mode, palette in vertex paint mode, text editor and outliner but I'm not sure if they are related.

Sybren A. Stüvel commented

2022-05-02 15:45:12 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2022-05-02 15:45:12 +02:00

@ideasman42 do you still have an interest in fixing this?

Campbell Barton removed their assignment 2022-05-03 05:50:11 +02:00

Campbell Barton commented

2022-05-03 05:50:11 +02:00

@dr.sybren yes, but no near term plans, so putting up for grabs.

Pratik Borhade commented

2022-07-23 05:11:46 +02:00

Added subscriber: @PratikPB2123

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Improve MemFile Undo (for general use) #56163