Mirror Modifier wrong UV Offsets #56324

Closed
opened 2018-08-11 21:08:35 +02:00 by Yevgeny Makarov · 9 comments

Blender Version
Broken: 2.79.6

Short description of error
The "Flip U/V Offset" options of the Mirror Modifier
should shift the flipping point from the 0.5 (as tooltips says).

For example, the Offset 0.25,
then flipping point should be 0.75 (0.5 + 0.25),
but it's actually 0.625.

mirror-modifier-uv-offset.blend


Mirror Modifier
There are two UV offsets: "Flip U/V Offset" and "U/V Offset".

What's the difference?
They seem to be doing the same thing.

for (; j-- > 0; dmloopuv++) {
  if (do_mirr_u) dmloopuv->uv[0] = 1.0f - dmloopuv->uv[0] + mmd->uv_offset[0];
  if (do_mirr_v) dmloopuv->uv[1] = 1.0f - dmloopuv->uv[1] + mmd->uv_offset[1];
  dmloopuv->uv[0] += mmd->uv_offset_copy[0];
  dmloopuv->uv[1] += mmd->uv_offset_copy[1];
}

https://developer.blender.org/diffusion/B/browse/master/source/blender/modifiers/intern/MOD_mirror.c$262

**Blender Version** Broken: 2.79.6 **Short description of error** The "Flip U/V Offset" options of the Mirror Modifier should shift the flipping point from the 0.5 (as tooltips says). For example, the Offset 0.25, then flipping point should be 0.75 (0.5 + 0.25), but it's actually 0.625. [mirror-modifier-uv-offset.blend](https://archive.blender.org/developer/F4203053/mirror-modifier-uv-offset.blend) ----- **Mirror Modifier** There are two UV offsets: "Flip U/V Offset" and "U/V Offset". What's the difference? They seem to be doing the same thing. ``` for (; j-- > 0; dmloopuv++) { if (do_mirr_u) dmloopuv->uv[0] = 1.0f - dmloopuv->uv[0] + mmd->uv_offset[0]; if (do_mirr_v) dmloopuv->uv[1] = 1.0f - dmloopuv->uv[1] + mmd->uv_offset[1]; dmloopuv->uv[0] += mmd->uv_offset_copy[0]; dmloopuv->uv[1] += mmd->uv_offset_copy[1]; } ``` https://developer.blender.org/diffusion/B/browse/master/source/blender/modifiers/intern/MOD_mirror.c$262
Author
Member

Added subscriber: @jenkm

Added subscriber: @jenkm
Campbell Barton was assigned by Yevgeny Makarov 2018-08-11 21:10:54 +02:00

Added subscriber: @mont29

Added subscriber: @mont29

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'

Please use this bug tracker for reporting bugs. General discussion and inquiries like that shall go through IRC (#blendercoders on freenode.net) or ML (bf-committers@blender.org).

Please use this bug tracker for reporting bugs. General discussion and inquiries like that shall go through IRC (#blendercoders on freenode.net) or ML (bf-committers@blender.org).
Author
Member

@mont29

OK, "Flip U/V Offset" should shift the flipping point from the 0.5 (as tooltips says).

For example, the Offset 0.25,
then flipping point should be 0.75 (0.5 + 0.25),
but it's actually 0.625.

There is a bug, (or incorrect tooltip).

mirror-modifier-uv-offset.blend

@mont29 OK, "Flip U/V Offset" should shift the flipping point from the 0.5 (as tooltips says). For example, the Offset 0.25, then flipping point should be 0.75 (0.5 + 0.25), but it's actually 0.625. There is a bug, (or incorrect tooltip). [mirror-modifier-uv-offset.blend](https://archive.blender.org/developer/F4203053/mirror-modifier-uv-offset.blend)
Yevgeny Makarov changed title from Mirror Modifier two UV Offsets options to Mirror Modifier wrong UV Offsets 2018-08-13 08:28:50 +02:00
Author
Member

Changed status from 'Archived' to: 'Open'

Changed status from 'Archived' to: 'Open'

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'

Things are working as expected, 0.25 means flipping point is at 0.75, which is the case (taking into account things are mirrored, line between D2 and D3 columns is at 0.75 of the mirrored face). Agree those two settings (flip offset, and offset) end up doing the same thing, but there is no bug here.

Things are working as expected, 0.25 means flipping point is at 0.75, which is the case (taking into account things are mirrored, line between [D2](https://archive.blender.org/developer/D2) and [D3](https://archive.blender.org/developer/D3) columns is at 0.75 of the mirrored face). Agree those two settings (flip offset, and offset) end up doing the same thing, but there is no bug here.
Author
Member

I just read the tooltip as "move the flipping point and then flip over it",
but here it first flips and then moves, i.e. it's just a offset.

I just read the tooltip as "move the flipping point and then flip over it", but here it first flips and then moves, i.e. it's just a offset.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-manual#56324
No description provided.