Segment fault when change parameter of one operator after undo #56498

New Issue

Closed

opened 2018-08-22 14:10:51 +02:00 by Antonio Vazquez · 8 comments

Antonio Vazquez commented

2018-08-22 14:10:51 +02:00

Member

Windows 10 - Last source code compiled with MSVSC2017

This error looks related to a previous bug that was solved with OPTYPE_USE_EVAL_DATA flag. I have added the flag to the operator GPENCIL_OT_paste, but I think in this case is not the solution.

Open attached file and select GP object.
Be sure "Lines" grease pencil layer is selected.
Enter in edit mode and select some points (the file already has some selected).
Press Ctrl+C.
Select "Colors" grease pencil layer.
Press Ctrl+V
Go to F6 panel and select "merge" option.
Crash.

The crash is in deg_tag_copy_on_write_id() function because id_cow field is NULL.

@mont29 I think you solved the previous bugs, could you take a look on this? Let me know if I can help you.PASTE.blend

Windows 10 - Last source code compiled with MSVSC2017 This error looks related to a previous bug that was solved with OPTYPE_USE_EVAL_DATA flag. I have added the flag to the operator GPENCIL_OT_paste, but I think in this case is not the solution. 1) Open attached file and select GP object. 2) Be sure "Lines" grease pencil layer is selected. 3) Enter in edit mode and select some points (the file already has some selected). 4) Press Ctrl+C. 5) Select "Colors" grease pencil layer. 6) Press Ctrl+V 7) Go to F6 panel and select "merge" option. 8) Crash. The crash is in deg_tag_copy_on_write_id() function because id_cow field is NULL. @mont29 I think you solved the previous bugs, could you take a look on this? Let me know if I can help you.[PASTE.blend](https://archive.blender.org/developer/F4337913/PASTE.blend)

Antonio Vazquez commented

2018-08-22 14:10:51 +02:00

Author

Member

Added subscribers: @mont29, @antoniov

Added subscribers: @mont29, @antoniov

Bastien Montagne self-assigned this 2018-08-22 15:28:50 +02:00

Bastien Montagne commented

2018-08-22 15:28:50 +02:00

Owner

Crash has nothing to do with depsgraph, you are storing ID pointers (material ones) in a ghash accross redo step, with invalidate any pointer in Blender… will check, think you have to rather store ref to ID by its lib/name pair. Also, ghash here is int key, not string ones…

Crash has nothing to do with depsgraph, you are storing ID pointers (material ones) in a ghash accross redo step, with invalidate any pointer in Blender… will check, think you have to rather store ref to ID by its lib/name pair. Also, ghash here is int key, not string ones…

Antonio Vazquez commented

2018-08-22 15:43:21 +02:00

Author

Member

OK, I'm going to take a look how is done (this is not my code). I thought it was related to depshgraph issue.

Thanks!

OK, I'm going to take a look how is done (this is not my code). I thought it was related to depshgraph issue. Thanks!

Antonio Vazquez commented

2018-08-22 16:35:13 +02:00

Author

Member

Added subscriber: @JoshuaLeung

Added subscriber: @JoshuaLeung

Antonio Vazquez commented

2018-08-22 16:35:13 +02:00

Author

Member

@JoshuaLeung Could you take a look? It's no totally clear what you do here and why you use in sculpt the hash.

@JoshuaLeung Could you take a look? It's no totally clear what you do here and why you use in sculpt the hash.

blender-admin commented

2018-08-23 08:40:05 +02:00

This issue was referenced by 01973290a9

This issue was referenced by 01973290a9fd6c7e48ab4d19043eb3a26939cb4e

Bastien Montagne commented

2018-08-23 08:51:34 +02:00

Owner

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2018-08-23 08:51:34 +02:00

Antonio Vazquez commented

2018-08-23 10:31:52 +02:00

Author

Member

Thanks @mont29, I will take note of this to don't make this mistake in the future.

Thanks @mont29, I will take note of this to don't make this mistake in the future.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#56498

No description provided.