OpenGL Render Engine Crash #56940

New Issue

Marcus Papathoma · 2018-09-27T19:30:11+02:00

Marcus Papathoma commented

2018-09-27 19:30:11 +02:00

System Information
Windows 10 x64

Blender Version
Broken: blender-2.80.0-git.6ebe2116446-windows64 from today
Worked: blender-2.80.0-git.c419cb7305f-windows64 from 26.09.2018

Short description of error
When rendering with OpenGL Render Engine Blender Crashes

Exact steps for others to reproduce the error
Open Blender
Switch the Render Engine from Eevee to OpenGL
Hit Crtl+F12 or use the Menu > Render > Render Animation
Blender Crashes

**System Information** Windows 10 x64 **Blender Version** Broken: blender-2.80.0-git.6ebe2116446-windows64 from today Worked: blender-2.80.0-git.c419cb7305f-windows64 from 26.09.2018 **Short description of error** When rendering with OpenGL Render Engine Blender Crashes **Exact steps for others to reproduce the error** Open Blender Switch the Render Engine from Eevee to OpenGL Hit Crtl+F12 or use the Menu > Render > Render Animation Blender Crashes

Marcus Papathoma commented

2018-09-27 19:30:11 +02:00

Added subscriber: @machieb

Antonio Vazquez commented

2018-09-28 10:10:27 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2018-09-28 10:10:27 +02:00

I get the error using the last source code at 10:00 CET 28-Sep-2018

The error is because v3d is NULL in workbench_render() function in the following line:

const bool deferred = (scene->display.shading.flag & XRAY_FLAG(draw_ctx->v3d)) == 0;

I get the error using the last source code at 10:00 CET 28-Sep-2018 The error is because v3d is NULL in workbench_render() function in the following line: > const bool deferred = (scene->display.shading.flag & XRAY_FLAG(draw_ctx->v3d)) == 0;

Antonio Vazquez commented

2018-09-28 10:12:53 +02:00

I have done a test and checking to NULL v3d avoid the error in the line above, but there are more error after that:

Function workbench_forward_engine_init()

if (draw_ctx->v3d->shading.flag & XRAY_FLAG(draw_ctx->v3d)) {

I have done a test and checking to NULL v3d avoid the error in the line above, but there are more error after that: Function workbench_forward_engine_init() ``` if (draw_ctx->v3d->shading.flag & XRAY_FLAG(draw_ctx->v3d)) { ```

Antonio Vazquez commented

2018-09-28 10:21:47 +02:00

This fix the problem, but not sure if this is the right way:

diff --git a/source/blender/draw/engines/workbench/workbench_forward.c b/source/blender/draw/engines/workbench/workbench_forward.c
index ca8f06c..f6e352c 100644
--- a/source/blender/draw/engines/workbench/workbench_forward.c
+++ b/source/blender/draw/engines/workbench/workbench_forward.c
@@ -365,11 +365,11 @@ void workbench_forward_engine_init(WORKBENCH_Data *vedata)
 	{
 		float blend_threshold = 0.0f;
 
-		if (draw_ctx->v3d->shading.flag & XRAY_FLAG(draw_ctx->v3d)) {
+		if (draw_ctx->v3d && draw_ctx->v3d->shading.flag & XRAY_FLAG(draw_ctx->v3d)) {
 			blend_threshold = 0.75f - XRAY_ALPHA(wpd) * 0.5f;
 		}
 
-		if (draw_ctx->v3d->shading.type == OB_WIRE) {
+		if (draw_ctx->v3d && draw_ctx->v3d->shading.type == OB_WIRE) {
 			wpd->shading.xray_alpha = 0.0f;
 			wpd->shading.xray_alpha_wire = 0.0f;
 		}
diff --git a/source/blender/draw/engines/workbench/workbench_render.c b/source/blender/draw/engines/workbench/workbench_render.c
index 67059da..7b0a648 100644
--- a/source/blender/draw/engines/workbench/workbench_render.c
+++ b/source/blender/draw/engines/workbench/workbench_render.c
@@ -137,7 +137,7 @@ void workbench_render(WORKBENCH_Data *data, RenderEngine *engine, RenderLayer *r
 		return;
 	}
 
-	const bool deferred = (scene->display.shading.flag & XRAY_FLAG(draw_ctx->v3d)) == 0;
+	const bool deferred = draw_ctx->v3d ? (scene->display.shading.flag & XRAY_FLAG(draw_ctx->v3d)) == 0 : false;
 
 	if (deferred) {
 		/* Init engine. */

This fix the problem, but not sure if this is the right way: ``` diff --git a/source/blender/draw/engines/workbench/workbench_forward.c b/source/blender/draw/engines/workbench/workbench_forward.c index ca8f06c..f6e352c 100644 --- a/source/blender/draw/engines/workbench/workbench_forward.c +++ b/source/blender/draw/engines/workbench/workbench_forward.c @@ -365,11 +365,11 @@ void workbench_forward_engine_init(WORKBENCH_Data *vedata) { float blend_threshold = 0.0f; - if (draw_ctx->v3d->shading.flag & XRAY_FLAG(draw_ctx->v3d)) { + if (draw_ctx->v3d && draw_ctx->v3d->shading.flag & XRAY_FLAG(draw_ctx->v3d)) { blend_threshold = 0.75f - XRAY_ALPHA(wpd) * 0.5f; } - if (draw_ctx->v3d->shading.type == OB_WIRE) { + if (draw_ctx->v3d && draw_ctx->v3d->shading.type == OB_WIRE) { wpd->shading.xray_alpha = 0.0f; wpd->shading.xray_alpha_wire = 0.0f; } diff --git a/source/blender/draw/engines/workbench/workbench_render.c b/source/blender/draw/engines/workbench/workbench_render.c index 67059da..7b0a648 100644 --- a/source/blender/draw/engines/workbench/workbench_render.c +++ b/source/blender/draw/engines/workbench/workbench_render.c @@ -137,7 +137,7 @@ void workbench_render(WORKBENCH_Data *data, RenderEngine *engine, RenderLayer *r return; } - const bool deferred = (scene->display.shading.flag & XRAY_FLAG(draw_ctx->v3d)) == 0; + const bool deferred = draw_ctx->v3d ? (scene->display.shading.flag & XRAY_FLAG(draw_ctx->v3d)) == 0 : false; if (deferred) { /* Init engine. */ ```

Antonio Vazquez commented

2018-09-28 10:22:49 +02:00

Added subscribers: @fclem, @Jeroen-Bakker