Redo panel does not work for the 3d cursor #57100

Open
opened 2018-10-08 15:07:50 +02:00 by Jacques Lucke · 21 comments
Member

System Information
Ubuntu 18.04

Blender Version
Broken: 7d38654

Short description of error
Redo panel for moving the 3d cursor does not work as expected.

Exact steps for others to reproduce the error
Start moving the 3d cursor and then change the value in the redo panel.
move 3d cursor.gif

My guess is that this happens because the 3d cursor is not effected by the normal undo.

**System Information** Ubuntu 18.04 **Blender Version** Broken: 7d38654 **Short description of error** Redo panel for moving the 3d cursor does not work as expected. **Exact steps for others to reproduce the error** Start moving the 3d cursor and then change the value in the redo panel. ![move 3d cursor.gif](https://archive.blender.org/developer/F4987900/move_3d_cursor.gif) My guess is that this happens because the 3d cursor is not effected by the normal undo.
Author
Member

Added subscriber: @JacquesLucke

Added subscriber: @JacquesLucke

#100315 was marked as duplicate of this issue

#100315 was marked as duplicate of this issue

#99669 was marked as duplicate of this issue

#99669 was marked as duplicate of this issue

#66110 was marked as duplicate of this issue

#66110 was marked as duplicate of this issue

#65204 was marked as duplicate of this issue

#65204 was marked as duplicate of this issue

#63181 was marked as duplicate of this issue

#63181 was marked as duplicate of this issue

Added subscriber: @AdamPreisler

Added subscriber: @AdamPreisler

Can confirm this.

Curious though when I would need to do that. I usuallysnap 3D cursor to selection and then scale to it orI place it to create objects on top of it: add groups / lights to a specific spot in the scene.

Rarely I change the location in the 3D Cursor tab on the right where you can move it to any world location (starting with the current values it has already).
Although sometimes after placing it, I read the values so I find that definitely useful.

Only occurence when I would like to use this I can think of is to move the cursor along a local coordinate system (referencing the new possibility to have rotation on the cursor. Because you can always move the cursor along world axes utilizing it's tab in the Sidebar.

Now also kind of realizing that cursor's rotation is not yet exposed in the Sidebar panel (shortcut:N) on the right.

Can confirm this. Curious though when I would need to do that. I usually**snap 3D cursor to selection** and then scale to it or**I place it to create objects on top of it**: add groups / lights to a specific spot in the scene. Rarely I change the location in the 3D Cursor tab on the right where you can move it to any world location (starting with the current values it has already). Although sometimes after placing it, I read the values so I find that definitely useful. **Only occurence when I would like to use this I can think of is to move the cursor along a local coordinate system (referencing the new possibility to have rotation on the cursor.** Because you can always move the cursor along world axes utilizing it's tab in the Sidebar. Now also kind of realizing that cursor's rotation is not yet exposed in the Sidebar panel (shortcut:N) on the right.
Campbell Barton was assigned by Sebastian Parborg 2019-02-06 15:21:07 +01:00

Added subscriber: @RobertS

Added subscriber: @RobertS
Member

Added subscriber: @nacioss

Added subscriber: @nacioss
Member

If i change the 3D Cursor position with the N panel settings for the 3d cursor i can't get the Adjust Last Operation panel to appear..

If i change the 3D Cursor position with the N panel settings for the 3d cursor i can't get the Adjust Last Operation panel to appear..

Added subscriber: @CandleComet

Added subscriber: @CandleComet

Added subscriber: @AbidMaqbool

Added subscriber: @AbidMaqbool

This is very important feature... on the other hand a bug/error. because after moving the cursor redo panel shows... (why).. not works in many ways.
e.g.

  1. move the cursor, form redo panel changing the value effects too many, also only in postie direction (where values are less or not)
  2. rotate the cursor, redo panel not effects the 3d-cursor rather then last selected object
  3. scales the 3d cursor, redo panel still shows...

I have a q? why until know this is resolved...

This is very important feature... on the other hand a bug/error. because after moving the cursor redo panel shows... (why).. not works in many ways. e.g. 1. move the cursor, form redo panel changing the value effects too many, also only in postie direction (where values are less or not) 2. rotate the cursor, redo panel not effects the 3d-cursor rather then last selected object 3. scales the 3d cursor, redo panel still shows... I have a q? why until know this is resolved...
Member
Added subscribers: @martinium, @ideasman42, @lichtwerk, @ZedDB, @CraigD
Campbell Barton was unassigned by Dalai Felinto 2019-12-23 16:35:56 +01:00

Added subscriber: @EvandroFerreiradaCosta

Added subscriber: @EvandroFerreiradaCosta

In my tests, using the 3D cursor Move Panel X/Y/Z sliders sends the cursor to infinity and beyond. Behaves as when you have a circular dependency in hierarchy.
This happens in all 2.82 stable, 2.83 beta and 2.90 alpha. Windows.
I can't even control the cursor like the original gif in this report shows, maybe because I'm on Windows?
Should I open a new bug report?

In my tests, using the 3D cursor Move Panel X/Y/Z sliders sends the cursor to infinity and beyond. Behaves as when you have a circular dependency in hierarchy. This happens in all 2.82 stable, 2.83 beta and 2.90 alpha. Windows. I can't even control the cursor like the original gif in this report shows, maybe because I'm on Windows? Should I open a new bug report?
Member

Removed subscriber: @nacioss

Removed subscriber: @nacioss

Added subscribers: @hamza-el-barmaki, @mano-wii

Added subscribers: @hamza-el-barmaki, @mano-wii

Here is an old patch from when I investigated this issue.
Maybe it fix the problem but bring others.
It might be useful in some way:

diff --git a/source/blender/blenkernel/intern/scene.c b/source/blender/blenkernel/intern/scene.c
index 3633dff8690..a123637817e 100644
--- a/source/blender/blenkernel/intern/scene.c
+++ b/source/blender/blenkernel/intern/scene.c
@@ -803,12 +803,6 @@ static void scene_blend_write(BlendWriter *writer, ID *id, const void *id_addres
 {
   Scene *sce = (Scene *)id;
 
-  if (BLO_write_is_undo(writer)) {
-    /* Clean up, important in undo case to reduce false detection of changed data-blocks. */
-    /* XXX This UI data should not be stored in Scene at all... */
-    memset(&sce->cursor, 0, sizeof(sce->cursor));
-  }
-
   /* write LibData */
   BLO_write_id_struct(writer, Scene, id_address, &sce->id);
   BKE_id_blend_write(writer, &sce->id);
@@ -1676,7 +1670,6 @@ static void scene_undo_preserve(BlendLibReader *reader, ID *id_new, ID *id_old)
   Scene *scene_new = (Scene *)id_new;
   Scene *scene_old = (Scene *)id_old;
 
-  SWAP(View3DCursor, scene_old->cursor, scene_new->cursor);
   if (scene_new->toolsettings != NULL && scene_old->toolsettings != NULL) {
     /* First try to restore ID pointers that can be and should be preserved (like brushes or
      * palettes), and counteract the swap of the whole ToolSettings structs below for the others

Here is an old patch from when I investigated this issue. Maybe it fix the problem but bring others. It might be useful in some way: ``` diff --git a/source/blender/blenkernel/intern/scene.c b/source/blender/blenkernel/intern/scene.c index 3633dff8690..a123637817e 100644 --- a/source/blender/blenkernel/intern/scene.c +++ b/source/blender/blenkernel/intern/scene.c @@ -803,12 +803,6 @@ static void scene_blend_write(BlendWriter *writer, ID *id, const void *id_addres { Scene *sce = (Scene *)id; - if (BLO_write_is_undo(writer)) { - /* Clean up, important in undo case to reduce false detection of changed data-blocks. */ - /* XXX This UI data should not be stored in Scene at all... */ - memset(&sce->cursor, 0, sizeof(sce->cursor)); - } - /* write LibData */ BLO_write_id_struct(writer, Scene, id_address, &sce->id); BKE_id_blend_write(writer, &sce->id); @@ -1676,7 +1670,6 @@ static void scene_undo_preserve(BlendLibReader *reader, ID *id_new, ID *id_old) Scene *scene_new = (Scene *)id_new; Scene *scene_old = (Scene *)id_old; - SWAP(View3DCursor, scene_old->cursor, scene_new->cursor); if (scene_new->toolsettings != NULL && scene_old->toolsettings != NULL) { /* First try to restore ID pointers that can be and should be preserved (like brushes or * palettes), and counteract the swap of the whole ToolSettings structs below for the others ```

Added subscriber: @Vitaliy125

Added subscriber: @Vitaliy125
Philipp Oeser removed the
Interest
Modeling
label 2023-02-09 15:30:01 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
9 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#57100
No description provided.