Bake Action Operator offsets keyframes from tweaked strip #57159

New Issue

¿? · 2018-10-11T08:46:48+02:00

¿? commented

2018-10-11 08:46:48 +02:00

Note: this is a bug report + a fix suggestion, I don't know how I would go about directly submitting the fix

Here is a quick-easy test example for this: Bake_Action_bug.blend

Win7

There's a bug in the Bake Action operator when using it in tweak mode with NLA strps.
When the strip is moved to a different location and you want to Overwrite the Current Action, the bake will not insert the keyframes relative to the strip's offset.

This image in order from top to bottom shows the current action in the NLA editor:

Action in tweak mode
Action's base keyframe locations
Baked action's result
Baked action in tweak mode

I don't know why the code is setup the way it is but an easy fix for this is to (only disable tweak mode and specify active animation.action if use_current_action is False).

"..\2.79\scripts\startup\bl_operators\anim.py"
"..\2.79\scripts\modules\bpy_extras\anim_utils.py"
Line #247
Simply change it from:

    if action is None:
        action = bpy.data.actions.new("Action")

    # Leave tweak mode before trying to modify the action (T48397)
    if atd.use_tweak_mode:
        atd.use_tweak_mode = False

    atd.action = action

to

    if action is None:
        action = bpy.data.actions.new("Action")

        # Leave tweak mode before trying to modify the action (T48397)
        if atd.use_tweak_mode:
            atd.use_tweak_mode = False

        atd.action = action

This will:

use the tweak mode action
insert keyframes in the correct relative/offset positions.
not force exit of tweak mode

*Note: this is a bug report + a fix suggestion, I don't know how I would go about directly submitting the fix* Here is a quick-easy test example for this: [Bake_Action_bug.blend](https://archive.blender.org/developer/F5022472/Bake_Action_bug.blend) Win7 There's a bug in the Bake Action operator when using it in tweak mode with NLA strps. When the strip is moved to a different location and you want to Overwrite the Current Action, the bake will not insert the keyframes relative to the strip's offset. ![bake_offset.png](https://archive.blender.org/developer/F5022228/bake_offset.png) This image in order from top to bottom shows the current action in the NLA editor: - Action in tweak mode - Action's base keyframe locations - Baked action's result - Baked action in tweak mode I don't know why the code is setup the way it is but an easy fix for this is to *(only disable tweak mode and specify active animation.action if use_current_action is False)*. > "..\2.79\scripts\startup\bl_operators\anim.py" > "..\2.79\scripts\modules\bpy_extras\anim_utils.py" > Line #247 > Simply change it from: ``` if action is None: action = bpy.data.actions.new("Action") # Leave tweak mode before trying to modify the action (T48397) if atd.use_tweak_mode: atd.use_tweak_mode = False atd.action = action ``` to ``` if action is None: action = bpy.data.actions.new("Action") # Leave tweak mode before trying to modify the action (T48397) if atd.use_tweak_mode: atd.use_tweak_mode = False atd.action = action ``` This will: - use the tweak mode action - insert keyframes in the correct relative/offset positions. - not force exit of tweak mode

¿? commented

2018-10-11 08:46:48 +02:00

Added subscriber: @Ebone