Grease Pencil: Draw operator always capture tools #57527

New Issue

Campbell Barton · 2018-10-31T00:13:04+01:00

Campbell Barton commented

2018-10-31 00:13:04 +01:00

Note: original text by @antoniov

Related to #55420, when I add a new tool to the toolbar, in this case 3D cursor tool to set cursor position, the tool is enabled, but the grease pencil draw operator capture the event before and instead to get a new position of the 3D cursor, what you get is a new stroke on screen.

*Note: original text by @antoniov* Related to #55420, when I add a new tool to the toolbar, in this case 3D cursor tool to set cursor position, the tool is enabled, but the grease pencil draw operator capture the event before and instead to get a new position of the 3D cursor, what you get is a new stroke on screen.

Campbell Barton self-assigned this 2018-10-31 00:13:04 +01:00

Campbell Barton commented

2018-10-31 00:13:04 +01:00

Added subscribers: @antoniov, @ideasman42, @WilliamReynish, @Djay

Campbell Barton commented

2018-10-31 00:13:55 +01:00

Removed subscribers: @Djay, @WilliamReynish

Antonio Vazquez commented

2018-11-03 17:33:07 +01:00

@ideasman42 I have added (try) new tools to the draw toolbar, but the tools do not work. I guess all is related to this issue

This is the code I tested:

diff --git a/release/scripts/startup/bl_ui/space_toolsystem_toolbar.py b/release/scripts/startup/bl_ui/space_toolsystem_toolbar.py
index d5019d1..1fa67ec 100644
--- a/release/scripts/startup/bl_ui/space_toolsystem_toolbar.py
+++ b/release/scripts/startup/bl_ui/space_toolsystem_toolbar.py
@@ -1393,6 +1393,45 @@ class _defs_gpencil_paint:
             ),
         )
 
+    @ToolDef.from_fn
+    def line():
+        return dict(
+            text="Line",
+            icon="ops.gpencil.primitive_line",
+            widget=None,
+            keymap=(
+                ("gpencil.primitive",
+                 dict(type='LINE'),
+                 dict(type='EVT_TWEAK_A', value='ANY')),
+            ),
+        )
+
+    @ToolDef.from_fn
+    def box():
+        return dict(
+            text="Box",
+            icon="ops.gpencil.primitive_box",
+            widget=None,
+            keymap=(
+                ("gpencil.primitive",
+                 dict(type='BOX'),
+                 dict(type='EVT_TWEAK_A', value='ANY')),
+            ),
+        )
+
+    @ToolDef.from_fn
+    def circle():
+        return dict(
+            text="Circle",
+            icon="ops.gpencil.primitive_circle",
+            widget=None,
+            keymap=(
+                ("gpencil.primitive",
+                 dict(type='CIRCLE'),
+                 dict(type='EVT_TWEAK_A', value='ANY')),
+            ),
+        )
+
 
 class _defs_gpencil_edit:
     @ToolDef.from_fn
@@ -2012,7 +2051,13 @@ class VIEW3D_PT_tools_active(ToolSelectPanelHelper, Panel):
             _defs_weight_paint.gradient,
         ],
         'GPENCIL_PAINT': [
+            _defs_view3d_generic.cursor,
+            None,
             _defs_gpencil_paint.generate_from_brushes,
+            None,
+            _defs_gpencil_paint.line,
+            _defs_gpencil_paint.box,
+            _defs_gpencil_paint.circle,
         ],
         'GPENCIL_EDIT': [
             _defs_view3d_generic.cursor,

When this problem is solved, I can apply this patch for the toolbar, no?

@ideasman42 I have added (try) new tools to the draw toolbar, but the tools do not work. I guess all is related to this issue This is the code I tested: ![image.png](https://archive.blender.org/developer/F5353113/image.png) ``` diff --git a/release/scripts/startup/bl_ui/space_toolsystem_toolbar.py b/release/scripts/startup/bl_ui/space_toolsystem_toolbar.py index d5019d1..1fa67ec 100644 --- a/release/scripts/startup/bl_ui/space_toolsystem_toolbar.py +++ b/release/scripts/startup/bl_ui/space_toolsystem_toolbar.py @@ -1393,6 +1393,45 @@ class _defs_gpencil_paint: ), ) + @ToolDef.from_fn + def line(): + return dict( + text="Line", + icon="ops.gpencil.primitive_line", + widget=None, + keymap=( + ("gpencil.primitive", + dict(type='LINE'), + dict(type='EVT_TWEAK_A', value='ANY')), + ), + ) + + @ToolDef.from_fn + def box(): + return dict( + text="Box", + icon="ops.gpencil.primitive_box", + widget=None, + keymap=( + ("gpencil.primitive", + dict(type='BOX'), + dict(type='EVT_TWEAK_A', value='ANY')), + ), + ) + + @ToolDef.from_fn + def circle(): + return dict( + text="Circle", + icon="ops.gpencil.primitive_circle", + widget=None, + keymap=( + ("gpencil.primitive", + dict(type='CIRCLE'), + dict(type='EVT_TWEAK_A', value='ANY')), + ), + ) + class _defs_gpencil_edit: @ToolDef.from_fn @@ -2012,7 +2051,13 @@ class VIEW3D_PT_tools_active(ToolSelectPanelHelper, Panel): _defs_weight_paint.gradient, ], 'GPENCIL_PAINT': [ + _defs_view3d_generic.cursor, + None, _defs_gpencil_paint.generate_from_brushes, + None, + _defs_gpencil_paint.line, + _defs_gpencil_paint.box, + _defs_gpencil_paint.circle, ], 'GPENCIL_EDIT': [ _defs_view3d_generic.cursor, ``` When this problem is solved, I can apply this patch for the toolbar, no?

Antonio Vazquez commented

2018-11-03 17:35:42 +01:00

Added subscribers: @mendio, @billrey, @pepe-school-land

Antonio Vazquez commented

2018-11-03 17:35:42 +01:00

@billrey @mendio @pepe-school-land This is the pending Toolbar new design. I think we will need icons.

When Campbell fix the issue, I can apply the patch and remove the shapes menu.

@billrey @mendio @pepe-school-land This is the pending Toolbar new design. I think we will need icons. When Campbell fix the issue, I can apply the patch and remove the shapes menu.

Matias Mendiola commented

2018-11-03 18:49:51 +01:00

Here is a toolbar mockup for Draw Mode with the new tools:

Here is a toolbar mockup for Draw Mode with the new tools: ![Captura_09.JPG](https://archive.blender.org/developer/F5354214/Captura_09.JPG)

blender-admin commented

2018-11-12 08:47:24 +01:00

This issue was referenced by df6530594f

This issue was referenced by df6530594f02969e6fae25df38d1b947411a9a82

Campbell Barton commented

2018-11-12 08:53:14 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue