For the Sphere primitive, rename Size to Radius #57718
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#57718
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
All the paint primitives in Blender have a Radius property for setting the radius size. The Sphere primitive does too, but it is names 'Size' rather than 'Radius'.
Radius also makes more sense for spheres anyway.
Added subscribers: @WilliamReynish, @ideasman42, @RamiroCantu, @Regnas
Added subscriber: @brecht
Shouldn't it be the other way around, rename the other primitives properties to be "Size"? The Cube or Monkey having a radius is a bit odd.
Added subscriber: @DuarteRamos
E would second this, other primitives should be renamed Size, but this is still valid for spheres, Radius sounds more correct.
@brecht: At the very least for Spheres, 'Radius' is correct. The default sphere primitive has a radius of 1 but a diameter of 2. The Size property is 1, so it really is a radius.
For cube, radius is strange, but it's also a bit odd if we just change it to 'Size', because the default cube actually has a default width of 2 units. Not sure what to do there? For the monkey it definitely makes no sense for there to be a radius :)
Why not use size for sphere too? (and make it control the diameter instead of the radius).
@ideasman42: I don't mind either way, if we specify the size in radius or diameter. My main concern is that we use the correct words for things.
The current 'Size' property is really a radius, but we could also change it to use diameter instead, but then you'd have to change the value itself too.
Added subscriber: @natecraddock
I'm willing to give this one a shot since I'm interested in helping with development and it seems pretty simple. Should I just change the add sphere operator, or should I wait for further discussion on changing other operators to be more consistent?
Hi @Zachman.
I think we should do it like this:
UV Sphere: Radius
Ico Sphere: Radius
Cylinder: Radius (is already the case)
Circle Radius (is already the case)
Cone: Radius (is already the case)
Torus: Radius (is already the case)
Grid: Size
Cube: Size
Monkey: Size
etc.
In other words, for all spheres or circles or cylinders, we use Radius. For everything else we use Size.
Added subscriber: @thornydre
For the monkey, at the moment it is Radius, and the default value is 1, if it is changed to Size, does the value have to be changed to 2 then ?
@thornydre I'm not sure. @brecht @ideasman42 what do you think?
@thornydre I think it would be the same for adding a cube (and grid, plane, even things like a bezier curve and a metaball plane), it would make sense for the size of the cube to reflect the length of a side, not the radius.
Also, should these changes only show in the labels? Or should it be reflected in the python API? I think if the kwargs for the operators are going to change now is the best time.
@WilliamReynish +1 for you're suggestion.
I made the patch! D3943
Should this process be repeated for Curves, Metaballs, Grease Pencil, Bones, Empties, Lattice, Area Lights, Light probes, and force fields? If so, it might make more sense to switch the default dimension unit label from Radius to Size because it seems like most created objects would have a size and the few circular objects would have a radius as the exception.
Changed status from 'Open' to: 'Resolved'