blender/blender
blender/blender
193
608
Fork 954
Code Issues 6.4k Pull Requests 1.1k Projects 22 Wiki Activity

Triangle count is incorrect when above around 2 billion #57884

New Issue
Closed
opened 2018-11-17 01:45:26 +01:00 by Carlo Andreacchio · 16 comments
Carlo Andreacchio commented 2018-11-17 01:45:26 +01:00
Copy Link

System Information
Ubuntu 17.10

Blender Version
Broken: 2c347ebbba

Short description of error
Triangle count is incorrect when its too large

Exact steps for others to reproduce the error

  1. Get high resolution tree and make it into bounding box mode
  2. create particle plane
  3. increase particle count until the triangles get above 2billion approximately
  4. notice how the number of triangles goes into the negative.

This happens on production scenes -- Selection_079.png

**System Information** Ubuntu 17.10 **Blender Version** Broken: 2c347ebbba9 **Short description of error** Triangle count is incorrect when its too large **Exact steps for others to reproduce the error** 1. Get high resolution tree and make it into bounding box mode 2. create particle plane 3. increase particle count until the triangles get above 2billion approximately 4. notice how the number of triangles goes into the negative. This happens on production scenes -- ![Selection_079.png](https://archive.blender.org/developer/F5592631/Selection_079.png)
Carlo Andreacchio commented 2018-11-17 01:45:26 +01:00
Author
Copy Link

Added subscriber: @candreacchio

Added subscriber: @candreacchio
Carlo Andreacchio commented 2018-11-17 02:23:38 +01:00
Author
Copy Link

This is actually a problem on verts and faces aswell, not just tris.

This is actually a problem on verts and faces aswell, not just tris.
Stephen Swaney commented 2018-11-18 15:38:39 +01:00
Copy Link

Added subscriber: @StephenSwaney

Added subscriber: @StephenSwaney
Stephen Swaney commented 2018-11-18 15:38:39 +01:00
Copy Link

Please attach a .blend showing the problem.

This sounds like integer overflow.
A signed integer has a maximum value of roughly 2,000,000,000. Go over that and you get negative numbers.

  - MISSING INFO

Please follow our submission template and guidelines and make a complete, valid bug report, with required info, precise description of the issue, precise steps to reproduce it, small and simple .blend and/or other files to do so if needed, etc.

A guideline for making a good bug report can be found here: https://wiki.blender.org/wiki/Process/Bug_Reports

Marking as "Incomplete" until the requested information/data is provided.

Please attach a .blend showing the problem. This sounds like integer overflow. A signed integer has a maximum value of roughly 2,000,000,000. Go over that and you get negative numbers. - MISSING INFO Please follow our submission template and guidelines and make a complete, valid bug report, with required info, precise description of the issue, precise steps to reproduce it, small and simple .blend and/or other files to do so if needed, etc. A guideline for making a good bug report can be found here: https://wiki.blender.org/wiki/Process/Bug_Reports Marking as "Incomplete" until the requested information/data is provided.
Carlo Andreacchio commented 2018-11-18 22:12:57 +01:00
Author
Copy Link

Probably not the most efficient bug blend, but its there. make sure you have enough ram to open the file (not a problem in blender 2.7)

overflow.blend

Probably not the most efficient bug blend, but its there. make sure you have enough ram to open the file (not a problem in blender 2.7) [overflow.blend](https://archive.blender.org/developer/F5624873/overflow.blend)
Philipp Oeser commented 2018-11-19 12:16:08 +01:00
Member
Copy Link

Added subscribers: @Sergey, @lichtwerk

Added subscribers: @Sergey, @lichtwerk
Sergey Sharybin was assigned by Philipp Oeser 2018-11-19 12:16:08 +01:00
Philipp Oeser commented 2018-11-19 12:16:08 +01:00
Member
Copy Link

Overflow confirmed.

@Sergey: does this have to be changed to long (or whatever) all over the place? DNA_mesh_types etc?

Overflow confirmed. @Sergey: does this have to be changed to long (or whatever) all over the place? DNA_mesh_types etc?
Sergey Sharybin commented 2018-11-19 12:42:21 +01:00
Owner
Copy Link

Never use long! It is platform specific and different on different OS/bitnesses. Use uint64_t in the statistics. Doing this in DNA_mesh_types is hell of a lot of work, which will involve modifying all the areas which loops and indices those.

Quite sure avoiding overflow in stats will solve 99% of cases. And quite sure once you've got mesh with more than 2B vertices you'll have other issues.

P.S. Do you expect me to work on this?

Never use `long`! It is platform specific and different on different OS/bitnesses. Use `uint64_t` in the statistics. Doing this in DNA_mesh_types is hell of a lot of work, which will involve modifying all the areas which loops and indices those. Quite sure avoiding overflow in stats will solve 99% of cases. And quite sure once you've got mesh with more than 2B vertices you'll have other issues. P.S. Do you expect me to work on this?
Carlo Andreacchio commented 2018-11-19 12:47:56 +01:00
Author
Copy Link

This isn't to do with one mesh but a scene... I opened our production scenes from blender 2.7 in 2.8 and it's reporting it.

The difference lies with 2.8 counting each particle instance in the tri /vert / face count rather than discounting it entirely.

Not sure who should work on it but it does occur in normal scenes for us.

If any more info is needed please let us know and we will clarify as soon as possible

Carlo

This isn't to do with one mesh but a scene... I opened our production scenes from blender 2.7 in 2.8 and it's reporting it. The difference lies with 2.8 counting each particle instance in the tri /vert / face count rather than discounting it entirely. Not sure who should work on it but it does occur in normal scenes for us. If any more info is needed please let us know and we will clarify as soon as possible Carlo
Sergey Sharybin was unassigned by Philipp Oeser 2018-11-19 13:07:59 +01:00
Philipp Oeser commented 2018-11-19 13:07:59 +01:00
Member
Copy Link

think I checked and me_eval->totloop was overflowing already, but will have a second look...

think I checked and `me_eval->totloop` was overflowing already, but will have a second look...
Sergey Sharybin commented 2018-11-19 13:27:57 +01:00
Owner
Copy Link

@lichtwerk if that thing is overflowing, then drawing will not be correct. And the modifiers, or anything. That's very weird and dangerous if that thing is overflown.

@lichtwerk if that thing is overflowing, then drawing will not be correct. And the modifiers, or anything. That's very weird and dangerous if that thing is overflown.
Philipp Oeser commented 2018-11-19 13:31:17 +01:00
Member
Copy Link

@Sergey: yep, my bad (will stand in the corner for a while...), was something else overflown, checking this again atm...

@Sergey: yep, my bad (will stand in the corner for a while...), was something else overflown, checking this again atm...
Sergey Sharybin commented 2018-11-19 13:42:22 +01:00
Owner
Copy Link

@lichtwerk, my bet would be on SceneStats from info_stats.c. Change int to uint64_t would be the first step. Second one would be to ensure correct format in SCENE_STATS_FMT_INT is used.

@lichtwerk, my bet would be on `SceneStats` from `info_stats.c`. Change `int` to `uint64_t` would be the first step. Second one would be to ensure correct format in `SCENE_STATS_FMT_INT` is used.
blender-admin commented 2018-11-19 15:24:32 +01:00
Copy Link

This issue was referenced by cec83e92e6

This issue was referenced by cec83e92e6160adf1e39e0173c77743cb1ff1be7
Philipp Oeser commented 2018-11-19 15:27:07 +01:00
Member
Copy Link

I had a go in D3962

I had a go in [D3962](https://archive.blender.org/developer/D3962)
Philipp Oeser commented 2018-11-21 16:41:19 +01:00
Member
Copy Link

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Asset datablocks, libraries, browser and shelf
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Code comments, Python/RNA API descriptions
Interest
Collada
Interest
Compatibility
Backward and forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
FBX I/O related topics
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms & Builds
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Wayland windowing on Unix
Interest
Workbench
Interest
glTF
glTF format I/O topics
Interest: X11
Xorg/X11 windowing
Legacy
Asset Browser Project
Archived
Legacy
Blender 2.8 Project
Archived
Legacy
Milestone 1: Basic, Local Asset Browser
Archived
Legacy
OpenGL Error
Archived
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms & Builds
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Archived
Type
Report
Archived
Type
To Do
No Label
Legacy
Blender 2.8 Project
Severity
Normal
Status
Resolved
Type
Report
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Hoshinova James-McCarthy-4 Sebastian-Herholz casey-bianco-davis gandalf3 Blendify Aaron Carlisle quantimoney Aditya Y Jeppu Alaska Alaska angavrilov Alexander Gavrilov frogstomp Aleš Jelovčan amelief Amélie Fondevilla elubie Andrea Weikert Andy_Goralczyk Andy Goralczyk ankitm Ankit Meel Anthony-Roberts Anthony Roberts antoniov Antonio Vazquez aras_p Aras Pranckevicius Arnd Arnd Marijnissen bartvdbraak Bart van der Braak mont29 Bastien Montagne blender-bot Blender Bot bnagirniak Bogdan Nagirniak BClark Brad Clark brecht Brecht Van Lommel BrianSavery Brian Savery (AMD) ideasman42 Campbell Barton CharlesWardlaw Charles Wardlaw CharlieJolly Charlie Jolly Chris_Blackbourn Chris Blackbourn lateasusual Chris Clyne (Lateasusual) ChrisLend Christoph Lendenfeld HobbesOS Cian Jinks fclem Clément Foucault cmbasnett Colin Basnett Kdaf Colin Marmond dfelinto Dalai Felinto pioverfour Damien Picard DanielBystedt Daniel Bystedt pepe-school-land Daniel Martinez Lara zanqdo Daniel Salazar Mets Demeter Dzadik erik85 Erik Abrahamsson EAW Evan Wilson filedescriptor Falk David fsiddi Francesco Siddi GaiaClary Gaia Clary DagerD Georgiy Markelov mano-wii Germano Cavalcante zazizizou Habib Gahbiche HooglyBoogly Hans Goudey Harley Harley Acheson weasel Henrik D. Hjalti Hjalti Hjálmarsson howardt Howard Trickey nirved-1 Hristo Gueorguiev mod_moder Iliya Katushenock brita Inês Almeida JacquesLucke Jacques Lucke Jason-Fielder Jason Fielder JasonSchleifer Jason schleifer Jebbly Jeffrey Liu Jeroen-Bakker Jeroen Bakker deadpin Jesse Yurkovich neXyon Joerg Mueller eliphaz John Kiril Swenson guitargeek Johnny Matthews Brainzman Jonas Holzman JoniMercado Jonatan Mercado JorgeBernalMartinez Jorge Bernal JosephEagar Joseph Eagar JoshuaLeung Joshua Leung Bone-Studio Juan Gea jpbouza-4 Juan Pablo Bouza JulianEisel Julian Eisel JulienDuroure Julien Duroure JulienKaspar Julien Kaspar kevindietrich Kévin Dietrich lone_noel Leon Schittek LucianoMunoz Luciano Muñoz Sessarego LukasStockner Lukas Stockner LukasTonne Lukas Tönne LunaRood Luna Rood MaiLavelle Mai Lavelle EosFoxx Marion Stalke Baardaap Martijn Versteegh scorpion81 Martin Felke mendio Matias Mendiola Matt-McLin Matt McLin MetinSeven Metin Seven wave Michael B Johnson Michael-Jones Michael Jones (Apple) makowalski Michael Kowalski pragma37 Miguel Pozo nrupsis Nate Rupsis jesterking Nathan Letwory nathanvegdahl Nathan Vegdahl PrototypeNM1 Nicholas Rishel nickberckley Nika Kutsniashvili Sirgienko Nikita Sirgienko OmarEmaraDev Omar Emara pablovazquez Pablo Vazquez PaoloAcampora Paolo Acampora PascalSchon Pascal Schön pmoursnv Patrick Mours muxed-reality Peter Kim lichtwerk Philipp Oeser P2design Pierrick PICAUT PratikPB2123 Pratik Borhade Limarest Ramil Roosileht farsthary Raul Fernandez Hernandez LazyDodo Ray molenkamp iss Richard Antalik rjg Robert Guetzkow salipour Sahar A. Kashi Sayak-Biswas Sayak Biswas Sean-Kim Sean Kim sherholz Sebastian Herholz sebastian_k Sebastian Koenig ZedDB Sebastian Parborg sebbas Sebastián Barschkis Sergey Sergey Sharybin IRIEShinsuke Shinsuke Irie sidd017 Siddhartha Jejurkar SietseB Sietse Brouwer SimonThommes Simon Thommes SonnyCampbell_Unity Sonny Campbell Stefan_Werner Stefan Werner Lockal Sv. Lockal dr.sybren Sybren A. Stüvel ThomasDinges Thomas Dinges Ton Ton Roosendaal BassamKurdali Ursula kurdali Vasyl-Pidhirskyi Vasyl Pidhirskyi WannesMalfait Wannes Malfait wbmoss_dev Wayde Moss weizhen Weizhen Huang leesonw William Leeson xavierh Xavier Hallade jenkm Yevgeny Makarov ChengduLittleA YimingWu gfxcoder jon denning
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#57884
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?