Workbench: stack-buffer-overflow after recent lighting evaluation changes #57952

New Issue

Sergey Sharybin · 2018-11-20T09:59:14+01:00

Sergey Sharybin commented

2018-11-20 09:59:14 +01:00

System Information

Debian Buster 64bit, GTX1080 390.87

Blender Version
Broken: 640eb00670
Worked: anything prior to 7bb512594c

Short description of error

Stack buffer overflow happens due to either wrong size or wrong indexing, very easy to see with ASAN.

Exact steps for others to reproduce the error

Compile with ASAN, run blender --factory-startup simple_file.blend and observe the following: P827: (An Untitled Masterwork)

=================================================================
==42019==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffd6dff040 at pc 0x561b7bad08aa bp 0x7fffd6dfef60 sp 0x7fffd6dfef58
READ of size 4 at 0x7fffd6dff040 thread T0
    #0 0x561b7bad08a9 in mul_v3_v3fl /home/sergey/src/blender/blender/source/blender/blenlib/intern/math_vector_inline.c:436
    #1 0x561b7bad72bf in studiolight_spherical_harmonics_apply_band_factors /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:643
    #2 0x561b7bad741a in studiolight_calculate_diffuse_light /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:659
    #3 0x561b7bada340 in BKE_studiolight_ensure_flag /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:1137
    #4 0x561b7bad7973 in studiolight_calculate_irradiance_equirect_image /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:780
    #5 0x561b7bada39b in BKE_studiolight_ensure_flag /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:1148
    #6 0x561b7bad48fd in studiolight_create_equirect_irradiance_gputexture /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:297
    #7 0x561b7bada370 in BKE_studiolight_ensure_flag /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:1144
    #8 0x561b7b118f37 in EEVEE_lookdev_cache_init /home/sergey/src/blender/blender/source/blender/draw/engines/eevee/eevee_lookdev.c:126
    #9 0x561b7b11efb7 in EEVEE_materials_cache_init /home/sergey/src/blender/blender/source/blender/draw/engines/eevee/eevee_materials.c:967
    #10 0x561b7b0e9585 in eevee_cache_init /home/sergey/src/blender/blender/source/blender/draw/engines/eevee/eevee_engine.c:119
    #11 0x561b7b07985e in drw_engines_cache_init /home/sergey/src/blender/blender/source/blender/draw/intern/draw_manager.c:939
    #12 0x561b7b07b9f3 in DRW_draw_render_loop_ex /home/sergey/src/blender/blender/source/blender/draw/intern/draw_manager.c:1423
    #13 0x561b7b07b59f in DRW_draw_view /home/sergey/src/blender/blender/source/blender/draw/intern/draw_manager.c:1367
    #14 0x561b793ff41a in view3d_draw_view /home/sergey/src/blender/blender/source/blender/editors/space_view3d/view3d_draw.c:1319
    #15 0x561b793ff512 in view3d_main_region_draw /home/sergey/src/blender/blender/source/blender/editors/space_view3d/view3d_draw.c:1340
    #16 0x561b79ff3d54 in ED_region_do_draw /home/sergey/src/blender/blender/source/blender/editors/screen/area.c:529
    #17 0x561b790e9d56 in wm_draw_window_offscreen /home/sergey/src/blender/blender/source/blender/windowmanager/intern/wm_draw.c:572
    #18 0x561b790ea893 in wm_draw_window /home/sergey/src/blender/blender/source/blender/windowmanager/intern/wm_draw.c:698
    #19 0x561b790eb2d9 in wm_draw_update /home/sergey/src/blender/blender/source/blender/windowmanager/intern/wm_draw.c:852
    #20 0x561b790e35f3 in WM_main /home/sergey/src/blender/blender/source/blender/windowmanager/intern/wm.c:433
    #21 0x561b790d8d8d in main /home/sergey/src/blender/blender/source/creator/creator.c:525
    #22 0x7f75269ecb16 in __libc_start_main ../csu/libc-start.c:310
    #23 0x561b790d8169 in _start (/home/sergey/src/blender/build/cmake-debug/bin/blender+0x39e3169)

simple_file.blend

**System Information** Debian Buster 64bit, GTX1080 390.87 **Blender Version** Broken: 640eb00670 Worked: anything prior to 7bb512594c **Short description of error** Stack buffer overflow happens due to either wrong size or wrong indexing, very easy to see with ASAN. **Exact steps for others to reproduce the error** Compile with ASAN, run `blender --factory-startup simple_file.blend` and observe the following: [P827: (An Untitled Masterwork)](https://archive.blender.org/developer/P827.txt) ``` ================================================================= ==42019==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffd6dff040 at pc 0x561b7bad08aa bp 0x7fffd6dfef60 sp 0x7fffd6dfef58 READ of size 4 at 0x7fffd6dff040 thread T0 #0 0x561b7bad08a9 in mul_v3_v3fl /home/sergey/src/blender/blender/source/blender/blenlib/intern/math_vector_inline.c:436 #1 0x561b7bad72bf in studiolight_spherical_harmonics_apply_band_factors /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:643 #2 0x561b7bad741a in studiolight_calculate_diffuse_light /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:659 #3 0x561b7bada340 in BKE_studiolight_ensure_flag /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:1137 #4 0x561b7bad7973 in studiolight_calculate_irradiance_equirect_image /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:780 #5 0x561b7bada39b in BKE_studiolight_ensure_flag /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:1148 #6 0x561b7bad48fd in studiolight_create_equirect_irradiance_gputexture /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:297 #7 0x561b7bada370 in BKE_studiolight_ensure_flag /home/sergey/src/blender/blender/source/blender/blenkernel/intern/studiolight.c:1144 #8 0x561b7b118f37 in EEVEE_lookdev_cache_init /home/sergey/src/blender/blender/source/blender/draw/engines/eevee/eevee_lookdev.c:126 #9 0x561b7b11efb7 in EEVEE_materials_cache_init /home/sergey/src/blender/blender/source/blender/draw/engines/eevee/eevee_materials.c:967 #10 0x561b7b0e9585 in eevee_cache_init /home/sergey/src/blender/blender/source/blender/draw/engines/eevee/eevee_engine.c:119 #11 0x561b7b07985e in drw_engines_cache_init /home/sergey/src/blender/blender/source/blender/draw/intern/draw_manager.c:939 #12 0x561b7b07b9f3 in DRW_draw_render_loop_ex /home/sergey/src/blender/blender/source/blender/draw/intern/draw_manager.c:1423 #13 0x561b7b07b59f in DRW_draw_view /home/sergey/src/blender/blender/source/blender/draw/intern/draw_manager.c:1367 #14 0x561b793ff41a in view3d_draw_view /home/sergey/src/blender/blender/source/blender/editors/space_view3d/view3d_draw.c:1319 #15 0x561b793ff512 in view3d_main_region_draw /home/sergey/src/blender/blender/source/blender/editors/space_view3d/view3d_draw.c:1340 #16 0x561b79ff3d54 in ED_region_do_draw /home/sergey/src/blender/blender/source/blender/editors/screen/area.c:529 #17 0x561b790e9d56 in wm_draw_window_offscreen /home/sergey/src/blender/blender/source/blender/windowmanager/intern/wm_draw.c:572 #18 0x561b790ea893 in wm_draw_window /home/sergey/src/blender/blender/source/blender/windowmanager/intern/wm_draw.c:698 #19 0x561b790eb2d9 in wm_draw_update /home/sergey/src/blender/blender/source/blender/windowmanager/intern/wm_draw.c:852 #20 0x561b790e35f3 in WM_main /home/sergey/src/blender/blender/source/blender/windowmanager/intern/wm.c:433 #21 0x561b790d8d8d in main /home/sergey/src/blender/blender/source/creator/creator.c:525 #22 0x7f75269ecb16 in __libc_start_main ../csu/libc-start.c:310 #23 0x561b790d8169 in _start (/home/sergey/src/blender/build/cmake-debug/bin/blender+0x39e3169) ``` [simple_file.blend](https://archive.blender.org/developer/F5648131/simple_file.blend)

Sergey Sharybin commented

2018-11-20 09:59:14 +01:00

Added subscriber: @Sergey

Clément Foucault was assigned by Sergey Sharybin

2018-11-20 09:59:42 +01:00

Clément Foucault commented

2018-11-20 13:31:33 +01:00

Closed as duplicate of #57948

Clément Foucault closed this issue

2018-11-20 13:31:33 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Workbench: stack-buffer-overflow after recent lighting evaluation changes #57952