Page MenuHome

Keyframing one transform option reset other transforms
Closed, ResolvedPublic

Description

System Information
Operating system: Windows 10
Graphics card: 2x 1080 Ti

Blender Version
Broken: 2.80, 1b6a394d862, 2018-12-03 23:39

Short description of error
If you have an animated object, lets say location and rotation have keyframes, and you animate (not keyframe) both location and rotation further down the line, and then decide to keyframe location by Shortcut I -> Location or Right Click on the property, the other property gets reset to the last known value.
Yes I could keyframe both properties at the same time but that behavior is still odd.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

Event Timeline

Sebastian Parborg (zeddb) triaged this task as Confirmed, Medium priority.

This did not happen in 2.79. So this is a regression.

Posting the video of the problem as suggested by @Jacques Lucke (JacquesLucke).
Just to clarify this is not limited to location only.

T61173#628747 has some analysis of the problem.

Animation is being evaluated after inserting a keyframe, since rB06357b23a2a4: Fix T55404: Auto key with only-available doesn't work. I think we need a way to DEG tag an action datablock to say that it needs copy-on-write without evaluating animation, and use that for inserting and deleting keyframes. For other cases like graph editor keyframe editing we still need to tag for both copy-on-write and animation evaluation.

CC @Sergey Sharybin (sergey)

@Brecht Van Lommel (brecht), think proper solution is something like this P937

Short description:

  • Don't use ID_RECALC_COPY_ON_WRITE unless ABSOLUTELY needed. There are better suitable flags, and tagging should not really depend on a specifics of dependency graph behavior.
  • Introduce recalc flag ID_RECALC_ANIMATION_BLOCK which internally does Copy-on-Write,making sure all datablocks are a relevant state, but does not force animation to be evaluated.

Used in aniomation edits which are adding/removing f-curves, without affecting on the current value of corresponding property.

  • Use ID_RECALC_ANIMATION when animation is to be re-evaluated. For example, when adding/removing f-curve modifier.

I did my best updating the tagging in animation editor folder, but don't mind if someone else have a second look at the changes.

Seems reasonable.

Perhaps ID_RECALC_ANIMATION_BLOCK can be renamed to ID_RECALC_ANIMATION_COPY_ONLY or ID_RECALC_ANIMATION_NO_EVAL? The BLOCK name doesn't really tell me anything.

I think the DEG_id_tag calls in rna_fcurve.c and rna_action.c need to be updated still?