Python 3 syntax errors #61332

New Issue

Chris Clauss · 2019-02-08T17:28:34+01:00

Chris Clauss commented

2019-02-08 17:28:34 +01:00

System Information
Operating system: ALL
Graphics card: ALL

Blender Version
Broken: GIT MASTER
(example: 2.79b release)
(example: 2.80, edbf15d3c0, blender2.8, 2018-11-28, as found on the splash screen)
Worked: (optional)

Short description of error

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./build_files/package_spec/build_archive.py:32:17: E999 SyntaxError: invalid syntax
except Exception, ex:
                ^
./source/blender/python/simple_enum_gen.py:42:38: E999 SyntaxError: invalid syntax
print '\tmod = PyModule_New("dummy");'
                                     ^

**System Information** Operating system: ALL Graphics card: ALL **Blender Version** Broken: GIT MASTER (example: 2.79b release) (example: 2.80, edbf15d3c044, blender2.8, 2018-11-28, as found on the splash screen) Worked: (optional) **Short description of error** **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). $ **flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics** ``` ./build_files/package_spec/build_archive.py:32:17: E999 SyntaxError: invalid syntax except Exception, ex: ^ ./source/blender/python/simple_enum_gen.py:42:38: E999 SyntaxError: invalid syntax print '\tmod = PyModule_New("dummy");' ^ ```

Chris Clauss commented

2019-02-08 17:28:34 +01:00

Added subscriber: @ccc-4

Chris Clauss commented

2019-02-08 17:43:55 +01:00

Legacy print statements are syntax errors in Python 3 but print() function works as expected in both Python 2 and Python 3.

Old style exceptions are syntax errors in Python 3 but new style exceptions work as expected in both Python 2 and Python 3.

https:*github.com/sobotka/blender/pull/3 and https:*github.com/sobotka/blender/pull/4 contain the required fixes.

I tried to follow the instructions at https://wiki.blender.org/wiki/Tools/Git to submit a pull request but they do not work because they assume write access to the repo. The Commit Access section should really be rewritten because the developers that have write access to the repo probably do not need instructions. First-time contributors who do not have write access and can not succeed at making a pull request will probably go work on other projects.

Legacy __print__ statements are syntax errors in Python 3 but __print()__ function works as expected in both Python 2 and Python 3. Old style exceptions are syntax errors in Python 3 but new style exceptions work as expected in both Python 2 and Python 3. https:*github.com/sobotka/blender/pull/3 and https:*github.com/sobotka/blender/pull/4 contain the required fixes. I tried to follow the instructions at https://wiki.blender.org/wiki/Tools/Git to submit a pull request but they do not work because they assume **write access** to the repo. The **Commit Access** section should really be rewritten because the developers that have write access to the repo probably do not need instructions. First-time contributors who do not have write access and can not succeed at making a pull request will probably go work on other projects.

Jacques Lucke commented

2019-02-08 17:58:04 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-02-08 17:58:04 +01:00

Changed status from 'Open' to: 'Archived'

Jacques Lucke closed this issue

2019-02-08 17:58:04 +01:00

Jacques Lucke self-assigned this 2019-02-08 17:58:04 +01:00

Jacques Lucke commented

2019-02-08 17:58:04 +01:00

There is a "Submit Code" button on the https://developer.blender.org/ front page.

You can upload your diff here: https://developer.blender.org/differential/diff/create/

There is a "Submit Code" button on the https://developer.blender.org/ front page. You can upload your diff here: https://developer.blender.org/differential/diff/create/

Chris Clauss commented

2019-02-08 21:26:49 +01:00

What exactly was archived in this case? The whole repo? These two files? The syntax errors? Or just the bug report itself? https://developer.blender.org/D4326

What exactly was *archived* in this case? The whole repo? These two files? The syntax errors? Or just the bug report itself? https://developer.blender.org/D4326

Jacques Lucke commented

2019-02-08 22:27:59 +01:00

It just means that this report ist closed. Nothing else. Thanks for the patch. Will take a closer look at it on monday.

blender-admin commented

2019-02-09 03:07:34 +01:00

This issue was referenced by 7262ac6202

This issue was referenced by 7262ac6202eb9258293473f35a24f375f9d6f635

Campbell Barton commented

2019-02-09 03:13:26 +01:00

Changed status from 'Archived' to: 'Resolved'

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Python 3 syntax errors #61332