Crash switching workspace with fullscreen area #61512

Closed
opened 2019-02-13 14:28:27 +01:00 by Juha Keränen · 10 comments

System Information
Operating system: Windows 10 Pro
Graphics card: GTX 970 AMP Omega

Blender Version
Broken: 2.80 d2970471edd7

Short description of error
If I create a new Window and set the new window to Maximize Area with Ctrl+Spacebar and then change the Mode of the main window to anything (Sculpting, Texture Paint etc.) Then I get a crash.

It doesn't crash every time depending on some actions that I do, but it's pretty consistent.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

  1. Window > New Window
  2. (in new window) View > Area > Toggle Maximize Area
  3. (in main window) Change mode to e.g. UV Editing.
**System Information** Operating system: Windows 10 Pro Graphics card: GTX 970 AMP Omega **Blender Version** Broken: 2.80 d2970471edd7 **Short description of error** If I create a new Window and set the new window to Maximize Area with Ctrl+Spacebar and then change the Mode of the main window to anything (Sculpting, Texture Paint etc.) Then I get a crash. It doesn't crash every time depending on some actions that I do, but it's pretty consistent. **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). 1. Window > New Window 2. (in new window) View > Area > Toggle Maximize Area 3. (in main window) Change mode to e.g. UV Editing.
Author

Added subscriber: @Ianuarius

Added subscriber: @Ianuarius

Added subscriber: @ZedDB

Added subscriber: @ZedDB
Brecht Van Lommel was assigned by Sebastian Parborg 2019-02-13 16:00:32 +01:00

Backtrace:

Thread 1 "blender" received signal SIGSEGV, Segmentation fault.
BKE_workspace_layout_screen_get (layout=layout@entry=0x0) at /home/zed/programmering/blender_master/blender/source/blender/blenkernel/intern/workspace.c:407
407		return layout->screen;
(gdb) bt
#0  BKE_workspace_layout_screen_get (layout=layout@entry=0x0)
    at /home/zed/programmering/blender_master/blender/source/blender/blenkernel/intern/workspace.c:407
#1  0x0000555556430feb in ED_workspace_change (workspace_new=workspace_new@entry=0x7fffe43f2808, C=C@entry=0x7fffe9458108, wm=wm@entry=0x7fffe43d0488,
    win=win@entry=0x7fffce906188) at /home/zed/programmering/blender_master/blender/source/blender/editors/screen/workspace_edit.c:157
#2  0x000055555612d268 in WM_window_set_active_workspace (C=C@entry=0x7fffe9458108, win=win@entry=0x7fffe437ff08, workspace=workspace@entry=0x7fffe43f2808)
    at /home/zed/programmering/blender_master/blender/source/blender/windowmanager/intern/wm_window.c:2281
#3  0x0000555556111785 in wm_event_do_notifiers (C=C@entry=0x7fffe9458108)
    at /home/zed/programmering/blender_master/blender/source/blender/windowmanager/intern/wm_event_system.c:409
- 4  0x00005555561078a8 in WM_main (C=0x7fffe9458108) at /home/zed/programmering/blender_master/blender/source/blender/windowmanager/intern/wm.c:420
- 5  0x00005555560f2403 in main (argc=1, argv=0x7fffffffdd28) at /home/zed/programmering/blender_master/blender/source/creator/creator.c:504
Backtrace: ``` Thread 1 "blender" received signal SIGSEGV, Segmentation fault. BKE_workspace_layout_screen_get (layout=layout@entry=0x0) at /home/zed/programmering/blender_master/blender/source/blender/blenkernel/intern/workspace.c:407 407 return layout->screen; (gdb) bt #0 BKE_workspace_layout_screen_get (layout=layout@entry=0x0) at /home/zed/programmering/blender_master/blender/source/blender/blenkernel/intern/workspace.c:407 #1 0x0000555556430feb in ED_workspace_change (workspace_new=workspace_new@entry=0x7fffe43f2808, C=C@entry=0x7fffe9458108, wm=wm@entry=0x7fffe43d0488, win=win@entry=0x7fffce906188) at /home/zed/programmering/blender_master/blender/source/blender/editors/screen/workspace_edit.c:157 #2 0x000055555612d268 in WM_window_set_active_workspace (C=C@entry=0x7fffe9458108, win=win@entry=0x7fffe437ff08, workspace=workspace@entry=0x7fffe43f2808) at /home/zed/programmering/blender_master/blender/source/blender/windowmanager/intern/wm_window.c:2281 #3 0x0000555556111785 in wm_event_do_notifiers (C=C@entry=0x7fffe9458108) at /home/zed/programmering/blender_master/blender/source/blender/windowmanager/intern/wm_event_system.c:409 - 4 0x00005555561078a8 in WM_main (C=0x7fffe9458108) at /home/zed/programmering/blender_master/blender/source/blender/windowmanager/intern/wm.c:420 - 5 0x00005555560f2403 in main (argc=1, argv=0x7fffffffdd28) at /home/zed/programmering/blender_master/blender/source/creator/creator.c:504 ```
Brecht Van Lommel changed title from Crash With Multiple Windows to Crash switch workspace with fullscreen area 2019-02-13 20:00:23 +01:00
Brecht Van Lommel changed title from Crash switch workspace with fullscreen area to Crash switching workspace with fullscreen area 2019-02-13 20:00:33 +01:00

The problem is in ED_workspace_layout_duplicate:

    if (BKE_screen_is_fullscreen_area(screen_old)) {
        return NULL; /* XXX handle this case! */
    }

It's really not acceptable to commit incomplete code like this.

The problem is in `ED_workspace_layout_duplicate`: ``` if (BKE_screen_is_fullscreen_area(screen_old)) { return NULL; /* XXX handle this case! */ } ``` It's really not acceptable to commit incomplete code like this.

Added subscriber: @dfelinto

Added subscriber: @dfelinto

Also problematic, the button to go out of fullscreen mode is nowhere to be seen in this case (since the non-main window has no topbar).
So I wonder from the design whether this was even suppose to be supported.

Also problematic, the button to go out of fullscreen mode is nowhere to be seen in this case (since the non-main window has no topbar). So I wonder from the design whether this was even suppose to be supported.

This issue was referenced by eff3728db9

This issue was referenced by eff3728db912abc1477d0e90d2a6533b61f7295f

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

@brecht if you think this is not the best solution poke me. My initial attempt was to duplicate the entire screen, with fullscreen state and all that. But that was getting too complicated to implemented.
In the end I took a simpler approach after familiarizing myself again with the fullscreen code.

@brecht if you think this is not the best solution poke me. My initial attempt was to duplicate the entire screen, with fullscreen state and all that. But that was getting too complicated to implemented. In the end I took a simpler approach after familiarizing myself again with the fullscreen code.
Author

In #61512#621378, @dfelinto wrote:
Also problematic, the button to go out of fullscreen mode is nowhere to be seen in this case (since the non-main window has no topbar).
So I wonder from the design whether this was even suppose to be supported.

In my case, I didn't access Toggle Maximize Area via the topbar, but the View menu that is also accessible in the non-main window.

> In #61512#621378, @dfelinto wrote: > Also problematic, the button to go out of fullscreen mode is nowhere to be seen in this case (since the non-main window has no topbar). > So I wonder from the design whether this was even suppose to be supported. In my case, I didn't access Toggle Maximize Area via the topbar, but the View menu that is also accessible in the non-main window.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#61512
No description provided.