Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend #61520

New Issue

Brian Swift · 2019-02-13T22:26:39+01:00

Brian Swift commented

2019-02-13 22:26:39 +01:00

System Information
Operating system: macOS 10.13.6
Graphics card: AMD Radeon R9 M370X 2048 MB

Blender Version
Broken: 2.80 2019-02-13
Worked: 2.79b 2018-03-22

Short description of error
When the attached .blend file (created in 2.79b) is opened in 2.80 2019-02-13
the the compositor Render Layer nodes have wrong scene render layers.
The attached screen shots highlight the issue.

Exact steps for others to reproduce the error
Open attached P00_102c.blend in 2.80
View Compositing Node Editor

Correct setup in 2.79b

Wrong setup when opened in 2.80

Blender file
P00_102c.blend

**System Information** Operating system: macOS 10.13.6 Graphics card: AMD Radeon R9 M370X 2048 MB **Blender Version** Broken: 2.80 2019-02-13 Worked: 2.79b 2018-03-22 **Short description of error** When the attached .blend file (created in 2.79b) is opened in 2.80 2019-02-13 the the compositor Render Layer nodes have wrong scene render layers. The attached screen shots highlight the issue. **Exact steps for others to reproduce the error** Open attached P00_102c.blend in 2.80 View Compositing Node Editor Correct setup in 2.79b ![Compositor2.79b.png](https://archive.blender.org/developer/F6602400/Compositor2.79b.png) Wrong setup when opened in 2.80 ![Compositor2.80.png](https://archive.blender.org/developer/F6602407/Compositor2.80.png) Blender file [P00_102c.blend](https://archive.blender.org/developer/F6602411/P00_102c.blend)

Brian Swift commented

2019-02-13 22:26:39 +01:00

Added subscriber: @bswift

Philipp Oeser commented

2019-02-14 09:24:05 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-02-14 09:24:05 +01:00

Confirmed, checking...

blender-admin commented

2019-02-14 10:48:56 +01:00

This issue was referenced by 87bba05d25

This issue was referenced by 87bba05d25e085c83e2c9dfb172048f150cd740c

Philipp Oeser commented

2019-02-14 10:53:12 +01:00

Looks like this is caused by adding a vanilla "Viewport" viewlayer and making it the first in the list here
(special case in do_version_layers_to_collections() if there are layer overrides...)

/* Make it first in the list. */
BLI_remlink(&scene->view_layers, view_layer);
BLI_addhead(&scene->view_layers, view_layer);

Render Layers node stores an index to viewlayers afaics and by just making a new viewlayer the first here is shifting all others by one...
Not sure why the new vanilla "Viewport" viewlayer needs to be the first in the list?
If that needs to be the case, then Render Layers nodes indices need to be corrected as well, I guess.
But just removing the "push-to-head" for the new vanilla viewlayer also solves this issue: D4352

Looks like this is caused by adding a vanilla "Viewport" viewlayer and making it the first in the list [here ](https://developer.blender.org/diffusion/B/browse/master/source/blender/blenloader/intern/versioning_280.c$519) (special case in `do_version_layers_to_collections()` if there are layer overrides...) ``` /* Make it first in the list. */ BLI_remlink(&scene->view_layers, view_layer); BLI_addhead(&scene->view_layers, view_layer); ``` `Render Layers` node stores an index to viewlayers afaics and by just making a **new** viewlayer the first here is shifting all others by one... Not sure why the new vanilla "Viewport" viewlayer needs to be the first in the list? If that **needs** to be the case, then Render Layers nodes indices need to be corrected as well, I guess. But just removing the "push-to-head" for the new vanilla viewlayer also solves this issue: [D4352](https://archive.blender.org/developer/D4352)

Brecht Van Lommel was assigned by Philipp Oeser

2019-02-14 11:02:30 +01:00

Philipp Oeser commented

2019-02-14 14:01:11 +01:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2019-02-14 14:01:11 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend #61520