Compositing node Vector -> Normalize inputs and outputs scalars not vectors #61875

Closed
opened 2019-02-23 07:14:48 +01:00 by Finn Bear · 12 comments

System Information
Operating system: Ubuntu 18:04

Blender Version
Broken: 2.8 from February 4, 2019

Short description of error
The Vector -> Normalize node, visible in the compositor, takes/returns scalars (numbers denoted by a grey dot) instead of vectors (two values denoted by a blue dot). It is impossible to normalize scalars (unless you just set them to equal 1), so this shouldn't even be an option. I'm guessing this is a cosmetic issue.

Exact steps for others to reproduce the error
Open the compositor, enable "use nodes," add a Vector -> Normalize node

**System Information** Operating system: Ubuntu 18:04 **Blender Version** Broken: 2.8 from February 4, 2019 **Short description of error** The Vector -> Normalize node, visible in the compositor, takes/returns scalars (numbers denoted by a grey dot) instead of vectors (two values denoted by a blue dot). It is impossible to normalize scalars (unless you just set them to equal 1), so this shouldn't even be an option. I'm guessing this is a cosmetic issue. **Exact steps for others to reproduce the error** Open the compositor, enable "use nodes," add a Vector -> Normalize node
Author

Added subscriber: @finnb

Added subscriber: @finnb
Member

Added subscriber: @JacquesLucke

Added subscriber: @JacquesLucke
Jacques Lucke self-assigned this 2019-02-25 15:05:15 +01:00
Member

The actual problem here seems to be the documentation, not the implementation.

In the code it says: Normalize single channel, useful for z buffer (https://developer.blender.org/diffusion/B/browse/master/source/blender/nodes/composite/nodes/node_composite_normalize.c$28).

While the manual explains something very different (https://docs.blender.org/manual/en/latest/compositing/types/vector/normalize.html).

The actual problem here seems to be the documentation, not the implementation. In the code it says: `Normalize single channel, useful for z buffer` (https://developer.blender.org/diffusion/B/browse/master/source/blender/nodes/composite/nodes/node_composite_normalize.c$28). While the manual explains something very different (https://docs.blender.org/manual/en/latest/compositing/types/vector/normalize.html).

This issue was referenced by 4574

This issue was referenced by 4574
Member

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Author

@JacquesLucke Now I'm wondering why this node is in the "Vector" category, and that actually applies to most of the nodes there. These nodes, except vector curves, really stretch the meaning of "vector."

@JacquesLucke Now I'm wondering why this node is in the "Vector" category, and that actually applies to most of the nodes there. These nodes, except vector curves, really stretch the meaning of "vector."
Member

Added subscriber: @WilliamReynish

Added subscriber: @WilliamReynish
Member

@finnb, you are right. That does not really make sense.

@WilliamReynish, where should this be?

@finnb, you are right. That does not really make sense. @WilliamReynish, where should this be?

As @finnb points out, that could be argued for almost all the nodes in the Vector category.

We could put them inside the Converter category? Or we could add a new category called 'Values' or something like that?

Although if we use the logic of the main input or output socket, the Vector category would be almost empty.

As @finnb points out, that could be argued for almost all the nodes in the Vector category. We could put them inside the Converter category? Or we could add a new category called 'Values' or something like that? Although if we use the logic of the main input or output socket, the Vector category would be almost empty.
Member

Hmmm, I'm not sure... Maybe this should be discussed in a design task.

Hmmm, I'm not sure... Maybe this should be discussed in a design task.
Author

The vector category wouldn't be almost empty if a true "normalize" node was added. The current "normalize" node could be renamed "normalize channel."

The vector category wouldn't be almost empty if a true "normalize" node was added. The current "normalize" node could be renamed "normalize channel."
Author

Also, where can I find "design tasks?"

Also, where can I find "design tasks?"
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-manual#61875
No description provided.