Undo crash after hiding object in edit mode #62450
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#62450
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows 7 X64 SP1
Graphics card: Nvidia Titan X
Blender Version
Broken: blender2.8, 2019-03-08,
a0f2923fd8
Worked: (optional)
Short description of error
Blender crashes when the visibility of the selected object is off and "undo" is performed.
Exact steps for others to reproduce the error
Added subscriber: @PierreSchiller
#64008 was marked as duplicate of this issue
#63314 was marked as duplicate of this issue
#63190 was marked as duplicate of this issue
#63188 was marked as duplicate of this issue
#62762 was marked as duplicate of this issue
Blender 2.8 closes on visibility hidden + Undoto Undo crash after hiding object in edit modeAdded subscriber: @MarcinTwarowski
It also crashes when object is in edit mode and the collection it's in is set to hidden.
Added subscriber: @seaside98-4
Added subscriber: @Lexx
Added subscribers: @ahmadakil, @ideasman42, @antoniov
Added subscriber: @Fubax-1
Added subscriber: @brecht
Call stack from #63314:
Added subscribers: @jakubo, @lichtwerk
Some investigation on the cause of this crash in #64008#668488.
Added subscriber: @mano-wii
In Blender2.7 it was not possible to hide an object in edit mode. I don't see why change this behavior now.
For me a solution would be to simply restrict the property to not hiding an object in edit mode.
The crash happens because
objects_len
inmesh_undosys_step_encode
becomes0
when hiding the single object in edit mode.And this function was not prepared to handle this case.
And even if this function handle this case, it is necessay to edit the polls that don't allow
Global Undo
to work in edit mode.Added subscriber: @dfelinto
[update: it seems I was investigating this at the same time as @mano-wii so there is nothing here that he hasn't mentioned above]
mesh_undosys_step_encode
uses only the visible objects in their iterator: BKE_view_layer_array_from_objects_in_edit_mode_unique_data() at some point callsbase_is_in_mode
which only returns visible bases.I suspect it may be related with the issue.
I don't think it's possible to reliably prevent an object from getting hidden in edit mode, there are many indirect ways this could happen and preventing them all in the UI or Python API is not practical. An object could also be hidden in one view layer but not another.
It could work to kick an object out of edit mode as soon as it gets hidden everywhere, or at least not consider it to be in edit mode while it's hidden.
Changed status from 'Open' to: 'Resolved'
This is no longer crashing, closing.