Page MenuHome
Create Task
Maniphest T62601

2.8 Follow Path bug
Closed, ResolvedPublic
Actions

Description

Follow_Path_BUG.blend1 MBDownload
System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: Quadro K620/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 386.01

Blender Version
Broken: version: 2.80 (sub 48), branch: master, commit date: 2019-03-13 19:14, hash: rBbbc3ee09e44b
Worked: (optional)

Short description of error

當我在2.79做同樣的事
物題不會有偏移

When I did the same thing at 2.79
Objects will not have an offset

Exact steps for others to reproduce the error
ctrl+P > Follow Path
......Abnormal offset

Revisions and Commits

rB Blender
D4524rB9ad9d38786c5 Fix T62601: parenting to curve (follow path) causes offset

Related Objects

Event Timeline

楊景貴 (issac) created this task.Mar 15 2019, 3:23 AM
楊景貴 (issac) added a comment.Mar 15 2019, 3:26 AM

我的母語是繁體中文
我都是用 google 的翻譯
如果有不清楚的地方，或是翻譯上的誤會
還請包涵
My native language is Traditional Chinese.
I use google's translation
If there is something unclear, or misunderstanding in translation
Please also bear

楊景貴 (issac) updated the task description. (Show Details)Mar 15 2019, 3:34 AM
Martin Capitanio (capnm) added a subscriber: Martin Capitanio (capnm).EditedMar 15 2019, 10:03 AM

Seems dependent on state of the 'Follow' check box:

  • selected v2.79 OK, v2.8 broken
  • unselected v2.79 broken, v2.8 OK

William Reynish (billreynish) added subscribers: Campbell Barton (campbellbarton), William Reynish (billreynish).Mar 15 2019, 11:10 AM

Tbh I don't even see why we should keep this feature at all. For many years we have had a constraints system for this kind of thing.

This is one of the features that is a remnant from before we had constraints inside Blender.

@Campbell Barton (campbellbarton) What do you think? Is there a reason we've kept this around?

Campbell Barton (campbellbarton) added a comment.Mar 15 2019, 11:12 AM

Think we could remove, check w/ other devs & guys in the studio?

William Reynish (billreynish) added subscribers: Sergey Sharybin (sergey), Brecht Van Lommel (brecht).Mar 15 2019, 11:17 AM

@Brecht Van Lommel (brecht) @Sergey Sharybin (sergey)

What do you think? Is this not a good time to clean this out?

Sebastian Parborg (zeddb) lowered the priority of this task from 90 to 50.Mar 15 2019, 11:43 AM
Sergey Sharybin (sergey) added a comment.Mar 15 2019, 1:10 PM

I am against REMOVAL of features at bcon3. Might consider REPLACING them, with proper do-versioning.

To me it doesn't seem to be an issue with "Follow" option. It appears to be working correct to me. What doesn't appear correct to me is the calculation of an inverse parent matrix (which sound similar to T60623).

Brecht Van Lommel (brecht) added a comment.Mar 15 2019, 2:24 PM

I agree with @Sergey Sharybin (sergey).

Martin Capitanio (capnm) added a comment.Mar 15 2019, 3:19 PM

To me it doesn't seem to be an issue with "Follow" option. It appears to be working correct to me.

Yes, I only listed cases where the initial offset (this bug) appears.

Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Mar 15 2019, 4:21 PM

Seems indeed very similar to T60623.
This time the flag on the evaluated curve CU_FOLLOW is no set, leading to a different behaviour in ob_parcurve()

(possible) fix incoming...

Philipp Oeser (lichtwerk) added a revision: D4524: Fix T62601: parenting to curve (follow path) causes offset.Mar 15 2019, 4:32 PM
Philipp Oeser (lichtwerk) changed the task status from Unknown Status to Resolved by committing rB9ad9d38786c5: Fix T62601: parenting to curve (follow path) causes offset.Mar 15 2019, 6:52 PM
Philipp Oeser (lichtwerk) added a commit: rB9ad9d38786c5: Fix T62601: parenting to curve (follow path) causes offset.
Philipp Oeser (lichtwerk) mentioned this in T55494: Apply transforms on parents and children.Apr 6 2019, 2:42 PM