Subdivide a hair segment causes the high light to appear at the wrong place #62730

New Issue

Lance Phan · 2019-03-19T02:42:37+01:00

Lance Phan commented

2019-03-19 02:42:37 +01:00

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 418.81

Blender Version
Broken: version: 2.80 (sub 50), branch: master, commit date: 2019-03-18 20:40, hash: ce09b93955
Worked:
Subdivide the entire hair does not cause the problem, the highlight appear at the correct place.

Short description of error
In Particle edit mode, subdivide a segment of the hair will cause the selection highlight appear at the wrong part.

Exact steps for others to reproduce the error
With the default cube, add a hair system, reduce the number to 1, switch to particle edit mode, select 2 connecting vertices, then subdivide.
Now if you select an individual vertex, the highlight appear at the wrong place

**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 418.81 **Blender Version** Broken: version: 2.80 (sub 50), branch: master, commit date: 2019-03-18 20:40, hash: `ce09b93955` Worked: Subdivide the entire hair does not cause the problem, the highlight appear at the correct place. **Short description of error** In Particle edit mode, subdivide a segment of the hair will cause the selection highlight appear at the wrong part. **Exact steps for others to reproduce the error** With the default cube, add a hair system, reduce the number to 1, switch to particle edit mode, select 2 connecting vertices, then subdivide. Now if you select an individual vertex, the highlight appear at the wrong place ![Zalo_ScreenShot_19_3_2019_137763.png](https://archive.blender.org/developer/F6846980/Zalo_ScreenShot_19_3_2019_137763.png)

Lance Phan commented

2019-03-19 02:42:37 +01:00

Added subscriber: @ssendam

Sebastian Parborg commented

2019-03-19 15:53:29 +01:00

Added subscribers: @Sergey, @ZedDB

Sergey Sharybin was assigned by Sebastian Parborg

2019-03-19 15:53:29 +01:00

Sebastian Parborg commented

2019-03-19 15:53:29 +01:00

@Sergey as always, feel free to reassign if this is not for you.

Sergey Sharybin commented

2019-03-19 16:24:04 +01:00

@ZedDB, not sure i am properly understanding the issue here (could be multiple ones). Mind testing the patch? fix_T62730.patch

@ZedDB, not sure i am properly understanding the issue here (could be multiple ones). Mind testing the patch? [fix_T62730.patch](https://archive.blender.org/developer/F6850134/fix_T62730.patch)

Sebastian Parborg commented

2019-03-19 18:29:28 +01:00

@Sergey the issue is that the highlight on the line seem to be centered around the wrong center point.
(However, your patch fixed a refresh issue, the hair geometry now updates after the subdiv command. So be sure to include it too)

Correctly centered before subdivide:

Shifted highlight after subdivide:

Test file:
hair_vert_sub.blend

This highlight offset issue also seems to happen in 2.79 btw.

@Sergey the issue is that the highlight on the line seem to be centered around the wrong center point. (However, your patch fixed a refresh issue, the hair geometry now updates after the subdiv command. So be sure to include it too) Correctly centered before subdivide: ![part1.png](https://archive.blender.org/developer/F6850696/part1.png) Shifted highlight after subdivide: ![part2.png](https://archive.blender.org/developer/F6850701/part2.png) Test file: [hair_vert_sub.blend](https://archive.blender.org/developer/F6850644/hair_vert_sub.blend) This highlight offset issue also seems to happen in 2.79 btw.

Lance Phan commented

2019-03-20 02:25:36 +01:00

This highlight offset issue also seems to happen in 2.79 btw.

In Blender 2.79, the wrong highlight is a different issue, it is because of the low path steps, regardless of subdivide or not. Increase the path steps will solve the issue. This also happens in 2.8.
If you set the hair segments to 7 and path steps to 2, you can see it very clearly in both 2.79 and 2.8.

The subdivide issue is different, increasing the path steps doesn't help

> This highlight offset issue also seems to happen in 2.79 btw. In Blender 2.79, the wrong highlight is a different issue, it is because of the low path steps, regardless of subdivide or not. Increase the path steps will solve the issue. This also happens in 2.8. If you set the hair segments to 7 and path steps to 2, you can see it very clearly in both 2.79 and 2.8. The subdivide issue is different, increasing the path steps doesn't help

Sergey Sharybin removed their assignment 2019-03-20 12:05:26 +01:00

Clément Foucault was assigned by Sergey Sharybin

2019-03-20 12:05:26 +01:00

Sergey Sharybin commented

2019-03-20 12:05:26 +01:00

Added subscriber: @fclem

Sergey Sharybin commented

2019-03-20 12:05:26 +01:00

@fclem , as far as i know the highlight is handled by the drawing code, which i am not familiar with. The annoying part is that the highlight is somewhat decoupled from control points, but think it should be possible to have it behave similar to 2.79.
Mind having a look?

P.S. I've committed my fix for the refresh issue.

@fclem , as far as i know the highlight is handled by the drawing code, which i am not familiar with. The annoying part is that the highlight is somewhat decoupled from control points, but think it should be possible to have it behave similar to 2.79. Mind having a look? P.S. I've committed my fix for the refresh issue.

Jacques Lucke commented

2019-03-25 15:14:32 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-03-25 15:14:32 +01:00

Looks like the drawing code expects that the points are uniformly spaced along the hair strand.

Clément Foucault was unassigned by Dalai Felinto

2019-12-23 16:34:53 +01:00

blender-admin commented

2020-01-28 18:28:10 +01:00

This issue was referenced by b2034c6ba2

This issue was referenced by b2034c6ba245e131e6ecabe33ca9afa1e6394247

Clément Foucault self-assigned this 2020-01-28 18:28:38 +01:00

Clément Foucault commented

2020-01-28 18:30:18 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Clément Foucault closed this issue

2020-01-28 18:30:18 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Subdivide a hair segment causes the high light to appear at the wrong place #62730