Edit mode, Clipping region, Visuals bug and editing vertices remain slow like when geometry is not hidden #62792

Closed
opened 2019-03-20 22:46:41 +01:00 by noki paike · 22 comments

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: AMD Radeon HD 7600M Series ATI Technologies Inc. 4.5.13417 Core Profile Context 0

Blender Version
Broken: version: 2.80 (sub 51), branch: master, commit date: 2019-03-20 16:33, hash: b6d1946c2e
Worked: (optional)

Short description of error
Edit mode, Clipping region, Visuals bug and editing vertices remain slow like when geometry is not hidden

Exact steps for others to reproduce the error

  • 1 create a sphere and subdivide it many times until the model becomes heavy to edit
  • 2 clipping region a part of the geometry and you will see the visual bug
  • 3 try editing the non-hidden geometry and you will notice that it continues to be slow as if the rest of the geometry had not been hidden.

Screenshot (91).jpg

clipbug.blend

**System Information** Operating system: Windows-10-10.0.17763 64 Bits Graphics card: AMD Radeon HD 7600M Series ATI Technologies Inc. 4.5.13417 Core Profile Context 0 **Blender Version** Broken: version: 2.80 (sub 51), branch: master, commit date: 2019-03-20 16:33, hash: `b6d1946c2e` Worked: (optional) **Short description of error** Edit mode, Clipping region, Visuals bug and editing vertices remain slow like when geometry is not hidden **Exact steps for others to reproduce the error** - 1 create a sphere and subdivide it many times until the model becomes heavy to edit - 2 clipping region a part of the geometry and you will see the visual bug - 3 try editing the non-hidden geometry and you will notice that it continues to be slow as if the rest of the geometry had not been hidden. ![Screenshot (91).jpg](https://archive.blender.org/developer/F6857490/Screenshot__91_.jpg) [clipbug.blend](https://archive.blender.org/developer/F6857499/clipbug.blend)
Author

Added subscriber: @nokipaike

Added subscriber: @nokipaike

Added subscriber: @matc

Added subscriber: @matc

Not sure if this is by design. But proportional editing appears to be able to change the mesh outside of the clipped region (Alt+B), unlike with hidden vertices (H, Alt+H).

To reproduce the visual bug, I had to hide (H) half of the sphere first, then clip (Alt+B) to a visible quarter. This lead the previously not hidden quarter to be partially visible outside of the clipped region.

Not sure if this is by design. But proportional editing appears to be able to change the mesh outside of the clipped region (Alt+B), unlike with hidden vertices (H, Alt+H). To reproduce the visual bug, I had to hide (H) half of the sphere first, then clip (Alt+B) to a visible quarter. This lead the previously not hidden quarter to be partially visible outside of the clipped region.
Author

in my case I just need to press Clipping region ...
but I think it's due to the fact that my gpu is part of the workarounds-gpu's

anyway, what matters to me much more is the fact that even with clipping region the geometry continues to be difficult to edit on heavy models ... and if it stays that way, this function is practically useless

in my case I just need to press Clipping region ... but I think it's due to the fact that my gpu is part of the workarounds-gpu's anyway, what matters to me much more is the fact that even with clipping region the geometry continues to be difficult to edit on heavy models ... and if it stays that way, this function is practically useless

Added subscriber: @ZedDB

Added subscriber: @ZedDB

I can't reproduce the visual bug with by just open the file, so I guess that part is a EOL GPU bug.

@matc what GPU do you have?

The clipping plane is not for speeding up mesh operators. It for speeding up drawing (or simply hiding objects) in the viewport by not rendering them.
So the only thing that is a bug here is the visual part.

I can't reproduce the visual bug with by just open the file, so I guess that part is a EOL GPU bug. @matc what GPU do you have? The clipping plane is not for speeding up mesh operators. It for speeding up drawing (or simply hiding objects) in the viewport by not rendering them. So the only thing that is a bug here is the visual part.

The file does not have the bug for me by default either.

@ZedDB RX 580. I don't think its hardware related. It looks like there is a different shader used for the parts outside of a partially clipped mesh.

Hiding parts of the mesh is not the problem here. If there are no hidden parts the outline is still showing.

Edit mode:
clipped_hidden_edit_mode.PNG

Object mode:
clipped_hidden_object_mode.PNG

Another thing I noticed is when moving a partially clipped object in Rendered mode. This is probably the only unintentional thing here.

clipped_rendered_object_mode.PNG

The file does not have the bug for me by default either. @ZedDB RX 580. I don't think its hardware related. It looks like there is a different shader used for the parts outside of a partially clipped mesh. Hiding parts of the mesh is not the problem here. If there are no hidden parts the outline is still showing. Edit mode: ![clipped_hidden_edit_mode.PNG](https://archive.blender.org/developer/F6862263/clipped_hidden_edit_mode.PNG) Object mode: ![clipped_hidden_object_mode.PNG](https://archive.blender.org/developer/F6862264/clipped_hidden_object_mode.PNG) Another thing I noticed is when moving a partially clipped object in Rendered mode. This is probably the only unintentional thing here. ![clipped_rendered_object_mode.PNG](https://archive.blender.org/developer/F6862306/clipped_rendered_object_mode.PNG)
Author

Added subscribers: @fclem, @mano-wii

Added subscribers: @fclem, @mano-wii
Author

In #62792#645509, @ZedDB wrote:
The clipping plane is not for speeding up mesh operators. It for speeding up drawing (or simply hiding objects) in the viewport by not rendering them.
So the only thing that is a bug here is the visual part.

ok i checked and the same thing happens on blender 2.79 ... but too bad ...
because if I select the piece of geometry that I am interested in editing, if I press the shortcut "p" to separate the geometry, that piece immediately becomes light as a feather ...
so I ask and I suggest you guys ..
@fclem
@mano-wii
it would be too complex conceptually a thing, if during "the phase of moving vertices" until the end of the operation:
to automatically separate a piece of geometry of a slightly larger area than the vertices being edited making it a separate object, and then make a "join" and a "merge vertex/remove doubles" at to finished editing operation"

> In #62792#645509, @ZedDB wrote: > The clipping plane is not for speeding up mesh operators. It for speeding up drawing (or simply hiding objects) in the viewport by not rendering them. > So the only thing that is a bug here is the visual part. ok i checked and the same thing happens on blender 2.79 ... but too bad ... because if I select the piece of geometry that I am interested in editing, **if I press the shortcut "p" to separate the geometry, that piece immediately becomes light as a feather ...** so I ask and I suggest you guys .. @fclem @mano-wii it would be too complex conceptually a thing, if during "the phase of moving vertices" until the end of the operation: **to automatically separate a piece of geometry of a slightly larger area than the vertices being edited making it a separate object, and then make a "join" and a "merge vertex/remove doubles" at to finished editing operation"**
Author

In #62792#645509, @ZedDB wrote:
I can't reproduce the visual bug with by just open the file, so I guess that part is a EOL GPU bug.

try to open the file with "load UI" option actived

> In #62792#645509, @ZedDB wrote: > I can't reproduce the visual bug with by just open the file, so I guess that part is a EOL GPU bug. try to open the file with "load UI" option actived

Still can't seem to reproduce this on my end.

Still can't seem to reproduce this on my end.

@ZedDB This has been fixed with 7454fa927b and 106551b9ad. Clipping does not look like it's implemented in a way that would enhance performance.

This would be the only remaining bug in this thread.
clipped_rendered_object_mode.PNG
Steps to reproduce

  • Open default .blend
  • Switch to "Rendered" shading
  • Select a clipping region (size and position are irrelevant)
  • Rotate the viewport, the "Cube" appears to be producing some sort of traces when in motion.
@ZedDB This has been fixed with 7454fa927b80118 and 106551b9ad1f12. Clipping does not look like it's implemented in a way that would enhance performance. This would be the only remaining bug in this thread. ![clipped_rendered_object_mode.PNG](https://archive.blender.org/developer/F6862306/clipped_rendered_object_mode.PNG) **Steps to reproduce** - Open default .blend - Switch to "Rendered" shading - Select a clipping region (size and position are irrelevant) - Rotate the viewport, the "Cube" appears to be producing some sort of traces when in motion.

@matc I can not reproduce that either. So I'm guessing this is driver related.

@fclem can you reproduce these artifacts?

@matc I can not reproduce that either. So I'm guessing this is driver related. @fclem can you reproduce these artifacts?

@ZedDB Does clipping work properly for you in Rendered?

@ZedDB Does clipping work properly for you in Rendered?

@matc the rendered object is not clipped (known limitation), but I do not get the rendering artifacts you describe.

@matc the rendered object is not clipped (known limitation), but I do not get the rendering artifacts you describe.

On linux it looks good for me too.

On linux it looks good for me too.
Author

I downloaded the latest build blender-2.80-adfdae3fc2f4-win64
the bug has remained unchanged , at this point, I think it was only fixed for the **non-**workaround gpus
Screenshot (105).jpg

I downloaded the latest build blender-2.80-adfdae3fc2f4-win64 the bug has remained unchanged , at this point, I think it was only fixed for the **non-**workaround gpus ![Screenshot (105).jpg](https://archive.blender.org/developer/F6884753/Screenshot__105_.jpg)

Without this line my artifacts disappear.

diff --git a/source/blender/draw/engines/eevee/shaders/lit_surface_vert.glsl b/source/blender/draw/engines/eevee/shaders/lit_surface_vert.glsl
index 141d3363a09..043a7b757f3 100644
--- a/source/blender/draw/engines/eevee/shaders/lit_surface_vert.glsl
+++ b/source/blender/draw/engines/eevee/shaders/lit_surface_vert.glsl
@@ -71,7 +71,6 @@ void main()
 #endif
 
 	/* Used for planar reflections */
-	gl_ClipDistance[0] = dot(vec4(worldPosition, 1.0), ClipPlanes[0]);
 
 #ifdef USE_ATTR
 	pass_attr(pos);

clipped_rendered_object_mode.PNG

Without this line my artifacts disappear. ``` diff --git a/source/blender/draw/engines/eevee/shaders/lit_surface_vert.glsl b/source/blender/draw/engines/eevee/shaders/lit_surface_vert.glsl index 141d3363a09..043a7b757f3 100644 --- a/source/blender/draw/engines/eevee/shaders/lit_surface_vert.glsl +++ b/source/blender/draw/engines/eevee/shaders/lit_surface_vert.glsl @@ -71,7 +71,6 @@ void main() #endif /* Used for planar reflections */ - gl_ClipDistance[0] = dot(vec4(worldPosition, 1.0), ClipPlanes[0]); #ifdef USE_ATTR pass_attr(pos); ``` ![clipped_rendered_object_mode.PNG](https://archive.blender.org/developer/F6862306/clipped_rendered_object_mode.PNG)
Clément Foucault was assigned by Sebastian Parborg 2019-04-01 21:30:51 +02:00

This issue was referenced by f41ab375f3

This issue was referenced by f41ab375f38b0f828701f846fe33ec1d8ebd320e

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Added subscriber: @rogual

Added subscriber: @rogual

I'm seeing this as of commit a3877d8fe4 (Fri Nov 11 11:49:54 2022), and also on Blender 3.3.

My system:
MacBook Pro (2017)
MacOS Mojave 10.14.6
Intel Iris Plus Graphics 640 1536 MB

clipbug.mp4

I'm seeing this as of commit a3877d8fe4094c0502acdacfd15880da10260769 (Fri Nov 11 11:49:54 2022), and also on Blender 3.3. My system: MacBook Pro (2017) MacOS Mojave 10.14.6 Intel Iris Plus Graphics 640 1536 MB [clipbug.mp4](https://archive.blender.org/developer/F13960153/clipbug.mp4)
Sign in to join this conversation.
6 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#62792
No description provided.