Graph editor extrapolation make cyclic very slow #63656

New Issue

Benoit Alexis · 2019-04-16T10:52:57+02:00

Benoit Alexis commented

2019-04-16 10:52:57 +02:00

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 388.43

Blender Version
Broken: version: 2.80 (sub 57), branch: master, commit date: 2019-04-14 19:18, hash: 860a9f979d
Worked: (optional)

Short description of error
In the Graph Editor, when clicking on Channel - Extrapolation - Make Cyclic, the frame rate drops a lot.

Exact steps for others to reproduce the error

In pose mode, select all bones, go into the graph editor in order to make all the animation cycle. Select all curves, go to Channel - Extrapolation Mode - Make Cyclic.
Everything is cyclic as wanted, except that the frame rate is divided by 5 on my computer. It makes it very impracticle to edit the curves and see the result in real time.
What makes me think this is a bug is the fact that one simple fix I found is to simply close the graph editor window, or change it to another panel. Then the frame rate is back to normal and the animation cycles just fine.
Abyss_Fish_Bug_Report.blend

**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 388.43 **Blender Version** Broken: version: 2.80 (sub 57), branch: master, commit date: 2019-04-14 19:18, hash: `860a9f979d` Worked: (optional) **Short description of error** In the Graph Editor, when clicking on Channel - Extrapolation - Make Cyclic, the frame rate drops a lot. **Exact steps for others to reproduce the error** In pose mode, select all bones, go into the graph editor in order to make all the animation cycle. Select all curves, go to Channel - Extrapolation Mode - Make Cyclic. Everything is cyclic as wanted, except that the frame rate is divided by 5 on my computer. It makes it very impracticle to edit the curves and see the result in real time. What makes me think this is a bug is the fact that one simple fix I found is to simply close the graph editor window, or change it to another panel. Then the frame rate is back to normal and the animation cycles just fine. [Abyss_Fish_Bug_Report.blend](https://archive.blender.org/developer/F6950933/Abyss_Fish_Bug_Report.blend)

Benoit Alexis commented

2019-04-16 10:52:57 +02:00

Added subscriber: @BenoitAlexis

Sebastian Parborg commented

2019-04-16 14:20:45 +02:00

Added subscribers: @fclem, @ZedDB

Clément Foucault was assigned by Sebastian Parborg

2019-04-16 14:20:45 +02:00

Sebastian Parborg commented

2019-04-16 14:20:45 +02:00

I'm guessing that it is the curve drawing that it making this very slow. As pointed out, the playback is fast when the curve editor is not shown.

@fclem Is this something we could optimize?

I'm guessing that it is the curve drawing that it making this very slow. As pointed out, the playback is fast when the curve editor is not shown. @fclem Is this something we could optimize?

Jacques Lucke commented

2019-04-16 15:32:39 +02:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-04-16 15:32:39 +02:00

Looks like this is something we can optimize:

The allocation was introduced in fe00175c35.

Looks like this is something we can optimize: ![image.png](https://archive.blender.org/developer/F6951598/image.png) The allocation was introduced in fe00175c35.

Clément Foucault commented

2019-04-17 01:45:17 +02:00

@JacquesLucke I mesured the same thing. Is this something you want to tackle? I'm pretty sure using a GHash here is overkill. Also we could only allocate once for all points.

Clément Foucault was unassigned by Jacques Lucke

2019-04-17 08:30:39 +02:00

Jacques Lucke self-assigned this 2019-04-17 08:30:39 +02:00

Jacques Lucke commented

2019-04-17 08:30:39 +02:00

Will try to refactor that a bit to avoid the allocation for every evaluation. :)

Jacques Lucke commented

2019-04-17 18:19:32 +02:00

Changed status from 'Open' to: 'Resolved'

Jacques Lucke closed this issue

2019-04-17 18:19:32 +02:00

Jacques Lucke commented

2019-04-17 18:19:32 +02:00

81ce3801b improves the situation quite a bit. However, drawing the graph editor is still the bottleneck in that scene.
Unfortunately, that optimization is outside of the scope of the bug tracker, so I'm closing this.

81ce3801b improves the situation quite a bit. However, drawing the graph editor is still the bottleneck in that scene. Unfortunately, that optimization is outside of the scope of the bug tracker, so I'm closing this.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Graph editor extrapolation make cyclic very slow #63656