Crash in new outliner show parenting hierarchy #63869

New Issue

MACHIN3 · 2019-04-24T22:07:57+02:00

MACHIN3 commented

2019-04-24 22:07:57 +02:00

System Information
Operating system: Linux-4.13.10-041310-generic-x86_64-with-debian-stretch-sid 64 Bits
Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.67

Blender Version
Broken: version: 2.80 (sub 59), branch: master, commit date: 2019-04-24 17:11, hash: a14735d11d
Worked: f2dc78f13f

Short description of error
The latest build crashes immediately, when loading the attached file. It works fine with yesterdays build.

Exact steps for others to reproduce the error

load the file

crash_when_loading.blend

**System Information** Operating system: Linux-4.13.10-041310-generic-x86_64-with-debian-stretch-sid 64 Bits Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.67 **Blender Version** Broken: version: 2.80 (sub 59), branch: master, commit date: 2019-04-24 17:11, hash: `a14735d11d` Worked: f2dc78f13f **Short description of error** The latest build crashes immediately, when loading the attached file. It works fine with yesterdays build. **Exact steps for others to reproduce the error** * load the file [crash_when_loading.blend](https://archive.blender.org/developer/F6973442/crash_when_loading.blend)

MACHIN3 commented

2019-04-24 22:07:57 +02:00

Added subscriber: @MACHIN3

Brecht Van Lommel commented

2019-04-24 23:02:15 +02:00

Added subscriber: @brecht

Dalai Felinto was assigned by Brecht Van Lommel

2019-04-24 23:02:15 +02:00

Brecht Van Lommel commented

2019-04-24 23:02:15 +02:00

Infinite recursion in outliner_make_object_parent_hierarchy_recursive.

Infinite recursion in `outliner_make_object_parent_hierarchy_recursive`.

Harley Acheson commented

2019-04-24 23:10:40 +02:00

Added subscriber: @Harley

Harley Acheson commented

2019-04-24 23:10:40 +02:00

I got the same error exactly once while testing, but was unable to recreate it. At the time I was playing with objects that had three levels of parenting (parent, son, grandson) and was moving them in various ways between two collections. But again, it only happened the once and I then spent about an hour trying to retrace my steps to make it happen again without success.

blender-admin commented

2019-04-25 00:21:10 +02:00

This issue was referenced by d966c2f0c2

This issue was referenced by d966c2f0c2ad256adc70046b59b73004f5e21a7e

Brecht Van Lommel commented

2019-04-25 00:26:00 +02:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2019-04-25 00:26:00 +02:00

Brecht Van Lommel changed title from ~~attached file crashes immediately after loading~~ to Crash in new outliner show parenting hierarchy

2019-04-25 00:26:03 +02:00

Brecht Van Lommel commented

2019-04-25 00:26:03 +02:00

Changed status from 'Resolved' to: 'Open'

Brecht Van Lommel reopened this issue

2019-04-25 00:26:03 +02:00

Brecht Van Lommel commented

2019-04-25 00:37:30 +02:00

I've disabled the new feature temporarily since a simple fix wasn't obvious and it seems likely this happens in a lot of files.

The problem is that it's iterating over te_parent->subtree, while at the same time removing elements from it as tree_to_remove_objects_from.

Further there is a linear lookup to find tree elements corresponding to a child object, which causes O(n^2) time complexity overall and so poor scaling for many objects in a collection.

The more efficient solution that also fixes the crash could be:

Build a map from Object* to a list of TreeElement* matching the object.
For all objects in the tree lookup the parent in this map, and move or add tree elements as needed.

I've disabled the new feature temporarily since a simple fix wasn't obvious and it seems likely this happens in a lot of files. The problem is that it's iterating over `te_parent->subtree`, while at the same time removing elements from it as `tree_to_remove_objects_from`. Further there is a linear lookup to find tree elements corresponding to a child object, which causes O(n^2) time complexity overall and so poor scaling for many objects in a collection. The more efficient solution that also fixes the crash could be: * Build a map from Object* to a list of TreeElement* matching the object. * For all objects in the tree lookup the parent in this map, and move or add tree elements as needed.

Dalai Felinto commented

2019-04-25 03:33:35 +02:00

I managed to reproduce the issue in a simple file as well:

outliner_parent_instance.blend

From factory startup:

Delete Collection (Delete hierarchy)
Add an object (e.g., Cube)
Add another object (e.g., Empty).
Parent the Cube to the Empty

Thanks for reverting the commit Brecht.

I managed to reproduce the issue in a simple file as well: [outliner_parent_instance.blend](https://archive.blender.org/developer/F6974060/outliner_parent_instance.blend) From factory startup: * Delete Collection (Delete hierarchy) * Add an object (e.g., Cube) * Add another object (e.g., Empty). * Parent the Cube to the Empty Thanks for reverting the commit Brecht.

blender-admin commented

2019-04-25 05:09:19 +02:00

This issue was referenced by edff789292

This issue was referenced by edff78929276753b32e8df060d3f5f2755631288

Dalai Felinto commented

2019-04-25 06:26:02 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2019-04-25 06:26:02 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash in new outliner show parenting hierarchy #63869