Viewport shading fails when a newly added primitive (from custom script) is modified in the redo panel #64362

New Issue

Jesse Yurkovich · 2019-05-09T08:47:53+02:00

Jesse Yurkovich commented

2019-05-09 08:47:53 +02:00

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: Quadro 600/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 369.09

Blender Version
Broken: version: 2.80 (sub 60), branch: master, commit date: 2019-05-08 20:08, hash: 733811330c
Worked: last known good hash: a8a11d3537

Short description of error
Upon initial creation of the primitive mesh everything is fine. However, once you tweak one of the properties on the redo panel, the newly added mesh loses all shading. It remains like this until you enter/exit Edit mode for the mesh in question.

Initial creation:

After tweaking Redo panel:

Exact steps for others to reproduce the error
shading_on_redo.blend

Load attached .blend
Click "Run Script" in the editor that's already open
In the 3D Viewport, Search for the newly added "Test: Test Add Primitive" operator and invoke it
A subdivided cube appears on screen (Good!)
Tweak one of the properties of this new object in its Redo panel
Observe how all shading is lost (Bad)
- Enter/Exit Edit mode for the primitive and notice it returns to normal

Git bisect ended up blaming the following commit:
[733811330c] master: Workbench: Use common_view_lib and remove NormalMatrix usage

**System Information** Operating system: Windows-10-10.0.18362 64 Bits Graphics card: Quadro 600/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 369.09 **Blender Version** Broken: version: 2.80 (sub 60), branch: master, commit date: 2019-05-08 20:08, hash: `733811330c` Worked: last known good hash: `a8a11d3537` **Short description of error** Upon initial creation of the primitive mesh everything is fine. However, once you tweak one of the properties on the redo panel, the newly added mesh loses all shading. It remains like this until you enter/exit Edit mode for the mesh in question. Initial creation: ![initial-good.png](https://archive.blender.org/developer/F7019927/initial-good.png) After tweaking Redo panel: ![bad.png](https://archive.blender.org/developer/F7019929/bad.png) **Exact steps for others to reproduce the error** [shading_on_redo.blend](https://archive.blender.org/developer/F7019931/shading_on_redo.blend) - Load attached .blend - Click "Run Script" in the editor that's already open - In the 3D Viewport, Search for the newly added "Test: Test Add Primitive" operator and invoke it - A subdivided cube appears on screen (Good!) - Tweak one of the properties of this new object in its Redo panel - Observe how all shading is lost (Bad) - Enter/Exit Edit mode for the primitive and notice it returns to normal Git bisect ended up blaming the following commit: [733811330c9] master: Workbench: Use common_view_lib and remove NormalMatrix usage

Jesse Yurkovich commented

2019-05-09 08:47:53 +02:00

Added subscriber: @deadpin

Clément Foucault was assigned by Sebastian Parborg

2019-05-10 12:34:58 +02:00

Clément Foucault removed their assignment 2019-05-10 15:08:58 +02:00

Sergey Sharybin was assigned by Clément Foucault

2019-05-10 15:08:58 +02:00

Clément Foucault commented

2019-05-10 15:08:58 +02:00

Added subscriber: @fclem

Clément Foucault commented

2019-05-10 15:08:58 +02:00

This is because we now assume the inverse matrix is up to date when drawing.
I'm not sure how you do that in Python or if the depsgraph should handle this on its own.

This is because we now assume the inverse matrix is up to date when drawing. I'm not sure how you do that in Python or if the depsgraph should handle this on its own.

Jesse Yurkovich commented

2019-05-23 20:19:30 +02:00

Good news: This appears to be fixed as of some checkin yesterday
Bad news: I didn't spot any obvious depsgraph change for this but there was the big eevee refactor... so I'm not sure if this was a happy accident that will regress again soon or if it's actually fixed :)

Good news: This appears to be fixed as of some checkin yesterday Bad news: I didn't spot any obvious depsgraph change for this but there was the big eevee refactor... so I'm not sure if this was a happy accident that will regress again soon or if it's actually fixed :)

Sergey Sharybin commented

2019-05-29 16:59:58 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2019-05-29 16:59:58 +02:00

Sergey Sharybin commented

2019-05-29 16:59:58 +02:00

This was fixed by be5fd9c. Makes total sense actually :)

Thanks for the report, closing it now.

This was fixed by be5fd9c. Makes total sense actually :) Thanks for the report, closing it now.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Viewport shading fails when a newly added primitive (from custom script) is modified in the redo panel #64362