Grease Pencil populate draw manager method is not called when Cycles Render mode with Overlays OFF #65191

New Issue

Antonio Vazquez · 2019-05-27T18:07:48+02:00

Antonio Vazquez commented

2019-05-27 18:07:48 +02:00

Last source compiled at 27/05/2019

I have tested with prints the populate method and when set Cycles render and disable overlays, the method never is called.

I have tested with a simple Suzanne 2D

To reproduce.

Open default scene
Add Suzanne 2D
Set to Cycles
Set Render View mode
Disable overlays

Last source compiled at 27/05/2019 I have tested with prints the populate method and when set Cycles render and disable overlays, the method never is called. I have tested with a simple Suzanne 2D To reproduce. 1) Open default scene 2) Add Suzanne 2D 3) Set to Cycles 4) Set Render View mode 5) Disable overlays

Antonio Vazquez commented

2019-05-27 18:07:48 +02:00

Added subscriber: @antoniov

blender-admin commented

2019-05-27 18:07:48 +02:00

#65051 was marked as duplicate of this issue

Brecht Van Lommel was assigned by Antonio Vazquez

2019-05-27 18:08:51 +02:00

Antonio Vazquez commented

2019-05-27 18:08:51 +02:00

Added subscribers: @fclem, @brecht

Antonio Vazquez commented

2019-05-27 18:08:51 +02:00

Not sure if this is for @brecht or @fclem because is related to Draw Manager.

Brecht Van Lommel was unassigned by Clément Foucault

2019-05-27 18:37:15 +02:00

Jeroen Bakker was assigned by Clément Foucault

2019-05-27 18:37:15 +02:00

Clément Foucault commented

2019-05-27 18:37:15 +02:00

Added subscriber: @Jeroen-Bakker

Clément Foucault commented

2019-05-27 18:37:15 +02:00

This was introduce by @Jeroen-Bakker If I recall correctly. Cycles without overlays skips the cache populate phase as it has no benefit from doing so. Maybe we need to add an exception for GPencil?

Jeroen Bakker commented

2019-05-28 08:44:38 +02:00

Yes, that would be the cause.

The original idea was that we would limit the loop as it was not needed and add some speedup for heavy scenes.
The challenge is that in order to detect if GPencil is needed we have to loop over all objects and check if there is an GP object. The simple implementation will need to loop in average over 50% of the objects doing a Object type check.
I see the next options.

Go back to the old situation. where objects are always looped over.
Use the object_type_exclusion_filter. Not sure as this is quite hidden and GPobjects are visible by default.
Add a precheck to see if we have any GPencil object.

Loop over all objects in the DEG scene and find out if there is any GPencil Object.
Building something like DEG statistics could remove the extra loop over the objects, but not sure we have such capability and if it fits in the DEG architecture. This can be used to remove the selection of GPencil Drawing engine at all.

@brecht What do you think would be the best solution for the 2.80 release?

I tried to come up with a solution that currently works, and limits the need to loop over the objects as much as possible with the current tooling. D4962

Yes, that would be the cause. The original idea was that we would limit the loop as it was not needed and add some speedup for heavy scenes. The challenge is that in order to detect if GPencil is needed we have to loop over all objects and check if there is an GP object. The simple implementation will need to loop in average over 50% of the objects doing a Object type check. I see the next options. 1. Go back to the old situation. where objects are always looped over. 2. Use the `object_type_exclusion_filter`. Not sure as this is quite hidden and GPobjects are visible by default. 3. Add a precheck to see if we have any GPencil object. - Loop over all objects in the DEG scene and find out if there is any GPencil Object. - Building something like DEG statistics could remove the extra loop over the objects, but not sure we have such capability and if it fits in the DEG architecture. This can be used to remove the selection of GPencil Drawing engine at all. @brecht What do you think would be the best solution for the 2.80 release? I tried to come up with a solution that currently works, and limits the need to loop over the objects as much as possible with the current tooling. [D4962](https://archive.blender.org/developer/D4962)

Philipp Oeser commented

2019-05-28 16:03:50 +02:00

Added subscribers: @asuralhp, @lichtwerk

Jeroen Bakker commented

2019-05-29 14:58:02 +02:00

Changed status from 'Open' to: 'Resolved'

Jeroen Bakker closed this issue

2019-05-29 14:58:02 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Grease Pencil populate draw manager method is not called when Cycles Render mode with Overlays OFF #65191