Unify overlay engines #65347

Closed
opened 2019-05-31 12:32:45 +02:00 by Clément Foucault · 13 comments

Overlay engines flexibility is greatly reduced by having them separated into different draw engine.

We should unify them in order to be able to reduce MSAA cost and possibly fix some artifacts.

See #64915

Overlay engines flexibility is greatly reduced by having them separated into different draw engine. We should unify them in order to be able to reduce MSAA cost and possibly fix some artifacts. See #64915
Clément Foucault self-assigned this 2019-05-31 12:32:45 +02:00
Author
Member

Added subscriber: @fclem

Added subscriber: @fclem

Added subscriber: @MaciejJutrzenka

Added subscriber: @MaciejJutrzenka

Added subscriber: @JacobMerrill-1

Added subscriber: @JacobMerrill-1

Added subscriber: @lemenicier_julien

Added subscriber: @lemenicier_julien

Added subscriber: @DuarteRamos

Added subscriber: @DuarteRamos
Author
Member

Should be merged for 2.82.

Should be merged for 2.82.

Added subscriber: @DeadDrag0

Added subscriber: @DeadDrag0
Author
Member

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Author
Member

I think we can consider this task finished. The AA refactor that went with it might not be 100% final but it is not really related.

I think we can consider this task finished. The AA refactor that went with it might not be 100% final but it is not really related.

Added subscriber: @DanielPaul

Added subscriber: @DanielPaul

I'm not sure if this has something to do with the AA refactor, but it looks like the wireframe overlay has no correct AA since "Unify overlay engines". "Overlay Smooth Wires" does something but it doesn't look nearly as smooth as it was before.

But the performance in wireframe mode is much better now :)

I'm not sure if this has something to do with the AA refactor, but it looks like the wireframe overlay has no correct AA since "Unify overlay engines". "Overlay Smooth Wires" does something but it doesn't look nearly as smooth as it was before. But the performance in wireframe mode is much better now :)
Author
Member

In #65347#828491, @DanielPaul wrote:
I'm not sure if this has something to do with the AA refactor, but it looks like the wireframe overlay has no correct AA since "Unify overlay engines".

Can you post a screenshot of the issue? I know the AA is not the best but I think it solves 95% of the problem with less than half the cost in memory and computation.

But the performance in wireframe mode is much better now :)

Yay good to know!

> In #65347#828491, @DanielPaul wrote: > I'm not sure if this has something to do with the AA refactor, but it looks like the wireframe overlay has no correct AA since "Unify overlay engines". Can you post a screenshot of the issue? I know the AA is not the best but I think it solves 95% of the problem with less than half the cost in memory and computation. > But the performance in wireframe mode is much better now :) Yay good to know!

version: 2.82 (sub 5), branch: master, commit date: 2019-12-15 18:46, hash: 3b163483c4
2.82.png

version: 2.81 (sub 16), branch: master, commit date: 2019-11-20 14:27, hash: 26bd5ebd42
2.81.png

A bit off-topic... will we have random wireframe colors on top of solid mode someday?

version: 2.82 (sub 5), branch: master, commit date: 2019-12-15 18:46, hash: `3b163483c4` ![2.82.png](https://archive.blender.org/developer/F8225790/2.82.png) version: 2.81 (sub 16), branch: master, commit date: 2019-11-20 14:27, hash: `26bd5ebd42` ![2.81.png](https://archive.blender.org/developer/F8225792/2.81.png) A bit off-topic... will we have random wireframe colors on top of solid mode someday?
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#65347
No description provided.