Failure to install add-on with multiple dots in filename #65360

Closed
opened 2019-05-31 19:29:22 +02:00 by brothermechanic · 11 comments

System Information
Operating system:
Graphics card:

Blender Version
Broken: (example: 2.80, edbf15d3c0, master, 2018-11-28, as found on the splash screen)
Worked: 2.79*

Short description of error
Please see my screencast
2019-05-31 17-21-56.mp4

**System Information** Operating system: Graphics card: **Blender Version** Broken: (example: 2.80, edbf15d3c044, master, 2018-11-28, as found on the splash screen) Worked: 2.79* **Short description of error** Please see my screencast [2019-05-31 17-21-56.mp4](https://archive.blender.org/developer/F7081441/2019-05-31_17-21-56.mp4)

Added subscriber: @brothermechanic

Added subscriber: @brothermechanic

Added subscriber: @brecht

Added subscriber: @brecht

Please provide all the requested information in the bug submission template, and exact steps to reproduce the issue.

If it's a specific add-on that fails, attach the add-on.

Please provide all the requested information in the bug submission template, and exact steps to reproduce the issue. If it's a specific add-on that fails, attach the add-on.
brothermechanic changed title from Can't load addon from Alternate path to Can't load addon from User and Alternate paths 2019-05-31 19:49:38 +02:00
brothermechanic changed title from Can't load addon from User and Alternate paths to Can't load addon from User path 2019-05-31 19:50:56 +02:00
Member

Added subscriber: @StephenLeger

Added subscriber: @StephenLeger
Member

Multiple dots in filename make it fails, try to rename your .zip into Modeling-clothing-28.zip

Multiple dots in filename make it fails, try to rename your .zip into Modeling-clothing-28.zip
Brecht Van Lommel changed title from Can't load addon from User path to Failure to install add-on with dot in name 2019-06-06 18:12:44 +02:00
Brecht Van Lommel changed title from Failure to install add-on with dot in name to Failure to install add-on with multiple dots in filename 2019-06-06 18:13:04 +02:00
Philipp Oeser was assigned by Brecht Van Lommel 2019-07-03 18:22:51 +02:00

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk

@lichtwerk, is this one you could look into?

@lichtwerk, is this one you could look into?
Member

Yes, will check...

Yes, will check...
Member

Checked this, and it is not the . in the zipfile name, offending is the . in the foldername inside that zipfile...
2.79 also didnt allow for this (not sure why the report suggests this was working there?)

  • folder Modeling-Cloth-2.8-master in Modeling-Cloth-2.8-master.zip -> failure
  • folder Modeling-Cloth-2_8-master in Modeling-Cloth-2.8-master.zip -> success

As the folder will be the python package: pretty sure python doesnt allow for top level packages to contain a .?

For sure bpy.path.module_names() doesnt allow this [which is why this addon then wont be loaded]

What we could do here though is to check inside the .zip if we would find offending package names prior to copying this to the addons folder and tell the user that the installation failed.

Checked this, and it is not the `.` in the zipfile name, offending is the `.` in the foldername inside that zipfile... 2.79 also didnt allow for this (not sure why the report suggests this was working there?) - folder `Modeling-Cloth-2.8-master` in `Modeling-Cloth-2.8-master.zip` -> failure - folder `Modeling-Cloth-2_8-master` in `Modeling-Cloth-2.8-master.zip` -> success As the folder will be the python package: pretty sure python doesnt allow for top level packages to contain a `.`? For sure `bpy.path.module_names()` doesnt allow this [which is why this addon then wont be loaded] What we could do here though is to check inside the .zip if we would find offending package names prior to copying this to the addons folder and tell the user that the installation failed.
Member

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Member

This has now been addressed/clarified by 9267e6275c, closing...

This has now been addressed/clarified by 9267e6275c, closing...
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#65360
No description provided.