Collapsed pull down menus have no name in Quick Favourites #65365

New Issue

ChristopherAnderssarian · 2019-05-31T21:20:44+02:00

2019-05-31 21:20:44 +02:00

System Information
Operating system: Windows 7
GPU: ASUS Strix Radeon Vega 64, Divider version: 19.4.1
CPU: Intel Core i7-5960X

Blender Version
Broken: 2.80, (since Quick Favourites were added)

Exact steps for others to reproduce the error from scratch

Factory Startup
Find pulldown menus
Right-click context menu --> Untick Show Menus
Add the three line menu toggle to Quick Favourites

**System Information** Operating system: Windows 7 GPU: ASUS Strix Radeon Vega 64, Divider version: 19.4.1 CPU: Intel Core i7-5960X **Blender Version** Broken: 2.80, (since Quick Favourites were added) **Exact steps for others to reproduce the error from scratch** - Factory Startup - Find pulldown menus - Right-click context menu --> Untick `Show Menus` - Add the three line menu toggle to Quick Favourites ![QF_No_name.png](https://archive.blender.org/developer/F7081492/QF_No_name.png)

ChristopherAnderssarian commented

2019-05-31 21:20:44 +02:00

Added subscriber: @ChristopherAnderssarian

Eitan Traurig self-assigned this 2019-06-03 20:02:57 +02:00

Eitan Traurig removed their assignment 2019-07-06 00:46:45 +02:00

Eitan Traurig commented

2019-07-06 00:46:45 +02:00

Added subscriber: @EitanSomething

Richard Antalik commented

2020-02-04 06:33:13 +01:00

Added subscriber: @iss

Richard Antalik commented

2020-02-04 06:33:13 +01:00

Changed status from 'Confirmed' to: 'Needs User Info'

Richard Antalik commented

2020-02-04 06:33:13 +01:00

Can not reproduce this.

Can you revise steps to reproduce if this still happens?

Can not reproduce this. Can you revise steps to reproduce if this still happens?

Richard Antalik commented

2020-02-05 20:20:55 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'

Harley Acheson commented

2020-02-05 20:33:05 +01:00

Added subscriber: @Harley

Harley Acheson commented

2020-02-05 20:33:05 +01:00

Clearer instructions to reproduce:

On any header that includes menus we can choose to collapse all the menus into a single "hamburger" menu. For example, The main topbar header with File/Edit/Render/etc you can right-click in that header, remove the checkmark for "show menus" and afterward those menus are replaced with a single hamburger menu, which looks like three horizonal bars: ☰

In that state you can right-click that hamburger menu and "Add to Quick Favorites". That works, but that item is shown as a blank item within Quick Favorites. It is missing both the text label and the right-side triangle that indicates submenus, but does otherwise work.

Not sure what label we would use though, especially since each editor can have a different one. So perhaps "Main Menu", and then for each Editor use its name like "3D Viewport Menu"?

Clearer instructions to reproduce: On any header that includes menus we can choose to collapse all the menus into a single "hamburger" menu. For example, The main topbar header with File/Edit/Render/etc you can right-click in that header, remove the checkmark for "show menus" and afterward those menus are replaced with a single hamburger menu, which looks like three horizonal bars: ☰ In that state you can right-click that hamburger menu and "Add to Quick Favorites". That works, but that item is shown as a blank item within Quick Favorites. It is missing both the text label and the right-side triangle that indicates submenus, but does otherwise work. Not sure what label we would use though, especially since each editor can have a different one. So perhaps "Main Menu", and then for each Editor use its name like "3D Viewport Menu"?

Harley Acheson commented

2020-02-05 21:02:37 +01:00

interface_context_menu.c, ui_but_user_menu_add() is called for that uiBut but it has no drawstr.

It is not an optype nor rnaprop but does get a result from UI_but_menutype_get (at about line 466) so at that point ED_screen_user_menu_item_add_menu() is called with a blank drawstr. So just before that we could test if drawstr- [x] == '\0' and assign something like "Menu" to it. But that is a bit too generic. Would be best if we could create a better name but that would require finding the area based on the uibut and I'm not certain how.

interface_context_menu.c, ui_but_user_menu_add() is called for that uiBut but it has no drawstr. It is not an optype nor rnaprop but does get a result from UI_but_menutype_get (at about line 466) so at that point ED_screen_user_menu_item_add_menu() is called with a blank drawstr. So just before that we could test if `drawstr- [x] == '\0'` and assign something like "Menu" to it. But that is a bit too generic. Would be best if we could create a better name but that would require finding the area based on the uibut and I'm not certain how.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Collapsed pull down menus have no name in Quick Favourites #65365