Strip info doesn't use custom frame rate base #65398

Closed
opened 2019-06-01 16:25:27 +02:00 by ChristopherAnderssarian · 9 comments

System Information
Operating system: Windows 7
GPU: ASUS Strix Radeon Vega 64, Divider version: 19.4.1
CPU: Intel Core i7-5960X

Blender Version
Broken: 2.80, blender-2.80.0-git.cc600de6695a-windows64

Short description of error

The timecode in the strip info panel it doesn't consider the custom frame rate base (and only uses the FPS as a base).

Exact steps for others to reproduce the error

1.PNG

Demo.blend

**System Information** Operating system: Windows 7 GPU: ASUS Strix Radeon Vega 64, Divider version: 19.4.1 CPU: Intel Core i7-5960X **Blender Version** Broken: 2.80, `blender-2.80.0-git.cc600de6695a-windows64` **Short description of error** The timecode in the strip info panel it doesn't consider the custom frame rate base (and only uses the FPS as a base). **Exact steps for others to reproduce the error** ![1.PNG](https://archive.blender.org/developer/F7082057/1.PNG) [Demo.blend](https://archive.blender.org/developer/F7082060/Demo.blend)

Added subscriber: @ChristopherAnderssarian

Added subscriber: @ChristopherAnderssarian
Richard Antalik was assigned by Brecht Van Lommel 2019-06-02 00:47:53 +02:00

I guess high prio for this.

I guess high prio for this.

Added subscriber: @tintwotin

Added subscriber: @tintwotin

The problem is not in the panel, but in the frames to SMPTE conversion.

The problem is not in the panel, but in the frames to SMPTE conversion.

@tintwotin What do you mean? There is correct conversion in the timeline, but that value is not used in the panel... Unless you mean that the panel does it's own calculations.
@iss On the subject of timecodes a while ago I made a #53661 (Timecode placeholders) suggestion, a poor one (before I knew that "This is a bug tracker").
But I feel that it makes sense here, as for example, the playhead jumping back and forth between 2 and 3 digits.
movig.PNG
And whatever fix to show the 3rd digit on the start, end and duration will screw up the alignment...

If this is something you would like to work on I'd be more than happy to make it (look like) a proper papercut task. (Hopefully it's a Bug request)

@tintwotin What do you mean? There is correct conversion in the timeline, but that value is not used in the panel... Unless you mean that the panel does it's own calculations. @iss On the subject of timecodes a while ago I made a #53661 (Timecode placeholders) suggestion, a poor one (before I knew that "This is a bug tracker"). But I feel that it makes sense here, as for example, the playhead jumping back and forth between 2 and 3 digits. ![movig.PNG](https://archive.blender.org/developer/F7097348/movig.PNG) And whatever fix to show the 3rd digit on the start, end and duration will screw up the alignment... If this is something you would like to work on I'd be more than happy to make it (look like) a proper papercut task. (Hopefully it's a *Bug request*)

@ChristopherAnderssarian
I would agree with :FFF format for frame regardless of framerate. Each time I look at strip length now, I have to think about the format. But according to https://en.wikipedia.org/wiki/SMPTE_timecode, the format is HH:MM:SS:FF, which we are violating already.

@tintwotin any thoughts about this?

@ChristopherAnderssarian I would agree with :FFF format for frame regardless of framerate. Each time I look at strip length now, I have to think about the format. But according to https://en.wikipedia.org/wiki/SMPTE_timecode, the format is HH:MM:SS:FF, which we are violating already. @tintwotin any thoughts about this?

In #65398#699619, @iss wrote:
I would agree with :FFF format for frame regardless of framerate.

Not what I had in mind (but good for a quick fix). That placeholder wouldn't be needed 99% of the time.

Keeping SMPTE (Full) TimeCode Style the way it is (or possibly adhering better to the standard...) and adding an adaptive Timecode Style, one that adds the placeholders automatically...

> In #65398#699619, @iss wrote: > I would agree with :FFF format for frame regardless of framerate. Not what I had in mind (but good for a quick fix). That placeholder wouldn't be needed 99% of the time. Keeping `SMPTE (Full)` TimeCode Style the way it is (or possibly adhering better to the standard...) and adding an *adaptive* Timecode Style, one that adds the placeholders automatically...

This issue was referenced by da83f70754

This issue was referenced by da83f70754b6e5eb6d96b94b0d1d554bdb9120fd

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#65398
No description provided.