Page MenuHome

Material shadows not updated with rna_Material_draw_update
Open, Confirmed, MediumPublic

Description

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86

Blender Version
Broken: version: 2.80 (sub 74), branch: master (modified), commit date: 2019-06-07 06:39, hash: rBa232d27bbaca
Worked: (optional)

Short description of error
When we change material shadow mode, for example, the shadows are not updated in the viewport

Exact steps for others to reproduce the error

Steps:

  • open this .blend:

with last 2.8

  • go in "rendered" shading mode with eevee
  • change shadow mode from opaque to alpha hashed for example

-> the shadows are not updated

Note:

This patch (which is not a fix):

forces the shadows update when we switch several times between shadow modes.

Details

Type
Bug

Event Timeline

Philipp Oeser (lichtwerk) lowered the priority of this task from Needs Triage by Developer to Confirmed, Medium.Jun 7 2019, 10:57 AM

Can confirm that above patch enforces an update.

However I assume this has a significant performance hit, so if this is the only way to update it correctly, I gues it would be better to introduce something like rna_Material_shadow_update (which does the fancy DEG_relations_tag_update) and use it for shadow_method only?

@Clément Foucault (fclem), @Sergey Sharybin (sergey): maybe there are better ways to properly have updates?

@Philipp Oeser (lichtwerk), i am not sure why shadows needs relation update. I don't remember any code in dependency graph which does anything related on shading settings.
To me it seems that the issue is somewhere else. Either wrong recalc tag is used or some ID doesn't get tagged when needed.