Material shadows not updated with rna_Material_draw_update #65598

New Issue

Ulysse Martin · 2019-06-07T10:22:06+02:00

Ulysse Martin commented

2019-06-07 10:22:06 +02:00

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86

Blender Version
Broken: version: 2.80 (sub 74), branch: master (modified), commit date: 2019-06-07 06:39, hash: a232d27bba
Worked: (optional)

Short description of error
When we change material shadow mode, for example, the shadows are not updated in the viewport

Exact steps for others to reproduce the error

Steps:

open this .blend:

Material_shadow_mode.blend

with last 2.8

go in "rendered" shading mode with eevee
change shadow mode from opaque to alpha hashed for example
the shadows are not updated

Note:

This patch (which is not a fix):

p.diff

forces the shadows update when we switch several times between shadow modes.

**System Information** Operating system: Windows-10-10.0.17763 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86 **Blender Version** Broken: version: 2.80 (sub 74), branch: master (modified), commit date: 2019-06-07 06:39, hash: `a232d27bba` Worked: (optional) **Short description of error** When we change material shadow mode, for example, the shadows are not updated in the viewport **Exact steps for others to reproduce the error** Steps: - open this .blend: [Material_shadow_mode.blend](https://archive.blender.org/developer/F7091541/Material_shadow_mode.blend) with last 2.8 - go in "rendered" shading mode with eevee - change shadow mode from opaque to alpha hashed for example - > the shadows are not updated Note: This patch (which is not a fix): [p.diff](https://archive.blender.org/developer/F7091546/p.diff) forces the shadows update when we switch several times between shadow modes.

Ulysse Martin commented

2019-06-07 10:22:06 +02:00

Added subscriber: @you.le

blender-admin commented

2019-06-07 10:22:06 +02:00

#68663 was marked as duplicate of this issue

blender-admin commented

2019-06-07 10:22:06 +02:00

#67519 was marked as duplicate of this issue

Philipp Oeser commented

2019-06-07 10:57:03 +02:00

Added subscribers: @fclem, @Sergey, @lichtwerk

Philipp Oeser commented

2019-06-07 10:57:03 +02:00

Can confirm that above patch enforces an update.

However I assume this has a significant performance hit, so if this is the only way to update it correctly, I gues it would be better to introduce something like rna_Material_shadow_update (which does the fancy DEG_relations_tag_update) and use it for shadow_method only?

@fclem, @Sergey: maybe there are better ways to properly have updates?

Can confirm that above patch enforces an update. However I assume this has a significant performance hit, so if this is the only way to update it correctly, I gues it would be better to introduce something like `rna_Material_shadow_update` (which does the fancy `DEG_relations_tag_update`) and use it for `shadow_method` only? @fclem, @Sergey: maybe there are better ways to properly have updates?

Sergey Sharybin commented

2019-06-07 11:06:35 +02:00

@lichtwerk, i am not sure why shadows needs relation update. I don't remember any code in dependency graph which does anything related on shading settings.
To me it seems that the issue is somewhere else. Either wrong recalc tag is used or some ID doesn't get tagged when needed.

@lichtwerk, i am not sure why shadows needs relation update. I don't remember any code in dependency graph which does anything related on shading settings. To me it seems that the issue is somewhere else. Either wrong recalc tag is used or some ID doesn't get tagged when needed.

Brecht Van Lommel commented

2019-07-23 17:06:56 +02:00

Added subscriber: @tombambadil

Brecht Van Lommel commented

2019-08-14 23:46:15 +02:00

Added subscriber: @Firepal

Clément Foucault commented

2020-01-17 19:51:30 +01:00

Closed as duplicate of #68165

Clément Foucault closed this issue

2020-01-17 19:51:30 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Material shadows not updated with rna_Material_draw_update #65598