Page MenuHome
Create Task
Maniphest T66392

Keyframes and drivers on custom nodes properties seem not working
Confirmed, NormalPublicTO DO
Actions

Description

System Information
Operating system: Darwin-18.2.0-x86_64-i386-64bit 64 Bits
Graphics card: Intel(R) Iris(TM) Graphics 540 Intel Inc. 4.1 INTEL-12.4.7

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-02 22:33, hash: rB50ccbe6bb233
Worked: (optional)

Short description of error
I'm not able to animate the properties of custom nodes. Keyframes do not work properly: when I set one all the others seem to disappear and only the last value set as a keyframe is shown on every time step.

Exact steps for others to reproduce the error

  1. Go to the text editor, import the 'Custom Nodes' template and run the script.
  2. Open the 'Custom Node Tree' area.
  3. Add a 'Custom Node', in the 'Some Nodes' category.
  4. Add a keyframe for 'my_float_prop' on frame 1.
  5. Change the frame, change 'my_float_prop' value and set a keyframe.
  6. Now I should see (at least it was like this in the last version) the property changing while scrolling through the timeline between the two keyframes I just set, but I don't. The property keeps the last value.

Related Objects

Event Timeline

Lorenzo Celli (lorenzocelli) created this task.Jul 4 2019, 12:45 AM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.Jul 4 2019, 10:09 AM
Philipp Oeser (lichtwerk) added projects: Dependency Graph, Animation & Rigging.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Confirmed.

note: T63793, T63548 might be related...

Daniele De Luca (sparazza) added a subscriber: Daniele De Luca (sparazza).Aug 7 2019, 2:50 PM
Tuomo Keskitalo (tkeskita) added subscribers: Jacques Lucke (JacquesLucke), Tuomo Keskitalo (tkeskita).Aug 9 2019, 7:55 AM

I found out that this bug (keyframing property values is not working for custom nodes) seem to exist also in Animation Nodes on Blender 2.80, FYI @Jacques Lucke (JacquesLucke)

Tuomo Keskitalo (tkeskita) added a comment.Aug 9 2019, 9:14 AM

Hmm, it looks like the animated f-curve evaluates correctly in python console via D.node_groups['NodeTree'].animation_data.action.fcurves[0].evaluate() even though value shown in node is not updated.

@Lorenzo Celli (lorenzocelli) can you please test: is the animated value actually changing correctly, even though value is not shown updated on the node?

Jacques Lucke (JacquesLucke) added a comment.Aug 10 2019, 8:28 AM

This is a fairly well known limitation. I'm not sure what is needed to make it work, but we should be able to figure that out.
For animation nodes, I usually advice people to not keyframe their nodes but create controller objects in the 3d view instead.

Should still be fixed though... Not sure if there is already another bug report for this.

Lorenzo Celli (lorenzocelli) added a comment.Aug 10 2019, 10:05 AM

@Tuomo Keskitalo (tkeskita) I tested it and to me it seems that the properties don't update at all, not in the UI and not by accessing them via python. The last keyframe you set just becomes the value for all frames, ignoring the other keyframes you set before

Tuomo Keskitalo (tkeskita) added a comment.Aug 11 2019, 9:05 AM

It looks like this goes down to somewhere in depsgraph/animation sources of Blender. Beyond my skills, so I hope someone more experienced can help. At least the F-curve is there apparently OK. Thanks @Lorenzo Celli (lorenzocelli) for confirmation.

Lorenzo Celli (lorenzocelli) added a comment.Sep 6 2019, 7:18 PM

Anything new? Maybe I'm missing another similar bug report

Lorenzo Celli (lorenzocelli) added a comment.EditedNov 14 2019, 8:46 PM

Hello everybody! Any news?

Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).Dec 12 2019, 4:40 PM
In T66392#749929, @Jacques Lucke (JacquesLucke) wrote:

This is a fairly well known limitation.

In that case I'll change this task from a Bug to a To Do, and put it in the appropriate work board. It would be nice to lift such a limitation at some point, but that probably would require doing some proper design work.

Sybren A. Stüvel (sybren) moved this task from Backlog to TODOs on the Animation & Rigging board.Dec 12 2019, 4:40 PM
Sybren A. Stüvel (sybren) edited a custom field.
Ryan Southall (rgsouthall) added a subscriber: Ryan Southall (rgsouthall).Jan 5 2020, 8:11 PM
Ryan Southall (rgsouthall) added a comment.Jan 5 2020, 8:20 PM

Most of my addon's interface is in the form of nodes with their own properties, so I would very much like to see this capability reimplemented.

Evan Wilson (EAW) merged a task: T74050: Custom depsgraph keyframe doesn't interpolate.Feb 20 2020, 10:01 PM
Evan Wilson (EAW) added a subscriber: Chrystia (roquito17).
Ahmed Kamal (a.kamal) added a subscriber: Ahmed Kamal (a.kamal).Feb 29 2020, 12:34 PM
Andrzej (endrju555) added a subscriber: Andrzej (endrju555).EditedMar 30 2020, 11:49 PM
In T66392#749929, @Jacques Lucke (JacquesLucke) wrote:

This is a fairly well known limitation. I'm not sure what is needed to make it work, but we should be able to figure that out.
For animation nodes, I usually advice people to not keyframe their nodes but create controller objects in the 3d view instead.

Should still be fixed though... Not sure if there is already another bug report for this.

Hello! Can you tell more about this controllers setup? I can't find informations about how to set it up. I mean in Animation Nodes, because in Node Editor it works when I use drivers

Sybren A. Stüvel (sybren) added a comment.EditedMar 31 2020, 10:22 AM
In T66392#900690, @Andrzej (endrju555) wrote:

Hello! Can you tell more about this controllers setup? I can't find informations about how to set it up. I mean in Animation Nodes, because in Node Editor it works when I use drivers

This is a bug tracker, not a support forum. Please visit https://animation-nodes.com/ for info about Animation Nodes.

Hitokage added a subscriber: Hitokage.EditedApr 21 2020, 8:53 AM

Yes this is quite an annoying problem. I solved it by using bpy.app.handlers.frame_change_pre but...
EDIT: Seems like I just was able to call update but not to get the actual correct value from the property :-(.
EDIT2: Weird, in compositor for example I can see the good result but not when rendering even when using bpy.app.handlers.render_pre. Seems like when changing frame like when clicking or pressing arrow key the animated value is working but not during render. Is it related to T63548?

Sybren A. Stüvel (sybren) moved this task from Backlog to Long Term on the Dependency Graph board.Aug 11 2020, 4:35 PM
Matt Dougan (mattdougan) added a subscriber: Matt Dougan (mattdougan).Oct 15 2020, 9:43 PM
Radu Popovici (rpopovici) added a subscriber: Radu Popovici (rpopovici).Nov 2 2020, 7:08 PM
Sybren A. Stüvel (sybren) moved this task from TODOs to Needs Investigation on the Animation & Rigging board.Nov 16 2020, 3:54 PM
Philipp Oeser (lichtwerk) renamed this task from Keyframes and animations on custom nodes properties seem not working to Keyframes and drivers on custom nodes properties seem not working.Nov 17 2020, 5:28 PM
Philipp Oeser (lichtwerk) mentioned this in T78383: Drivers do not update Properties in custom pyNode trees.
Philipp Oeser (lichtwerk) merged a task: T78383: Drivers do not update Properties in custom pyNode trees.
Philipp Oeser (lichtwerk) added projects: Python API, Nodes.
Philipp Oeser (lichtwerk) added a subscriber: Netherby (netherby).
jc_4_me@hotmail.com (Bariboy) added a subscriber: jc_4_me@hotmail.com (Bariboy).Jan 29 2021, 4:36 PM
Travis (Travis) added a subscriber: Travis (Travis).Wed, Feb 3, 6:53 PM