blender/blender
blender/blender
185
590
Fork 908
Code Issues 6.3k Pull Requests 1.1k Projects 22 Wiki Activity

Keyframes and drivers on custom nodes properties seem not working #66392

New Issue
Open
opened 2019-07-04 00:45:39 +02:00 by Lorenzo Celli · 31 comments
Lorenzo Celli commented 2019-07-04 00:45:39 +02:00
Copy Link

System Information
Operating system: Darwin-18.2.0-x86_64-i386-64bit 64 Bits
Graphics card: Intel(R) Iris(TM) Graphics 540 Intel Inc. 4.1 INTEL-12.4.7

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-02 22:33, hash: 50ccbe6bb2
Worked: (optional)

Short description of error
I'm not able to animate the properties of custom nodes. Keyframes do not work properly: when I set one all the others seem to disappear and only the last value set as a keyframe is shown on every time step.

Exact steps for others to reproduce the error

  1. Go to the text editor, import the 'Custom Nodes' template and run the script.
  2. Open the 'Custom Node Tree' area.
  3. Add a 'Custom Node', in the 'Some Nodes' category.
  4. Add a keyframe for 'my_float_prop' on frame 1.
  5. Change the frame, change 'my_float_prop' value and set a keyframe.
  6. Now I should see (at least it was like this in the last version) the property changing while scrolling through the timeline between the two keyframes I just set, but I don't. The property keeps the last value.
**System Information** Operating system: Darwin-18.2.0-x86_64-i386-64bit 64 Bits Graphics card: Intel(R) Iris(TM) Graphics 540 Intel Inc. 4.1 INTEL-12.4.7 **Blender Version** Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-02 22:33, hash: `50ccbe6bb2` Worked: (optional) **Short description of error** I'm not able to animate the properties of custom nodes. Keyframes do not work properly: when I set one all the others seem to disappear and only the last value set as a keyframe is shown on every time step. **Exact steps for others to reproduce the error** 1. Go to the text editor, import the 'Custom Nodes' template and run the script. 2. Open the 'Custom Node Tree' area. 3. Add a 'Custom Node', in the 'Some Nodes' category. 4. Add a keyframe for 'my_float_prop' on frame 1. 5. Change the frame, change 'my_float_prop' value and set a keyframe. 6. Now I should see (at least it was like this in the last version) the property changing while scrolling through the timeline between the two keyframes I just set, but I don't. The property keeps the last value.
Lorenzo Celli commented 2019-07-04 00:45:39 +02:00
Author
Copy Link

Added subscriber: @lorenzocelli

Added subscriber: @lorenzocelli
blender-admin commented 2019-07-04 00:45:39 +02:00
Copy Link

#78383 was marked as duplicate of this issue

#78383 was marked as duplicate of this issue
blender-admin commented 2019-07-04 00:45:39 +02:00
Copy Link

#74050 was marked as duplicate of this issue

#74050 was marked as duplicate of this issue
Philipp Oeser commented 2019-07-04 10:09:18 +02:00
Member
Copy Link

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser commented 2019-07-04 10:09:18 +02:00
Member
Copy Link

Confirmed.

note: #63793, #63548 might be related...

Confirmed. note: #63793, #63548 might be related...
Daniele De Luca commented 2019-08-07 14:50:45 +02:00
Copy Link

Added subscriber: @Sparazza

Added subscriber: @Sparazza
Tuomo Keskitalo commented 2019-08-09 07:55:43 +02:00
Copy Link

Added subscribers: @JacquesLucke, @TuomoKeskitalo

Added subscribers: @JacquesLucke, @TuomoKeskitalo
Tuomo Keskitalo commented 2019-08-09 07:55:43 +02:00
Copy Link

I found out that this bug (keyframing property values is not working for custom nodes) seem to exist also in Animation Nodes on Blender 2.80, FYI @JacquesLucke

I found out that this bug (keyframing property values is not working for custom nodes) seem to exist also in Animation Nodes on Blender 2.80, FYI @JacquesLucke
Tuomo Keskitalo commented 2019-08-09 09:14:07 +02:00
Copy Link

Hmm, it looks like the animated f-curve evaluates correctly in python console via D.node_groups['NodeTree'].animation_data.action.fcurves- [x].evaluate() even though value shown in node is not updated.

@lorenzocelli can you please test: is the animated value actually changing correctly, even though value is not shown updated on the node?

Hmm, it looks like the animated f-curve evaluates correctly in python console via D.node_groups['NodeTree'].animation_data.action.fcurves- [x].evaluate() even though value shown in node is not updated. @lorenzocelli can you please test: is the animated value actually changing correctly, even though value is not shown updated on the node?
Jacques Lucke commented 2019-08-10 08:28:51 +02:00
Member
Copy Link

This is a fairly well known limitation. I'm not sure what is needed to make it work, but we should be able to figure that out.
For animation nodes, I usually advice people to not keyframe their nodes but create controller objects in the 3d view instead.

Should still be fixed though... Not sure if there is already another bug report for this.

This is a fairly well known limitation. I'm not sure what is needed to make it work, but we should be able to figure that out. For animation nodes, I usually advice people to not keyframe their nodes but create controller objects in the 3d view instead. Should still be fixed though... Not sure if there is already another bug report for this.
Lorenzo Celli commented 2019-08-10 10:05:47 +02:00
Author
Copy Link

@TuomoKeskitalo I tested it and to me it seems that the properties don't update at all, not in the UI and not by accessing them via python. The last keyframe you set just becomes the value for all frames, ignoring the other keyframes you set before

@TuomoKeskitalo I tested it and to me it seems that the properties don't update at all, not in the UI and not by accessing them via python. The last keyframe you set just becomes the value for all frames, ignoring the other keyframes you set before
Tuomo Keskitalo commented 2019-08-11 09:05:36 +02:00
Copy Link

It looks like this goes down to somewhere in depsgraph/animation sources of Blender. Beyond my skills, so I hope someone more experienced can help. At least the F-curve is there apparently OK. Thanks @lorenzocelli for confirmation.

It looks like this goes down to somewhere in depsgraph/animation sources of Blender. Beyond my skills, so I hope someone more experienced can help. At least the F-curve is there apparently OK. Thanks @lorenzocelli for confirmation.
Lorenzo Celli commented 2019-09-06 19:18:14 +02:00
Author
Copy Link

Anything new? Maybe I'm missing another similar bug report

Anything new? Maybe I'm missing another similar bug report
Lorenzo Celli commented 2019-11-14 20:46:53 +01:00
Author
Copy Link

Hello everybody! Any news?

Hello everybody! Any news?
Sybren A. Stüvel commented 2019-12-12 16:40:02 +01:00
Member
Copy Link

Added subscriber: @dr.sybren

Added subscriber: @dr.sybren
Sybren A. Stüvel commented 2019-12-12 16:40:02 +01:00
Member
Copy Link

In #66392#749929, @JacquesLucke wrote:
This is a fairly well known limitation.

In that case I'll change this task from a Bug to a To Do, and put it in the appropriate work board. It would be nice to lift such a limitation at some point, but that probably would require doing some proper design work.

> In #66392#749929, @JacquesLucke wrote: > This is a fairly well known limitation. In that case I'll change this task from a Bug to a To Do, and put it in the appropriate work board. It would be nice to lift such a limitation at some point, but that probably would require doing some proper design work.
Ryan Southall commented 2020-01-05 20:11:58 +01:00
Copy Link

Added subscriber: @RyanSouthall

Added subscriber: @RyanSouthall
Ryan Southall commented 2020-01-05 20:20:30 +01:00
Copy Link

Most of my addon's interface is in the form of nodes with their own properties, so I would very much like to see this capability reimplemented.

Most of my addon's interface is in the form of nodes with their own properties, so I would very much like to see this capability reimplemented.
Evan Wilson commented 2020-02-20 22:01:15 +01:00
Member
Copy Link

Added subscriber: @roquito17

Added subscriber: @roquito17
Ahmed Kamal commented 2020-02-29 12:34:46 +01:00
Copy Link

Added subscriber: @AhmedKamal

Added subscriber: @AhmedKamal
Andrzej commented 2020-03-30 23:49:03 +02:00
Copy Link

Added subscriber: @endrju555

Added subscriber: @endrju555
Andrzej commented 2020-03-30 23:49:03 +02:00
Copy Link

In #66392#749929, @JacquesLucke wrote:
This is a fairly well known limitation. I'm not sure what is needed to make it work, but we should be able to figure that out.
For animation nodes, I usually advice people to not keyframe their nodes but create controller objects in the 3d view instead.

Should still be fixed though... Not sure if there is already another bug report for this.

Hello! Can you tell more about this controllers setup? I can't find informations about how to set it up. I mean in Animation Nodes, because in Node Editor it works when I use drivers

> In #66392#749929, @JacquesLucke wrote: > This is a fairly well known limitation. I'm not sure what is needed to make it work, but we should be able to figure that out. > For animation nodes, I usually advice people to not keyframe their nodes but create controller objects in the 3d view instead. > > Should still be fixed though... Not sure if there is already another bug report for this. Hello! Can you tell more about this controllers setup? I can't find informations about how to set it up. I mean in Animation Nodes, because in Node Editor it works when I use drivers
Sybren A. Stüvel commented 2020-03-31 10:22:59 +02:00
Member
Copy Link

In #66392#900690, @endrju555 wrote:
Hello! Can you tell more about this controllers setup? I can't find informations about how to set it up. I mean in Animation Nodes, because in Node Editor it works when I use drivers

This is a bug tracker, not a support forum. Please visit https://animation-nodes.com/ for info about Animation Nodes.

> In #66392#900690, @endrju555 wrote: > Hello! Can you tell more about this controllers setup? I can't find informations about how to set it up. I mean in Animation Nodes, because in Node Editor it works when I use drivers This is a bug tracker, not a support forum. Please visit https://animation-nodes.com/ for info about Animation Nodes.
ichlubna commented 2020-04-21 08:53:29 +02:00
Copy Link

Added subscriber: @ichlubna

Added subscriber: @ichlubna
ichlubna commented 2020-04-21 08:53:29 +02:00
Copy Link

Yes this is quite an annoying problem. I solved it by using bpy.app.handlers.frame_change_pre but...
EDIT: Seems like I just was able to call update but not to get the actual correct value from the property :-(.
EDIT2: Weird, in compositor for example I can see the good result but not when rendering even when using bpy.app.handlers.render_pre. Seems like when changing frame like when clicking or pressing arrow key the animated value is working but not during render. Is it related to #63548?

Yes this is quite an annoying problem. I solved it by using **bpy.app.handlers.frame_change_pre** but... EDIT: Seems like I just was able to call update but not to get the actual correct value from the property :-(. EDIT2: Weird, in compositor for example I can see the good result but not when rendering even when using bpy.app.handlers.render_pre. Seems like when changing frame like when clicking or pressing arrow key the animated value is working but not during render. Is it related to #63548?
Matt Dougan commented 2020-10-15 21:43:27 +02:00
Copy Link

Added subscriber: @matt.dougan

Added subscriber: @matt.dougan
Radu Popovici commented 2020-11-02 19:08:08 +01:00
Copy Link

Added subscriber: @rpopovici

Added subscriber: @rpopovici
Philipp Oeser changed title from Keyframes and animations on custom nodes properties seem not working to Keyframes and drivers on custom nodes properties seem not working 2020-11-17 17:28:48 +01:00
Philipp Oeser commented 2020-11-17 17:29:48 +01:00
Member
Copy Link

Added subscriber: @JerahmyPocott

Added subscriber: @JerahmyPocott
Zach Eastin commented 2021-01-29 16:36:31 +01:00
Copy Link

Added subscriber: @Zeastin

Added subscriber: @Zeastin
Travis commented 2021-02-03 18:53:07 +01:00
Copy Link

Added subscriber: @TravisOBrien

Added subscriber: @TravisOBrien
Dylan Valentine commented 2021-06-25 18:13:47 +02:00
Copy Link

Added subscriber: @Dval

Added subscriber: @Dval
Philipp Oeser removed the
Interest
Animation & Rigging
 label 2023-02-09 14:36:41 +01:00
Philipp Oeser added the
Interest
Core
 label 2023-02-10 11:09:57 +01:00
Sybren A. Stüvel added this to the Module: Animation & Rigging project 2023-02-14 15:32:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Asset datablocks, libraries, browser and shelf
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Code comments, Python/RNA API descriptions
Interest
Collada
Interest
Compatibility
Backward and forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
FBX I/O related topics
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Wayland windowing on Unix
Interest
Workbench
Interest
glTF
glTF format I/O topics
Interest: X11
Xorg/X11 windowing
Legacy
Asset Browser Project
Archived
Legacy
Blender 2.8 Project
Archived
Legacy
Milestone 1: Basic, Local Asset Browser
Archived
Legacy
OpenGL Error
Archived
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Archived
Type
Report
Archived
Type
To Do
No Label
Interest
Core
Interest
Dependency Graph
Interest
Nodes & Physics
Module
Animation & Rigging
Severity
Normal
Status
Confirmed
Type
To Do
Milestone
No items
No Milestone
Projects
Clear projects
No project Module: Animation & Rigging
Assignees
Clear assignees
Hoshinova James-McCarthy-4 Sebastian-Herholz casey-bianco-davis gandalf3 Blendify Aaron Carlisle quantimoney Aditya Y Jeppu Alaska Alaska angavrilov Alexander Gavrilov frogstomp Aleš Jelovčan amelief Amélie Fondevilla elubie Andrea Weikert Andy_Goralczyk Andy Goralczyk ankitm Ankit Meel Anthony-Roberts Anthony Roberts antoniov Antonio Vazquez aras_p Aras Pranckevicius Arnd Arnd Marijnissen bartvdbraak Bart van der Braak mont29 Bastien Montagne blender-bot Blender Bot bnagirniak Bogdan Nagirniak BClark Brad Clark brecht Brecht Van Lommel BrianSavery Brian Savery (AMD) ideasman42 Campbell Barton CharlesWardlaw Charles Wardlaw CharlieJolly Charlie Jolly Chris_Blackbourn Chris Blackbourn lateasusual Chris Clyne (Lateasusual) ChrisLend Christoph Lendenfeld HobbesOS Cian Jinks fclem Clément Foucault cmbasnett Colin Basnett Kdaf Colin Marmond dfelinto Dalai Felinto pioverfour Damien Picard DanielBystedt Daniel Bystedt pepe-school-land Daniel Martinez Lara zanqdo Daniel Salazar Mets Demeter Dzadik erik85 Erik Abrahamsson EAW Evan Wilson filedescriptor Falk David fsiddi Francesco Siddi GaiaClary Gaia Clary DagerD Georgiy Markelov mano-wii Germano Cavalcante zazizizou Habib Gahbiche HooglyBoogly Hans Goudey Harley Harley Acheson weasel Henrik D. Hjalti Hjalti Hjálmarsson howardt Howard Trickey nirved-1 Hristo Gueorguiev mod_moder Iliya Katushenock brita Inês Almeida JacquesLucke Jacques Lucke Jason-Fielder Jason Fielder JasonSchleifer Jason schleifer Jebbly Jeffrey Liu Jeroen-Bakker Jeroen Bakker deadpin Jesse Yurkovich neXyon Joerg Mueller eliphaz John Kiril Swenson guitargeek Johnny Matthews Brainzman Jonas Holzman JoniMercado Jonatan Mercado JorgeBernalMartinez Jorge Bernal JosephEagar Joseph Eagar JoshuaLeung Joshua Leung Bone-Studio Juan Gea jpbouza-4 Juan Pablo Bouza JulianEisel Julian Eisel JulienDuroure Julien Duroure JulienKaspar Julien Kaspar kevindietrich Kévin Dietrich lone_noel Leon Schittek LucianoMunoz Luciano Muñoz Sessarego LukasStockner Lukas Stockner LukasTonne Lukas Tönne LunaRood Luna Rood MaiLavelle Mai Lavelle EosFoxx Marion Stalke Baardaap Martijn Versteegh scorpion81 Martin Felke mendio Matias Mendiola Matt-McLin Matt McLin MetinSeven Metin Seven wave Michael B Johnson Michael-Jones Michael Jones (Apple) makowalski Michael Kowalski pragma37 Miguel Pozo nrupsis Nate Rupsis jesterking Nathan Letwory nathanvegdahl Nathan Vegdahl PrototypeNM1 Nicholas Rishel nickberckley Nika Kutsniashvili Sirgienko Nikita Sirgienko OmarEmaraDev Omar Emara pablovazquez Pablo Vazquez PaoloAcampora Paolo Acampora PascalSchon Pascal Schön pmoursnv Patrick Mours muxed-reality Peter Kim lichtwerk Philipp Oeser P2design Pierrick PICAUT PratikPB2123 Pratik Borhade Limarest Ramil Roosileht farsthary Raul Fernandez Hernandez LazyDodo Ray molenkamp iss Richard Antalik rjg Robert Guetzkow salipour Sahar A. Kashi Sayak-Biswas Sayak Biswas Sean-Kim Sean Kim sherholz Sebastian Herholz sebastian_k Sebastian Koenig ZedDB Sebastian Parborg sebbas Sebastián Barschkis Sergey Sergey Sharybin IRIEShinsuke Shinsuke Irie sidd017 Siddhartha Jejurkar SietseB Sietse Brouwer SimonThommes Simon Thommes SonnyCampbell_Unity Sonny Campbell Stefan_Werner Stefan Werner Lockal Sv. Lockal dr.sybren Sybren A. Stüvel ThomasDinges Thomas Dinges Ton Ton Roosendaal Vasyl-Pidhirskyi Vasyl Pidhirskyi WannesMalfait Wannes Malfait wbmoss_dev Wayde Moss weizhen Weizhen Huang leesonw William Leeson xavierh Xavier Hallade jenkm Yevgeny Makarov ChengduLittleA YimingWu BassamKurdali bassam kurdali gfxcoder jon denning
No Assignees
17 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#66392
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?