child's objects move if change their origin position #66526

New Issue

Ivan Vostrikov · 2019-07-07T14:07:02+02:00

Ivan Vostrikov commented

2019-07-07 14:07:02 +02:00

Set_Origin_Bug.blend
System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce 920M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 416.81

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-05 16:36, hash: 699193713f
Worked: 2.79b

Short description of error
If change origin position for object with parent, this object (and his childer) will be moved.

Exact steps for others to reproduce the error

Open "Set_Origin_Bug.blend"
Select All
RMB -> Set Origin -> Origin to 3D Cursor

[Set_Origin_Bug.blend](https://archive.blender.org/developer/F7571690/Set_Origin_Bug.blend) **System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: GeForce 920M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 416.81 **Blender Version** Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-05 16:36, hash: `699193713f` Worked: 2.79b **Short description of error** If change origin position for object with parent, this object (and his childer) will be moved. **Exact steps for others to reproduce the error** - Open "Set_Origin_Bug.blend" - Select All - RMB -> Set Origin -> Origin to 3D Cursor

Ivan Vostrikov commented

2019-07-07 14:07:03 +02:00

Added subscriber: @IvanVostrikov

Philipp Oeser commented

2019-07-08 11:30:11 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-07-08 11:30:11 +02:00

Confirmed, checking...

Sergey Sharybin was assigned by Philipp Oeser

2019-07-08 12:24:11 +02:00

Philipp Oeser commented

2019-07-08 12:24:11 +02:00

Added subscriber: @Sergey

Philipp Oeser commented

2019-07-08 12:24:11 +02:00

This is one of those cases where we are doing something to a hierarchy and it would be preferred to do this all in evaluated domain?
Seems like we need to do something similar to 26d4a2a516 in object_origin_set_exec as well

Object *ob_eval = DEG_get_evaluated_object(depsgraph, ob);
BKE_object_transform_copy(ob_eval, ob);

BKE_object_where_is_calc(depsgraph, scene, ob_eval);
if (ob->type == OB_ARMATURE) {
  /* needed for bone parents */
  BKE_pose_where_is(depsgraph, scene, ob_eval);
}

but since that seems to be failing for nested relationships (see #66525) I think it makes sense if @Sergey squashes this nastyness for this report as well?
(@Sergey: feel free to bounce back -- I just think you will kill it faster....)

This is one of those cases where we are doing something to a hierarchy and it would be preferred to do this all in evaluated domain? Seems like we need to do something similar to 26d4a2a516 in `object_origin_set_exec` as well ``` Object *ob_eval = DEG_get_evaluated_object(depsgraph, ob); BKE_object_transform_copy(ob_eval, ob); BKE_object_where_is_calc(depsgraph, scene, ob_eval); if (ob->type == OB_ARMATURE) { /* needed for bone parents */ BKE_pose_where_is(depsgraph, scene, ob_eval); } ``` but since that seems to be failing for nested relationships (see #66525) I think it makes sense if @Sergey squashes this nastyness for this report as well? (@Sergey: feel free to bounce back -- I just think you will kill it faster....)

blender-admin commented

2019-07-08 12:31:27 +02:00

This issue was referenced by 4ca054617b

This issue was referenced by 4ca054617ba1552eb06d46f32b5c007632b0dd11

Philipp Oeser commented

2019-07-08 12:34:03 +02:00

Can confirm doing the above works after d6ebd04bb3 was just in...

Can confirm doing the above works after d6ebd04bb3 was just in...

Sergey Sharybin commented

2019-07-08 12:44:23 +02:00

@lichtwerk, i might solve each individual case faster, but when you take amount of stuff i'll then be going through..
Looking into the patch now.

@lichtwerk, i might solve each individual case faster, but when you take amount of stuff i'll then be going through.. Looking into the patch now.