"Auto Save Modified Image" when closing blender is not working. #66628

New Issue

Gustavo · 2019-07-09T22:49:18+02:00

Gustavo commented

2019-07-09 22:49:18 +02:00

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce GTX 950/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 399.24

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-09 12:03, hash: db45aaafab
Worked: (optional)

Short description of error
"Auto Save modified image" when closing blender is not working.

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

1 - Enter texture paint mode with any object that already has an image assigned to it.
2 - Paint something.
3 - Save the blend file without saving the image.
4 - close blender (Blander will say: "This file has unsaved changes - Save 1 modified image").
5 - Click Save to save the image and close Blender
6 - When we open blender and the file again, the image is opened with the base color, but without the texture paint that was done.

**System Information** Operating system: Windows-10-10.0.18362 64 Bits Graphics card: GeForce GTX 950/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 399.24 **Blender Version** Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-09 12:03, hash: `db45aaafab` Worked: (optional) **Short description of error** "Auto Save modified image" when closing blender is not working. **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] 1 - Enter texture paint mode with any object that already has an image assigned to it. 2 - Paint something. 3 - Save the blend file without saving the image. 4 - close blender (Blander will say: "This file has unsaved changes - Save 1 modified image"). 5 - Click Save to save the image and close Blender 6 - When we open blender and the file again, the image is opened with the base color, but without the texture paint that was done.

Gustavo commented

2019-07-09 22:49:18 +02:00

Added subscriber: @GustavoRosa

Craig Dolphin commented

2019-07-10 16:43:49 +02:00

Added subscriber: @CraigD

Craig Dolphin commented

2019-07-10 16:43:49 +02:00

I was able to replicate this issue. Doesn't seem to matter if the image is new, packed, or a file object. unsaved edits to image do not seem to be getting saved.

Germano Cavalcante commented

2019-07-10 16:55:33 +02:00

Added subscribers: @JacquesLucke, @mano-wii

Jacques Lucke was assigned by Germano Cavalcante

2019-07-10 16:55:33 +02:00

Germano Cavalcante commented

2019-07-10 16:55:33 +02:00

Feature implemented on 5ce3f69d.
@JacquesLucke, am I doing something wrong? Because I can confirm it and I suppose this is a high priority bug.

Feature implemented on 5ce3f69d. @JacquesLucke, am I doing something wrong? Because I can confirm it and I suppose this is a high priority bug.

Jacques Lucke commented

2019-07-10 17:28:29 +02:00

Looks like this broke in 11c9702dd4.

Looks like this broke in 11c9702dd4.

Jacques Lucke commented

2019-07-10 17:33:40 +02:00

Added subscriber: @brecht

Jacques Lucke commented

2019-07-10 17:40:01 +02:00

Something like this should fix the issue:

diff --git a/source/blender/windowmanager/intern/wm_files.c b/source/blender/windowmanager/intern/wm_files.c
index 49b13da6b21..ef957fa03c5 100644
--- a/source/blender/windowmanager/intern/wm_files.c
+++ b/source/blender/windowmanager/intern/wm_files.c
@@ -2949,7 +2949,12 @@ static void wm_block_file_close_save(bContext *C, void *arg_block, void *arg_dat
   UI_popup_block_close(C, win, arg_block);
 
   if (save_images_when_file_is_closed) {
-    if (!ED_image_should_save_modified(C)) {
+    if (ED_image_should_save_modified(C)) {
+      ReportList *reports = CTX_wm_reports(C);
+      ED_image_save_all_modified(C, reports);
+      WM_report_banner_show();
+    }
+    else {
       execute_callback = false;
     }
   }

@brecht, any reason for why you removed this partially?

Something like this should fix the issue: ``` diff --git a/source/blender/windowmanager/intern/wm_files.c b/source/blender/windowmanager/intern/wm_files.c index 49b13da6b21..ef957fa03c5 100644 --- a/source/blender/windowmanager/intern/wm_files.c +++ b/source/blender/windowmanager/intern/wm_files.c @@ -2949,7 +2949,12 @@ static void wm_block_file_close_save(bContext *C, void *arg_block, void *arg_dat UI_popup_block_close(C, win, arg_block); if (save_images_when_file_is_closed) { - if (!ED_image_should_save_modified(C)) { + if (ED_image_should_save_modified(C)) { + ReportList *reports = CTX_wm_reports(C); + ED_image_save_all_modified(C, reports); + WM_report_banner_show(); + } + else { execute_callback = false; } } ``` @brecht, any reason for why you removed this partially?

Brecht Van Lommel commented

2019-07-11 11:47:06 +02:00

@JacquesLucke I'm not sure what I was thinking, I think your fix is fine.