Crash when trying to show a Workspace using a deleted Screen. #67004

New Issue

Bastien Montagne · 2019-07-15T18:05:58+02:00

Bastien Montagne commented

2019-07-15 18:05:58 +02:00

If a Screen ID is deleted, and one then try to show a Worspace using it, Blender will crash.

Setting to low prio since deleting a Screen ID is not easy to do for end user currently (you'll have to use py console, e.g. bpy.data.batch_remove(ids=(bpy.data.screens- [x],))), but still, this is violating general design and expected sane behavior of ID handling.

Think solution should be either:

Deleting Screens IDs should be forbidden (not ideal, since it kind of breaks general ID design, but should be doable).
Deleting Screens IDs should also delete matching Workspace (not ideal either, there should not be that kind of relationships between IDs, but we already have similar things between objects and obdata...).
Or (probably the sanest thing to do) a Workspace should handle gracefully the case where it has no assigned Screen.

If a Screen ID is deleted, and one then try to show a Worspace using it, Blender will crash. Setting to low prio since deleting a Screen ID is not easy to do for end user currently (you'll have to use py console, e.g. `bpy.data.batch_remove(ids=(bpy.data.screens- [x],))`), but still, this is violating general design and expected sane behavior of ID handling. Think solution should be either: * Deleting Screens IDs should be forbidden (not ideal, since it kind of breaks general ID design, but should be doable). * Deleting Screens IDs should also delete matching Workspace (not ideal either, there should not be that kind of relationships between IDs, but we already have similar things between objects and obdata...). * Or (probably the sanest thing to do) a Workspace should handle gracefully the case where it has no assigned Screen.

Bastien Montagne commented

2019-07-15 18:05:59 +02:00

Added subscribers: @mont29, @brecht, @dfelinto, @ideasman42

Julian Eisel commented

2020-04-07 19:43:22 +02:00

Added subscribers: @WilliamReynish, @JulianEisel

Julian Eisel commented

2020-04-07 19:43:22 +02:00

As a user I would expect an error message in this case, informing me that a screen is still referenced by some workspace. It could allow deleting that workspace too, but I guess it's better to just show the workspace name in the error message and let the user delete it manually if wanted.

Personally I don't think it's a big deal to violate the general ID design for Screens, simply because I see no good reason to keep them as IDs anymore. On a conceptual level their role was superseded by workspaces and they could "just" become regular workspace data by now (also see the WorkSpaceLayout wrapper). I see the workspace <-> screens relationship similar to the window-manager <-> windows one.
Obviously that is a bigger discussion to have.

As a user I would expect an error message in this case, informing me that a screen is still referenced by some workspace. It could allow deleting that workspace too, but I guess it's better to just show the workspace name in the error message and let the user delete it manually if wanted. Personally I don't think it's a big deal to violate the general ID design for Screens, simply because I see no good reason to keep them as IDs anymore. On a conceptual level their role was superseded by workspaces and they could "just" become regular workspace data by now (also see the `WorkSpaceLayout` wrapper). I see the workspace <-> screens relationship similar to the window-manager <-> windows one. Obviously that is a bigger discussion to have.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when trying to show a Workspace using a deleted Screen. #67004